Re: [proposal] Move all of the ksecretsservice components into kdeutils/ksecrets

2011-11-14 Thread Kevin Ottens
On Monday 14 November 2011 21:42:27 Valentin Rusu wrote: > The libs part would lead to a Tier2 library - I expected that and your > other mail confirms it. > May it contain the other ksecretsservice components such as the deamon > and the sync tool (those who are already under kdeutils)? > Dependin

Re: [proposal] Move all of the ksecretsservice components into kdeutils/ksecrets

2011-11-14 Thread Kevin Kofler
Kevin Ottens wrote: > * Introducing a plugin loading approach inside of the KWallet convenience > API > * Make your current code for the KWallet convenience API a plugin for > the above mechanism (seeing your code right now, it'll even map fairly > well as in most places it's right now "if (m_secre

Review Request: Fix KDateComboBox shrinking in size after a date is entered

2011-11-14 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103133/ --- Review request for kdelibs and John Layt. Description --- After the u

Re: [proposal] Move all of the ksecretsservice components into kdeutils/ksecrets

2011-11-14 Thread Valentin Rusu
On 11/14/2011 09:19 PM, Aaron J. Seigo wrote: On Monday, November 14, 2011 18:04:08 Kevin Ottens wrote: > * Introducing a plugin loading approach inside of the KWallet convenience > API * Make your current code for the KWallet convenience API a plugin for > the above mechanism (seeing you

Re: [proposal] Move all of the ksecretsservice components into kdeutils/ksecrets

2011-11-14 Thread Valentin Rusu
On 11/14/2011 06:04 PM, Kevin Ottens wrote: On Saturday 12 November 2011 11:35:22 Valentin Rusu wrote: And the circular dependency will be there as long as kdecore (where KCompositeJob lives) and kdeui (where KWallet lives) are tied together. Here is the schema : - KWallet legacy code *needs* KS

Re: [proposal] Move all of the ksecretsservice components into kdeutils/ksecrets

2011-11-14 Thread Aaron J. Seigo
On Monday, November 14, 2011 18:04:08 Kevin Ottens wrote: > * Introducing a plugin loading approach inside of the KWallet convenience > API * Make your current code for the KWallet convenience API a plugin for > the above mechanism (seeing your code right now, it'll even map fairly well > as in mo

Re: [proposal] Move all of the ksecretsservice components into kdeutils/ksecrets

2011-11-14 Thread Kevin Krammer
On Monday, 2011-11-14, Kevin Ottens wrote: > Right. Although I don't expect a kdeui to still exist in the end. The > relevant KWallet code might end up in a kde4support I think. For that to > happen we'd need a similar convenience API in libksecretservice itself if > deemed appropriate (the whole

Re: [proposal] Move all of the ksecretsservice components into kdeutils/ksecrets

2011-11-14 Thread Kevin Ottens
On Monday 14 November 2011 06:48:50 Aaron J. Seigo wrote: > On Saturday, November 12, 2011 13:38:47 Valentin Rusu wrote: > > Ok, I'll then move it somewhere else. I'm very tempted by the kdecore > > module, the place where it's main dependency, KCompositeJob, lives. > > > > But I think the best pla

Re: [proposal] Move all of the ksecretsservice components into kdeutils/ksecrets

2011-11-14 Thread Kevin Ottens
On Saturday 12 November 2011 11:35:22 Valentin Rusu wrote: > On 11/12/2011 11:24 AM, Kevin Ottens wrote: > > So that was the intent of my previous email, now that the red flag got > > raised for inclusion in kdelibs master, why not going for a separate > > repository? > That's exactly what I'm doin

Re: Review Request: Fix wrong whatsThis strings in proxy kcm

2011-11-14 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103131/#review8197 --- Ship it! There is no longer any default value set for any of th

Re: Review Request: [KTextEdit] Handle actions depending on modes/flags

2011-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102919/#review8195 --- This review has been submitted with commit 547efae3b79e39b02b64

Re: Review Request: [KTextEdit] Handle actions depending on modes/flags

2011-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102919/#review8194 --- This review has been submitted with commit bb01bd6bcd5f2353c247

Re: Review Request: Update tab labels list after moving when using QTabWidget::setMovable()

2011-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102628/#review8192 --- This review has been submitted with commit fc5f17480bd2d6b6708e

Re: Request: remove libkactivites from kdelibs (in experimental/)

2011-11-14 Thread Aaron J. Seigo
On Monday, November 14, 2011 10:35:16 Thomas Friedrichsmeier wrote: > My main focus of development is on a KDE-based application, not kdelibs. But > every once in a while, I find a bug in kdelibs, and I want to contribute a > fix. And every once in a blue moon, I want to contribute a small feature.

Review Request: Fix wrong whatsThis strings in proxy kcm

2011-11-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103131/ --- Review request for KDE Base Apps and Dawit Alemayehu. Description ---

Re: Request: remove libkactivites from kdelibs (in experimental/)

2011-11-14 Thread Thomas Friedrichsmeier
Hi, On Monday 14 November 2011, Aaron J. Seigo wrote: > besides kde-core-devel, it was also blogged by a number of attendees, so > planetkde.org readership was in the loop. there was a story on dot.kde.org, > so dot.kde.org readership was in the loop. there's documentation on > community.kde.org