Re: Re: Review request for KSecretsService components

A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: > On 11/10/2011 01:00 AM, Valentin Rusu wrote: > > On 11/10/2011 12:48 AM, Albert Astals Cid wrote: > * createItem falls in the "let's use a bool instead of an > enum > because it> > > just have tw

Review Request: Provide extra options for date keyword display in KDateComboBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103103/ --- Review request for kdelibs and John Layt. Description --- KDateComboB

Re: Re: Review request for KSecretsService components

A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: > On 11/10/2011 12:48 AM, Albert Astals Cid wrote: > > A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: > >> Hello Albert, > >> > >> Thanks for the thourough review. > >> > >> On 11/09/2011 03:26 PM, Albert Astals Cid

Re: Review request for KSecretsService components

On 11/10/2011 01:00 AM, Valentin Rusu wrote: On 11/10/2011 12:48 AM, Albert Astals Cid wrote: * createItem falls in the "let's use a bool instead of an enum because it> just have two values" trap for the replace parameter Well, I don't agree. When presenting a new item to the collec

Re: Review request for KSecretsService components

On 11/10/2011 12:48 AM, Albert Astals Cid wrote: A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: Hello Albert, Thanks for the thourough review. On 11/09/2011 03:26 PM, Albert Astals Cid wrote: This is scary, last time i used kwallet, i had to add a single line, and now there a

Re: Re: Review request for KSecretsService components

A Dijous, 10 de novembre de 2011, Valentin Rusu vàreu escriure: > Hello Albert, > > Thanks for the thourough review. > > On 11/09/2011 03:26 PM, Albert Astals Cid wrote: > > This is scary, last time i used kwallet, i had to add a single line, and > > now there are like a billion of classes? > >

Re: Review request for KSecretsService components

Hello Albert, Thanks for the thourough review. On 11/09/2011 03:26 PM, Albert Astals Cid wrote: A Dimarts, 8 de novembre de 2011, Valentin Rusu vàreu escriure: Hello Again, The freeze will come in less thant two days now and I'd like to know if anyone reviewed these components. Thanks, On 1

I have ALL MOUSE BUTTONS WORKING for xcb and xlib :)) on qt5

My thanks to you, MGrasslin, Aaron, Todd rme, and Thiago for coaching me towards this achievement. The new code is small, and VERY simple. We have no API changes (at least, not yet--- we should implement a mouse button mask "getter" as a new feature, but that's for later

Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)

On Wednesday 09 November 2011 16:45:55 Aaron J. Seigo wrote: > On Wednesday, November 9, 2011 15:28:48 andrea diamantini wrote: > > I think that every app using cookies would like to have this patch > > merged > > ASAP, expecially browsers. > > This will help/fix/improve features like "private brow

Re: Review Request: Fix crash on statusbarextension destruction

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103098/#review8070 --- I can confirm that it fixes bug 283657. - Christoph Feck On N

Re: Review Request: kcm_randr: Fix for Bug 264070 - Cannot apply screen position changes

> On Nov. 9, 2011, 8:50 p.m., Christoph Feck wrote: > > It's already fixed, at least in master. The patch is wrong, too, because > > that signal doesn't exists in QSpinBox. Looks like you did not test it :) > > Christoph Feck wrote: > Sorry, I failed reading, forget what I wrote. > >

Review Request: Fix crash on statusbarextension destruction

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103098/ --- Review request for kdelibs. Description --- With master, Qt 4.8 and k

Re: Review Request: kcm_randr: Fix for Bug 264070 - Cannot apply screen position changes

> On Nov. 9, 2011, 8:50 p.m., Christoph Feck wrote: > > It's already fixed, at least in master. The patch is wrong, too, because > > that signal doesn't exists in QSpinBox. Looks like you did not test it :) Sorry, I failed reading, forget what I wrote. Still, I suggest to use 'valueChanged' si

Re: Review Request: kcm_randr: Fix for Bug 264070 - Cannot apply screen position changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103093/#review8062 --- It's already fixed, at least in master. The patch is wrong, too,

Re: Introducing components, how to

>> [Components-platform] >> name=touch > > something Sune just noted to me.. > maybe an environment variable would be better to chose this? As on override? For that, I'd say +1, otherwise -1 :) -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what

Re: Review Request: Make mouse cursor size configurable

> On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote: > > kcontrol/input/xcursor/cursortheme.cpp, line 119 > > > > > > Scaling a pixmap is more expensive than scaling an image. Internally it > > involves converting

Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)

On Wednesday, November 9, 2011 17:53:58 Alexander Neundorf wrote: > But it will be not before Qt 5.0. the question is "how long after", and the best answer is "as little delay as possible". Qt 5.0 is scheduled for some time in 2012. > Personally, I don't have a problem if not too many people wo

Re: Introducing components, how to

On Wednesday 09 November 2011, Marco Martin wrote: > When writing a widget, an application etc, just use > import org.kde.plasma.components, the proper one is decided by the > kdeclarativerc file, if it has > [Components-platform] > name=touch something Sune just noted to me.. maybe an environment

Introducing components, how to

Hi all, sending here as well after plasma-devel and active there is still some work to do, but the components are almost done in their final structure (good for the upcoming freeze, ehehe :) components are imported with: import org.kde.plasma.components regardless of the platform we're in. We

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102799/#review8055 --- This review has been submitted with commit f7ce3a513baef8479f76

Re: Review Request: KActivities requires Soprano 2.7 to compile

> On Nov. 7, 2011, 3:56 p.m., Ralf Jung wrote: > > Any comment on this? The patch looks trivial, but I am still new to all > > this so I'd prefer if someone could confirm that KActivites can and should > > actually require Soprano 2.7. > > Aaron J. Seigo wrote: > it builds here with 2.6.51

Review Request: kcm_randr: Fix for Bug 264070 - Cannot apply screen position changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103093/ --- Review request for KDE Base Apps, Solid and Alex Fiestas. Description

Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)

On Wednesday 09 November 2011, Aaron J. Seigo wrote: > On Wednesday, November 9, 2011 15:28:48 andrea diamantini wrote: > > I think that every app using cookies would like to have this patch merged > > ASAP, expecially browsers. > > This will help/fix/improve features like "private browsing" and so

Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)

On Wednesday, November 9, 2011 15:28:48 andrea diamantini wrote: > I think that every app using cookies would like to have this patch merged > ASAP, expecially browsers. > This will help/fix/improve features like "private browsing" and so on. > So please don't let us wait for the "big Universe reor

Re: Re: Review request for KSecretsService components

A Dimarts, 8 de novembre de 2011, Valentin Rusu vàreu escriure: > Hello Again, > > The freeze will come in less thant two days now and I'd like to know if > anyone reviewed these components. > > Thanks, > > On 10/31/2011 11:48 PM, Valentin Rusu wrote: > > Hello, > > > > Please be advised three

Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)

I think that every app using cookies would like to have this patch merged ASAP, expecially browsers. This will help/fix/improve features like "private browsing" and so on. So please don't let us wait for the "big Universe reordering" to have it. :) 2011/11/8 Aaron J. Seigo > On Monday, November

Re: Request: remove libkactivites from kdelibs (in experimental/)

On Friday, November 4, 2011 23:05:28 Aaron J. Seigo wrote: > we currently have libkactivities in kdelibs/experimental. due to upcoming > changs and frameworks 5 development, it has been moved into its own git > repository: kactivities. unless there are any further objections, here is what i plan t

Re: Review Request: Make mouse cursor size configurable

> On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote: > > Sorry for not finding the time to follow up on this until now. > > > > The new design is not quite what I had in mind, but given that the freeze > > is tomorrow I'm fine with including it in 4.8. > > > > I have given the code a quick loo

Re: Review Request: Make mouse cursor size configurable

> On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote: > > kcontrol/input/xcursor/cursortheme.cpp, line 119 > > > > > > Scaling a pixmap is more expensive than scaling an image. Internally it > > involves converting

Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)

On Wednesday, November 9, 2011 01:22:54 Dawit A wrote: > That is fine for the kdelibs portion, but what do you suggest be done > with the kde-baseapps portion of the patch ? Wait until 4.8 gets > branched ? creating a frameworks branch in kde-baseapps may be a solution; we'll likely want to branc

Re: Review Request: Make mouse cursor size configurable

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review8036 --- Ship it! Sorry for not finding the time to follow up on this un