Request: remove libkactivites from kdelibs (in experimental/)

2011-11-04 Thread Aaron J. Seigo
hi .. we currently have libkactivities in kdelibs/experimental. due to upcoming changs and frameworks 5 development, it has been moved into its own git repository: kactivities. i would like to request approval to remove it from kdelibs/experimental and make the kactivities repository a depende

Re: Review Request: Change KIO::DeleteJob to use KIO::http_delete for HTTP protocol

2011-11-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103038/#review7946 --- This review has been submitted with commit 2423a03608722f16dffa

Re: Review Request: Change KIO::DeleteJob to use KIO::http_delete for HTTP protocol

2011-11-04 Thread Dawit Alemayehu
> On Nov. 4, 2011, 11:20 a.m., David Faure wrote: > > kio/kio/deletejob.cpp, line 100 > > > > > > Could be file-static instead of class-static, so that it doesn't > > generate a symbol at all. True, will do that.

Re: Review Request: Change KIO::DeleteJob to use KIO::http_delete for HTTP protocol

2011-11-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103038/#review7939 --- Ship it! kio/kio/deletejob.cpp

Re: Review Request: [KTextEdit] Handle actions depending on modes/flags

2011-11-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102919/#review7937 --- Looks good. About whether we need to consume the disabled shortc

Re: Review Request: Fix stray ampersand in KUrlNavigatorProtocolCombo

2011-11-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103040/#review7933 --- This review has been submitted with commit 3a623c36bc3015a82011