Re: Review Request: Fix stray ampersand in KUrlNavigatorProtocolCombo

2011-11-03 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103040/#review7928 --- Ship it! Thanks Christoph, looks perfect! - Peter Penz On No

Re: Review Request: [KTextEdit] Handle actions depending on modes/flags

2011-11-03 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102919/ --- (Updated Nov. 3, 2011, 9:19 p.m.) Review request for kdelibs. Changes --

Re: Review Request: Update tab labels list after moving when using QTabWidget::setMovable()

2011-11-03 Thread Christoph Feck
> On Sept. 22, 2011, 5:16 p.m., Frank Reininghaus wrote: > > Looks good to me. I've attached a unit test to the bug report - would be > > nice if you could include it in your commit :-) Thanks, unless there are objections, I will commit this (and your unit test) next week. - Christoph

Re: Bug in kcfg, KColorCombo not handled correct

2011-11-03 Thread Christoph Feck
On Thursday 03 November 2011 13:14:31 Dag Andersen wrote: > Torsdag 03 november 2011 10:32:43 skrev Christoph Feck: > > On Thursday 03 November 2011 09:47:45 Dag Andersen wrote: > > > AFAICS this commit: > > > 8e95387f0d96ceb8439339643d1b9286a9204662 > > > broke kcfg handling of KColorCombo. > > >

Review Request: Fix stray ampersand in KUrlNavigatorProtocolCombo

2011-11-03 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103040/ --- Review request for Dolphin and kdelibs. Description --- - fix sizeHin

Re: Bug in kcfg, KColorCombo not handled correct

2011-11-03 Thread Dag Andersen
Torsdag 03 november 2011 10:32:43 skrev Christoph Feck: > On Thursday 03 November 2011 09:47:45 Dag Andersen wrote: > > AFAICS this commit: > > 8e95387f0d96ceb8439339643d1b9286a9204662 > > broke kcfg handling of KColorCombo. > > > > The attached patch fixes it for me. > > Hm, KColorCombo has a us

Re: Bug in kcfg, KColorCombo not handled correct

2011-11-03 Thread Dag Andersen
Torsdag 03 november 2011 10:32:43 skrev Christoph Feck: > On Thursday 03 November 2011 09:47:45 Dag Andersen wrote: > > AFAICS this commit: > > 8e95387f0d96ceb8439339643d1b9286a9204662 > > broke kcfg handling of KColorCombo. > > > > The attached patch fixes it for me. > > Hm, KColorCombo has a us

Review Request: Change KIO::DeleteJob to use KIO::http_delete for HTTP protocol

2011-11-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103038/ --- Review request for kdelibs and David Faure. Description --- The attac

Re: Bug in kcfg, KColorCombo not handled correct

2011-11-03 Thread Christoph Feck
On Thursday 03 November 2011 09:47:45 Dag Andersen wrote: > AFAICS this commit: > 8e95387f0d96ceb8439339643d1b9286a9204662 > broke kcfg handling of KColorCombo. > > The attached patch fixes it for me. Hm, KColorCombo has a user property, so it should work. The patch is not good, because no other

Re: Bug in kcfg, KColorCombo not handled correct

2011-11-03 Thread Michael Leupold
Hi Dag, Am 03.11.2011 09:47, schrieb Dag Andersen: AFAICS this commit: 8e95387f0d96ceb8439339643d1b9286a9204662 broke kcfg handling of KColorCombo. The attached patch fixes it for me. Thanks! Could someone please check if that fixes the handling of KColorCombo? I currently neither have a wor

Bug in kcfg, KColorCombo not handled correct

2011-11-03 Thread Dag Andersen
AFAICS this commit: 8e95387f0d96ceb8439339643d1b9286a9204662 broke kcfg handling of KColorCombo. The attached patch fixes it for me. -- Mvh. Dag Andersen diff --git a/kdeui/dialogs/kconfigdialogmanager.cpp b/kdeui/dialogs/kconfigdialogmanager.cpp index 0890c0b..ac56e59 100644 --- a/kdeui/dialogs

Re: FW: Kleopatra Locking Clipboard

2011-11-03 Thread Andre Heinecke
Hi, On Wednesday 02 November 2011 11:43:38 Kevin Krammer wrote: > Hi Andrew, > > there haven't been any responses since your first email. > Since you wrote "Kleopatra.exe" I would suggest you send to the kde-windows > list instead. The gpg4win-devel mailing list would be the best place to discuss