Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
> On Nov. 1, 2011, 9:36 p.m., Marco Martin wrote: > > Oh yeah :) Thanx! - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7844 -

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7850 --- This review has been submitted with commit 5729cc5ababdb4d7a54b

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7844 --- Ship it! - Marco Martin On Nov. 1, 2011, 9:20 p.m., Mark Gais

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/ --- (Updated Nov. 1, 2011, 9:20 p.m.) Review request for KDE Runtime, Plasma a

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7842 --- well done, getting near :) only last thing: could you make it us

Re: GammaRay - Introspection/Debugging Tool for Qt Applications

2011-11-01 Thread Peter Kümmel
On 01.11.2011 08:58, Volker Krause wrote: I've also tried to attach to console apps without success. Then I realized that you use the hijacked process to show the GammaRay mainwindow which is not possible in a QCoreApplication executable. So I wonder how difficult it would be to run GammaRay in

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/ --- (Updated Nov. 1, 2011, 8:52 p.m.) Review request for KDE Runtime, Plasma a

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
> On Nov. 1, 2011, 7:20 p.m., Marco Martin wrote: > > plasma/declarativeimports/plasmacomponents/qml/Button.qml, line 60 > > > > > > width of the buttons should always be the same unless explicitly > > resized by th

Re: Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7830 --- i like the effect of having an animated press effect. this comes

Review Request: Improved Button.qml in PlasmaComponents

2011-11-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/ --- Review request for KDE Runtime, Plasma and Marco Martin. Description -

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7826 --- to me it would be fine (even tough there are starting to be quit

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/ --- (Updated Nov. 1, 2011, 6:43 p.m.) Review request for KDE Runtime and Plasm

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Mark Gaiser
> On Nov. 1, 2011, 3:34 p.m., Marco Martin wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.h, line 31 > > > > > > since here only write makes sense, you need a method I'm not getting you. What do yo

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Mark Gaiser
> On Nov. 1, 2011, 3:09 p.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.h, line 31 > > > > > > could these be automatically detected? e.g. if it can't be resolved > > into a pat

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Marco Martin
> On Nov. 1, 2011, 3:09 p.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.h, line 31 > > > > > > could these be automatically detected? e.g. if it can't be resolved > > into a pat

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7806 --- plasma/declarativeimports/qtextracomponents/qiconitem.h

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Mark Gaiser
> On Nov. 1, 2011, 3:09 p.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.h, line 31 > > > > > > could these be automatically detected? e.g. if it can't be resolved > > into a pat

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-01 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7802 --- plasma/declarativeimports/qtextracomponents/qiconitem.h

Re: GammaRay - Introspection/Debugging Tool for Qt Applications

2011-11-01 Thread Volker Krause
On Monday 31 October 2011 22:36:08 Peter Kümmel wrote: > On 30.10.2011 13:21, Volker Krause wrote: > > Hi! > > > > During the Qt Dev Days in Munich last week we (KDAB) released a new Free > > Software introspection/debugging tool for Qt applications, called > > GammaRay: > > https://github.com/KDAB