Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Rex Dieter
Milian Wolff wrote: > Could someone maybe explain a few points on this issue for me? > > 1) When does it manifest? Apparently when using QUrl("...") directly, if > I'm not mistaken. But what if we use KUrl? KUrl uses QUrl behind the scenes for several cases. -- rex

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Milian Wolff
On Saturday 29 October 2011 01:05:18 Thiago Macieira wrote: > On Friday, 28 de October de 2011 17:43:32 Kevin Kofler wrote: > > Thiago Macieira wrote: > > > Which is quite wrong already. From Qt 4.8 on, this returns empty in all > > > cases, showing that you parsed the URL wrongly. It should be eas

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread David Jarvie
On Saturday 29 October 2011 00:05:18 Thiago Macieira wrote: > On Friday, 28 de October de 2011 17:43:32 Kevin Kofler wrote: > > Thiago Macieira wrote: > > > Which is quite wrong already. From Qt 4.8 on, this returns empty in all > > > cases, showing that you parsed the URL wrongly. It should be eas

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Thiago Macieira
On Friday, 28 de October de 2011 17:43:32 Kevin Kofler wrote: > Thiago Macieira wrote: > > Which is quite wrong already. From Qt 4.8 on, this returns empty in all > > cases, showing that you parsed the URL wrongly. It should be easier to > > spot where you made the mistake because you don't have to

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-28 Thread Greg T
> On Oct. 5, 2011, 11:30 a.m., David Faure wrote: > > Why the setMaxLength?? What if one wants to type in a long URL? > > > > Also, I can't reproduce the bug here (kde-4.7), but maybe only because the > > big icon button makes the dialog quite large? > > Greg T wrote: > indeed, the setmaxL

Re: detection if applet is running

2011-10-28 Thread Andriy Rysin
On 10/28/2011 12:41 PM, Aaron J. Seigo wrote: On Friday, October 28, 2011 11:26:05 Andriy Rysin wrote: We already have that dbus API in keyboard kded daemon could the kded daemon be checked to see if keyboard layouts are available, and if so, show that button in the unlock dialog? does it reall

Re: detection if applet is running

2011-10-28 Thread Aaron J. Seigo
On Friday, October 28, 2011 11:26:05 Andriy Rysin wrote: > We already have that dbus API in keyboard kded daemon could the kded daemon be checked to see if keyboard layouts are available, and if so, show that button in the unlock dialog? does it really need to rely on whether or not there is a s

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Christoph Feck
On Friday 28 October 2011 17:30:44 Kevin Kofler wrote: > Albert Astals Cid wrote: > > Personally i find it another joke in the history of Qt, saying > > you maintain API and ABI (that you do) but then making functions > > behave totally different from one version to another is just > > plain useles

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Kevin Kofler
Thiago Macieira wrote: > Which is quite wrong already. From Qt 4.8 on, this returns empty in all > cases, showing that you parsed the URL wrongly. It should be easier to > spot where you made the mistake because you don't have to use > specially-crafted filenames. Such a change might make sense fo

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Kevin Kofler
Thiago Macieira wrote: > I'm also calling right now KUrl's fromPathOrUrl a fatally flawed design. It is what real-world users need in a network-transparent application! They will want to enter a file name in most cases, but if they need to open or save a file from/to the network, they have to en

Re: detection if applet is running

2011-10-28 Thread Andriy Rysin
On 10/28/2011 02:38 AM, Aaron J. Seigo wrote: On Thursday, October 27, 2011 23:35:52 Andriy Rysin wrote: 2) make keyboard layout applet exposes some dbus to make it detectable when running (feels a bit too "heavy") that would be a preferred way ... note, however, that one can have multiple inst

Re: Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Kevin Kofler
Albert Astals Cid wrote: > Personally i find it another joke in the history of Qt, saying you > maintain API and ABI (that you do) but then making functions behave > totally different from one version to another is just plain useless. +1 You just CANNOT change the behavior of an existing function

Re: detection if applet is running

2011-10-28 Thread Andriy Rysin
On 10/28/2011 09:20 AM, Ruurd Pels wrote: On Thursday 27 October 2011 23:35:52 Andriy Rysin wrote: 2) make keyboard layout applet exposes some dbus to make it detectable when running (feels a bit too "heavy") Yes. Better. Why does it feel heavy? I'd venture the thought that doing so could expo

Re: Review Request: Add direct support for remote URLs to previewjob

2011-10-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102929/#review7723 --- Ship it! Looks good, the code is much simpler now. Just two sma

Re: detection if applet is running

2011-10-28 Thread Ruurd Pels
On Thursday 27 October 2011 23:35:52 Andriy Rysin wrote: > I did a quick research and I see two ways to solve this in > keyboard_layout_widget (embedded component used in lockdlg): > 1) link plasma libs and do something like (in pseudo-code) > foreach(containment, new Corona()->containments()) { >

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Thiago Macieira
On Friday, 28 de October de 2011 14:22:02 Albert Astals Cid wrote: > Right, it was wrong if it had to accept user input but for internal > hardcoded paths, it worked and now it does not. Right. If it is user input, we provide QUrl::fromuserInput, which implements some heuristics. But the case b

Re: Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Albert Astals Cid
A Divendres, 28 d'octubre de 2011, Thiago Macieira vàreu escriure: > On Friday, 28 de October de 2011 10:41:36 Sebastian Trüg wrote: > > > So, to be honest, the bug already existed in your code if you're > > > finding these problems now. I just made it blatantly clear, and > > > it's been there for

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-28 Thread Christoph Feck
> On Oct. 5, 2011, 11:30 a.m., David Faure wrote: > > Why the setMaxLength?? What if one wants to type in a long URL? > > > > Also, I can't reproduce the bug here (kde-4.7), but maybe only because the > > big icon button makes the dialog quite large? > > Greg T wrote: > indeed, the setmaxL

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Thiago Macieira
On Friday, 28 de October de 2011 10:41:36 Sebastian Trüg wrote: > > So, to be honest, the bug already existed in your code if you're finding > > these problems now. I just made it blatantly clear, and it's been there > > for a year for people to see. > > > > > > > > I'm also calling right now KUrl

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread Sebastian Trüg
On 10/27/2011 11:35 PM, Thiago Macieira wrote: > On Thursday, 27 de October de 2011 23:17:49 Milian Wolff wrote: >> On Thursday 27 October 2011 21:11:11 Thiago Macieira wrote: >>> On Thursday, 27 de October de 2011 13:32:51 Rex Dieter wrote: See also, http://bugs.kde.org/285028 ( and