Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-23 Thread Oswald Buddenhagen
> On Oct. 23, 2011, 4:22 p.m., Ralf Jung wrote: > > Any news? Can I ship this (simplified) version of the original request? in qt review terms, you get a +1 from me. this code is pretty much unmaintained, so it's unlikely that you'll get more feedback than that. - Oswald ---

Re: Review Request: Support passing an argument to the Locale KCM tab to specify which tab to activate at load.

2011-10-23 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102947/#review7560 --- Hi Dave, as maintainer of the Locale KCM I'm happy for this to g

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-23 Thread Alexander Neundorf
On Sunday 23 October 2011, Ralf Jung wrote: > Hi, > > > That's the problem. > > CMP0017 should be set to NEW, and it is set to NEW in > > FindKDE4Internal.cmake. So we need to find out why it is not set in this > > case. > > Thanks for this hint! After some more debugging, I came up with attached

Re: Review Request: Support passing an argument to the Locale KCM tab to specify which tab to activate at load.

2011-10-23 Thread Andriy Rysin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102947/#review7559 --- kcm_keyboard uses --tab=... may be we should make it consistent?

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-23 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102799/#review7558 --- Any news? Can I ship this (simplified) version of the original r

Re: Review Request: [PATCH] Change HTML thumbnail generator to kdewebkit

2011-10-23 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101365/ --- (Updated Oct. 23, 2011, 4:19 p.m.) Review request for KDE Runtime. Chang

Re: Review Request: Cleanup the use of HTTPProtocol::httpClose

2011-10-23 Thread Dawit Alemayehu
> On Oct. 12, 2011, 10:51 p.m., Andreas Hartmetz wrote: > > This changeset changes some important parts without obvious (to me) gain. > > Before I spend an hour or two thinking through all the cases, which may or > > may not catch potential regressions, I'd like to know what this does for us. >

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-23 Thread Ralf Jung
Hi, > That's the problem. > CMP0017 should be set to NEW, and it is set to NEW in > FindKDE4Internal.cmake. So we need to find out why it is not set in this > case. Thanks for this hint! After some more debugging, I came up with attached patch against kde-workspace which also fixes the warning he

Re: Review Request: DrKonqi parses bactraces to find duplicates

2011-10-23 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102921/ --- (Updated Oct. 23, 2011, 1:51 p.m.) Review request for KDE Runtime and Geor

Review Request: Support passing an argument to the Locale KCM tab to specify which tab to activate at load.

2011-10-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102947/ --- Review request for KDE Runtime. Description --- Part 1/2 of fixing ht