Re: [proposal] KSecretsService components moving from playground

2011-10-16 Thread Valentin Rusu
On 10/16/2011 03:30 PM, Will Stephenson wrote: On Wednesday 12 October 2011 00:24:00 Valentin Rusu wrote: Any thoughts? This all sounds good. A couple of questions: 1) Are the KWallet API changes additions, or will some parts of the kwallet api be deprecated? If so, when do you plan to add th

Re: Review Request: Fix audioCD properties with solid udisks backend

2011-10-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102892/#review7399 --- This review has been submitted with commit 3e9f380214a1619ef32a

Re: Review Request: Fix audioCD properties with solid udisks backend

2011-10-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102892/#review7398 --- This review has been submitted with commit 4e8fef3921b95bb409bd

Re: Review Request: Fix audioCD properties with solid udisks backend

2011-10-16 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102892/#review7397 --- Ship it! Ship It! - Lukáš Tinkl On Oct. 16, 2011, 10:39 a.m.

Re: Review Request: Fix audioCD properties with solid udisks backend

2011-10-16 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102892/#review7396 --- Looks good, I am going to commit it, thanks for the patch - Luk

Review Request: Fix audioCD properties with solid udisks backend

2011-10-16 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102892/ --- Review request for kdelibs, Kevin Ottens and Lukáš Tinkl. Description

Re: [proposal] KSecretsService components moving from playground

2011-10-16 Thread Will Stephenson
On Wednesday 12 October 2011 00:24:00 Valentin Rusu wrote: > As KSecretsService becomes quite usable, I think it's time to prepare to > get it integrated into the next release. > http://techbase.kde.org/Schedules/KDE4/4.8_Release_Schedule > > The code is not yet fully mature, all the components ar

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Alexander Neundorf
On Sunday 16 October 2011, Ralf Jung wrote: > Hi, > > > > The problem is that this results in a warning about CMake files being > > > overridden when running cmake for kde-workspace. > > > > Can you post the exact warning message here, please ? > > Sure, here it is: > CMake Warning (dev) at > /u

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Ralf Jung
Hi, > > The problem is that this results in a warning about CMake files being > > overridden when running cmake for kde-workspace. > > Can you post the exact warning message here, please ? Sure, here it is: CMake Warning (dev) at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Alexander Neundorf
On Sunday 16 October 2011, Ralf Jung wrote: > > On Oct. 16, 2011, 9:43 a.m., Alexander Neundorf wrote: > > > Please don't commit this. > > > This is on purpose. > > > We install a file which includes CMakeParseArguments.cmake, so we > > > *must* also install CMakeParseArguments.cmake itself, otherw

Re: Review Request: new kded daemon to check .thumbnail directory space usage

2011-10-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/#review7379 --- directoryusagenotifier/cleanupdirectory.h

Review Request: KActivities requires Soprano 2.7 to compile

2011-10-16 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102893/ --- Review request for kdelibs. Description --- I tried compiling KActivi

Re: Review Request: Konqueror: Ask for session restore ONLY on plain startup (not for every window)

2011-10-16 Thread David Faure
> On Aug. 29, 2011, 4:09 p.m., David Faure wrote: > > konqueror/src/konqmain.cpp, line 125 > > > > > > So it won't ask when logging into a new KDE session? Seems to me that > > this could be kept here, no? It's not

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Ralf Jung
> On Oct. 16, 2011, 9:43 a.m., Alexander Neundorf wrote: > > Please don't commit this. > > This is on purpose. > > We install a file which includes CMakeParseArguments.cmake, so we *must* > > also install CMakeParseArguments.cmake itself, otherwise we may get in > > trouble if the version in cm

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102869/#review7375 --- Please don't commit this. This is on purpose. We install a file

Re: [Kde-games-devel] Module layout proposal: Split kdegames-data from kdegames

2011-10-16 Thread Ian Wadham
On 15/10/2011, at 5:29 AM, Stefan Majewsky wrote: > EXECUTIVE SUMMARY > > I propose to move the data files from the kdegames module into a new > kdegames-data module to > 1. facilitate the move of the remaining source code to Git (while a > method of storing binary data files in Git eff

Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102869/ --- Review request for kdelibs. Description --- Only install CMakeParseAr