Re: The future of Power Management - together with Activities

2011-10-06 Thread Oswald Buddenhagen
On Sat, Oct 01, 2011 at 08:33:06PM +0300, Andras Mantia wrote: > What I can say that I use the selection combo between the different > power management schemes from time to time, as I can do the same thing > (e.g developing so not anything like now I develop and then switch to > mail reading/wa

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Greg T
> On Oct. 5, 2011, 8:53 p.m., Christoph Feck wrote: > > If you think 40 looks good, please commit :) Thanks. yeah it's fine. uhm...I don't have commit access. I'm a nobody ;). Can you do it for me? - Greg --- This is an automatically g

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Greg T
> On Oct. 5, 2011, 11:30 a.m., David Faure wrote: > > Why the setMaxLength?? What if one wants to type in a long URL? > > > > Also, I can't reproduce the bug here (kde-4.7), but maybe only because the > > big icon button makes the dialog quite large? indeed, the setmaxLength was stupid it's q

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Greg T
> On Oct. 5, 2011, 12:16 p.m., Christoph Feck wrote: > > Setting the width to "30+needed" looks wrong, too. This means depending on > > the current URL, it could grow very big, or be too small. > > > > What I do in those cases is decide about a "good average" text length (for > > bookmarked Pl

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/ --- (Updated Oct. 5, 2011, 6:22 p.m.) Review request for Dolphin and kdelibs.

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Christoph Feck
> On Oct. 5, 2011, 11:30 a.m., David Faure wrote: > > Why the setMaxLength?? What if one wants to type in a long URL? > > > > Also, I can't reproduce the bug here (kde-4.7), but maybe only because the > > big icon button makes the dialog quite large? > > Greg T wrote: > indeed, the setmaxL

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread Peter Penz
> On Oct. 5, 2011, 11:30 a.m., David Faure wrote: > > Why the setMaxLength?? What if one wants to type in a long URL? > > > > Also, I can't reproduce the bug here (kde-4.7), but maybe only because the > > big icon button makes the dialog quite large? > > Greg T wrote: > indeed, the setmaxL

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-06 Thread David Faure
> On Oct. 5, 2011, 11:30 a.m., David Faure wrote: > > Why the setMaxLength?? What if one wants to type in a long URL? > > > > Also, I can't reproduce the bug here (kde-4.7), but maybe only because the > > big icon button makes the dialog quite large? > > Greg T wrote: > indeed, the setmaxL