Re: Review Request: nepomuk/services/storage/datamanagementmodel.h fix to allow compiling on apple's gcc 4.2.1

2011-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102753/#review7137 --- This review has been submitted with commit b8f67d82f4924eb6b2d2

Re: Review Request: nepomuk/services/storage/datamanagementmodel.h fix to allow compiling on apple's gcc 4.2.1

2011-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102753/#review7135 --- This review has been submitted with commit 7ff19a5e36189f8af640

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/#review7130 --- Ship it! If you think 40 looks good, please commit :) Thanks.

Re: Review Request: Make mouse cursor size configurable

2011-10-05 Thread Christoph Feck
> On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote: > > What I dislike is the position of the size combo box. Either it should be > > below the list, or, when above the list, share the space with the preview. > > > > Regarding the "use DPI depended size", what we could do if we use a slider,

Re: Review Request: Make mouse cursor size configurable

2011-10-05 Thread Lukas Sommer
> On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote: > > What I dislike is the position of the size combo box. Either it should be > > below the list, or, when above the list, share the space with the preview. > > > > Regarding the "use DPI depended size", what we could do if we use a slider,

Re: Review Request: nepomuk/services/storage/datamanagementmodel.h fix to allow compiling on apple's gcc 4.2.1

2011-10-05 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102753/#review7120 --- Ship it! I am fine with this. But maybe it would be cleaner to

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/#review7119 --- Setting the width to "30+needed" looks wrong, too. This means de

Re: Review Request: Put an end to plugin statusbar icon leaks

2011-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101653/#review7118 --- This review has been submitted with commit 848a9f02135c06ec5743

Re: More convenient text completion in KDE UIs

2011-10-05 Thread David Faure
On Tuesday 04 October 2011 22:25:11 Jaroslaw Staniek wrote: > also our kurl boxes with completion have no full > text search so if I have file my_girl.txt I cannot just type 'girl' This is actually supported, just not automatically. Try F7 in konqueror's location bar (e.g. after typing "search", t

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/#review7117 --- Why the setMaxLength?? What if one wants to type in a long URL?

Re: Review Request: modification to get all possible informations at debuging

2011-10-05 Thread David Faure
> On Oct. 3, 2011, 5:24 p.m., David Faure wrote: > > Please don't commit this. > > > > Use debugfull if you want no optimizations (e.g. for step-by-step in gdb). > > Guy Maurel wrote: > thanks, I'll try this. > > Guy Maurel wrote: > I am missing the option -O0 . man g++ says: >

Re: [Kde-pim] Who relies on Soprano::Model::statement[s]Added|Removed signals?

2011-10-05 Thread Vishesh Handa
Well now we know one of the reasons for Nepomuk hogging a lot of CPU. Those signals were horribly inefficient. On Wed, Oct 5, 2011 at 1:27 PM, laurent Montel wrote: > There is a HOWTO to explain how to convert it ? > > Nope. I could write one. I suppose. It seems fairly intuitive to me, but the

Re: Review Request: Put an end to plugin statusbar icon leaks

2011-10-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101653/#review7100 --- Ship it! OK. kparts/statusbarextension.cpp

Re: Review Request: W7 Tab thumbnails in dolphin.

2011-10-05 Thread Andrius da Costa Ribas
> On Oct. 3, 2011, 1:15 p.m., David Faure wrote: > > Couldn't this be done higher in the stack, e.g. in KTabWidget or in Qt? > > Kevin Kofler wrote: > Indeed, I think there should be some interface for this stuff in kdelibs, > so that 1. applications don't have to add such platform-specific

Re: Review Request: W7 Tab thumbnails in dolphin.

2011-10-05 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102758/ --- (Updated Oct. 5, 2011, 12:52 a.m.) Review request for KDE Base Apps, KDE A

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-05 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/ --- (Updated Oct. 4, 2011, 8:02 p.m.) Review request for Dolphin and kdelibs.

Re: Review Request: kfileplaceeditdialog lineedit too small

2011-10-05 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/ --- (Updated Oct. 4, 2011, 7:28 p.m.) Review request for kdelibs. Summary (u

Re: Review Request: kfileplaceeditdialog too small

2011-10-05 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102751/ --- (Updated Oct. 4, 2011, 7:27 p.m.) Review request for kdelibs. Changes --

Re: [Kde-pim] Who relies on Soprano::Model::statement[s]Added|Removed signals?

2011-10-05 Thread laurent Montel
Le Wednesday 5 October 2011 08:55:08 Volker Krause a écrit : > On Friday 30 September 2011 13:36:22 Sebastian Trüg wrote: > > Hi lists, > > > > with frameworks in the building and Nepomuk probably going that > > direction already for 4.8 I would like to clean up a bit. One of these > > cleanup tas

Re: Review Request: Put an end to plugin statusbar icon leaks

2011-10-05 Thread Thomas Friedrichsmeier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101653/ --- (Updated Oct. 5, 2011, 7:28 a.m.) Review request for kdelibs. Changes --

Re: Who relies on Soprano::Model::statement[s]Added|Removed signals?

2011-10-05 Thread Boudewijn Rempt
On Wednesday 05 October 2011 Oct, Volker Krause wrote: > On Friday 30 September 2011 13:36:22 Sebastian Trüg wrote: > > Hi lists, > > > > with frameworks in the building and Nepomuk probably going that > > direction already for 4.8 I would like to clean up a bit. One of these > > cleanup tasks tar

Re: Who relies on Soprano::Model::statement[s]Added|Removed signals?

2011-10-05 Thread Volker Krause
On Friday 30 September 2011 13:36:22 Sebastian Trüg wrote: > Hi lists, > > with frameworks in the building and Nepomuk probably going that > direction already for 4.8 I would like to clean up a bit. One of these > cleanup tasks targets the Soprano::Model statement signals. So far these > were the o