Re: Review Request: Proxy overhaul Part 5: Add support for trying multiple proxies to KIO HTTP

2011-09-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102696/ --- (Updated Sept. 25, 2011, 8:37 p.m.) Review request for kdelibs. Descript

Re: Review Request: Proxy overhaul Part 5: Add support for trying multiple proxies to KIO HTTP

2011-09-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102696/ --- (Updated Sept. 25, 2011, 8:35 p.m.) Review request for kdelibs. Changes

Re: Review Request: Proxy overhaul Part 5: Add support for trying multiple proxies to KIO HTTP

2011-09-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102696/ --- (Updated Sept. 25, 2011, 4:59 p.m.) Review request for kdelibs. Changes

Re: Review Request: Proxy overhaul Part 5: Add support for trying multiple proxies to KIO HTTP

2011-09-25 Thread Dawit Alemayehu
> On Sept. 25, 2011, 2:55 p.m., Andreas Hartmetz wrote: > > Again, I'd like to know which testing you did. See my response to the same question you asked in https://git.reviewboard.kde.org/r/102691. > On Sept. 25, 2011, 2:55 p.m., Andreas Hartmetz wrote: > > kioslave/http/http.cpp, line 2166

Re: Review Request: Proxy overhaul Part 5: Add support for trying multiple proxies to KIO HTTP

2011-09-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102696/ --- (Updated Sept. 25, 2011, 4:47 p.m.) Review request for kdelibs. Changes

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-25 Thread Dawit Alemayehu
> On Sept. 25, 2011, 2:20 p.m., Andreas Hartmetz wrote: > > I'd actually be interested to hear which testing you did. > > > > The "ResolveHostNamesBeforeProxyCheck" option seems strange. In which > > situations is this supposed to be set / not set? The "ResolveHostNamesBeforeProxyCheck" option

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102691/ --- (Updated Sept. 25, 2011, 4:15 p.m.) Review request for kdelibs. Changes

Re: Review Request: Proxy overhaul Part 5: Add support for trying multiple proxies to KIO HTTP

2011-09-25 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102696/#review6797 --- Again, I'd like to know which testing you did. kio/kio/tcpslav

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

2011-09-25 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102691/#review6796 --- I'd actually be interested to hear which testing you did. The "

Re: KNotify-considerations for frameworks

2011-09-25 Thread Olivier Goffart
On Friday 23 September 2011 14:24:54 Aaron J. Seigo wrote: [...] > now .. here's what i got from your email, please correct me if i'm wrong: > > the big question is this: should we have a central daemon, or not? That is not how i understood Sune's email: I understood that he wanted to extract th

Re: Review Request: KDIalog::screenRect: workaround for faulty QDesktopWidget::geometry

2011-09-25 Thread Thomas Gahr
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102671/ --- (Updated Sept. 24, 2011, 1:58 p.m.) Review request for kdelibs. Changes

Re: Review Request: KDIalog::screenRect: workaround for faulty QDesktopWidget::geometry

2011-09-25 Thread Thomas Gahr
> On Sept. 24, 2011, 12:57 p.m., Olivier Goffart wrote: > > kdeui/dialogs/kdialog.cpp, line 551 > > > > > > Are you sure it should not be availableGeometry(widget) so it is > > consistant with the other case? (or