Re: frameworks branch now requires CMake 2.8.6 RC 2

2011-09-23 Thread Alexander Neundorf
On Friday, September 23, 2011 07:05:51 PM Stephen Kelly wrote: > Alexander Neundorf wrote: > >> That leaves enable_final and setting LINK_INTERFACE_LIBRARIES to empty. > >> I'm > > > > Setting LINK_INTERFACE_LIBRARIES to empty is still needed and wanted. > > By default, all libraries a target is l

Re: Review Request: KDIalog::screenRect: workaround for faulty QDesktopWidget::geometry

2011-09-23 Thread Thomas Gahr
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102671/ --- (Updated Sept. 23, 2011, 12:23 p.m.) Review request for kdelibs. Changes

Re: Review Request: KDIalog::screenRect: workaround for faulty QDesktopWidget::geometry

2011-09-23 Thread Thomas Gahr
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102671/#review6765 --- This has _basically_ been approved in http://lists.kde.org/?l=k

Re: frameworks branch now requires CMake 2.8.6 RC 2

2011-09-23 Thread Stephen Kelly
Alexander Neundorf wrote: >> >> That leaves enable_final and setting LINK_INTERFACE_LIBRARIES to empty. >> I'm > > Setting LINK_INTERFACE_LIBRARIES to empty is still needed and wanted. > By default, all libraries a target is linked agaonst are in the > LINK_INTERFACE, which leads to unnecessary d

Re: KNotify-considerations for frameworks

2011-09-23 Thread Lubos Lunak
On Friday 23 of September 2011, George Kiagiadakis wrote: > I agree with parts of this plan, but not all of them. I think we need > to study more the use cases. Let's consider a few examples. ... > 2) Your music player informs you of the next song that is going to be > played. You most likely want

Re: KNotify-considerations for frameworks

2011-09-23 Thread Aaron J. Seigo
On Thursday, September 22, 2011 22:17:09 Sune Vuorela wrote: > I'm considering doing some work on the knotify-stuff for the kde > frameworks. cool :) > Currently, it is a quite complex framework that is hard to debug for the > users of knotify (the application developers). It seems a bit > overen

Re: KNotify-considerations for frameworks

2011-09-23 Thread George Kiagiadakis
On Fri, Sep 23, 2011 at 2:01 AM, Sune Vuorela wrote: > On 2011-09-22, Sune Vuorela wrote: >> Currently, it is a quite complex framework that is hard to debug for the >> users >> of knotify (the application developers). It seems a bit overengineered, >> at least compared to how many of the featur

Re: Review Request: Make mouse cursor size configurable

2011-09-23 Thread Lukas Sommer
> On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote: > > What I dislike is the position of the size combo box. Either it should be > > below the list, or, when above the list, share the space with the preview. > > > > Regarding the "use DPI depended size", what we could do if we use a slider,

Re: Review Request: systemsettings/fonts: DPI setting is X11-only

2011-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102527/#review6758 --- This review has been submitted with commit a44fe26f3c67cd03a629

Re: Re: KNotify-considerations for frameworks

2011-09-23 Thread Stephen Kelly
Albert Astals Cid wrote: > A Dijous, 22 de setembre de 2011, Sune Vuorela vàreu escriure: >> On 2011-09-22, Albert Astals Cid wrote: >> > This means that as a user if the developer decides to use a "Popup" I >> > can no longer configure the application to do nothing? Or to play a >> > sound? >> N

Re: Review Request: Show removable media in Dolphin's "Copy To" and "Move To" context menus

2011-09-23 Thread Rajeesh K Nambiar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102657/ --- (Updated Sept. 22, 2011, 7:30 p.m.) Review request for Dolphin and KDE Bas