Re: Review Request: Konqueror: Ask for session restore ONLY on plain startup (not for every window)

2011-09-22 Thread Marcel Partap
> On Aug. 29, 2011, 4:09 p.m., David Faure wrote: > > konqueror/src/konqmain.cpp, line 125 > > > > > > So it won't ask when logging into a new KDE session? Seems to me that > > this could be kept here, no? It's not

Re: KNotify-considerations for frameworks

2011-09-22 Thread Eike Hein
On 9/23/2011 2:36 AM, Albert Astals Cid wrote: I disagree, the fact that *all* KDE applications open the same dialog when you go to settings->configure notifications is a big plus. It adds consistency to the user experience and even if the dialog could be designed better (it works for me but thin

Re: KNotify-considerations for frameworks

2011-09-22 Thread Harald Sitter
On Fri, Sep 23, 2011 at 1:01 AM, Sune Vuorela wrote: > Consider doing some classes for Phonon to do audio notifications for > those who needs that or alternatively get a cross desktop audio > notification dbus spec, just like the galago spec and get the workspaces > to implement it. (Issue here mi

Re: Re: KNotify-considerations for frameworks

2011-09-22 Thread Albert Astals Cid
A Dijous, 22 de setembre de 2011, Sune Vuorela vàreu escriure: > On 2011-09-22, Albert Astals Cid wrote: > > This means that as a user if the developer decides to use a "Popup" I > > can no longer configure the application to do nothing? Or to play a > > sound? > No. It just means that the respons

Re: KNotify-considerations for frameworks

2011-09-22 Thread Sune Vuorela
On 2011-09-22, Albert Astals Cid wrote: > This means that as a user if the developer decides to use a "Popup" I can no > longer configure the application to do nothing? Or to play a sound? No. It just means that the responsibility is handed over to the application developer if they want to offer

Re: KNotify-considerations for frameworks

2011-09-22 Thread Sune Vuorela
On 2011-09-22, Sune Vuorela wrote: ...and of course, bits of my drafts fell out when doing the last reorder of things. > Hi > > I'm considering doing some work on the knotify-stuff for the kde > frameworks. > This involves the KNotification class and the KNotify daemon and related > classes. > > I

Re: KNotify-considerations for frameworks

2011-09-22 Thread Albert Astals Cid
A Dijous, 22 de setembre de 2011, Sune Vuorela vàreu escriure: > Hi > > I'm considering doing some work on the knotify-stuff for the kde > frameworks. > This involves the KNotification class and the KNotify daemon and related > classes. > > I started hacking a bit on it in Randa, but have ended u

KNotify-considerations for frameworks

2011-09-22 Thread Sune Vuorela
Hi I'm considering doing some work on the knotify-stuff for the kde frameworks. This involves the KNotification class and the KNotify daemon and related classes. I started hacking a bit on it in Randa, but have ended up scratchig my work and starting over. http://pusling.com/blog/?p=200 Current

re: kdelibs/master: zap it?

2011-09-22 Thread Rick Stockton
In reply to Allen Winter (and Hugo, and Aaron): I feel that Allen's idea/suggestion is really good -- having MYSELF made the mistake of 'poking around' in the master branch for a while. If it had been completely empty of files, I'd have gotten a really big clue instantly. BTW, Will a '4.8' b

Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-09-22 Thread Kai Uwe Broulik
> On Aug. 9, 2011, 9:40 a.m., David Faure wrote: > > What I don't like about a single button, is that it creates a race. > > > > The calculation takes too long, you want to abort it. You click on the > > button, and half a second before, the calculation actually ended. So your > > click trigge

Re: Review Request: Update tab labels list after moving when using QTabWidget::setMovable()

2011-09-22 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102628/#review6732 --- Looks good to me. I've attached a unit test to the bug report -

Re: a cmake file is missing

2011-09-22 Thread Christoph Feck
On Thursday 22 September 2011 14:29:43 guy-kde wrote: > Hello all! > > With the commit f9497104b6f8a3b070672a93f95e50bb999d4df6 at Sat > Sep 17 16:39:20 2011 > in the file CMakeKists.txt, a request to KActivities is new (line > 20). cmake command says: >Adjust CMAKE_MODULE_PATH to find Find

a cmake file is missing

2011-09-22 Thread guy-kde
Hello all! With the commit f9497104b6f8a3b070672a93f95e50bb999d4df6 at Sat Sep 17 16:39:20 2011 in the file CMakeKists.txt, a request to KActivities is new (line 20). cmake command says: Adjust CMAKE_MODULE_PATH to find FindKActivities.cmake or set KActivities_DIR to the directory containin

Re: Re: I like KDE and I write code, therefore ...

2011-09-22 Thread Gorosito Gonzalo
First of all, thanks guys for the quick response. Albert: You're totally right, one of my primary languages are Spanish, as well Portuguese and about the IRC, you're making me remember the times where I use BitchX to chat with girls of my city! haha!! Chirag: Cool, that's what I'm planning to do.