Re: Proposal to use QIcon in APIs in KF5.

On 07.09.11 02:57:29, Tomaz Canabrava wrote: > On Wed, Sep 7, 2011 at 2:53 AM, Boudewijn Rempt wrote: > > On Wednesday 07 September 2011 Sep, John Layt wrote: > > > >> Porting a dozen or so lines from KIcon(foo) to KIconFactory::icon(foo) is > >> nowhere near the effort > > > > Just to make sure t

Re: Proposal to use QIcon in APIs in KF5.

On Wed, Sep 7, 2011 at 2:53 AM, Boudewijn Rempt wrote: > On Wednesday 07 September 2011 Sep, John Layt wrote: > >> Porting a dozen or so lines from KIcon(foo) to KIconFactory::icon(foo) is >> nowhere near the effort > > Just to make sure that everyone has the right perspective on the size of any

Re: Proposal to use QIcon in APIs in KF5.

On Wednesday 07 September 2011 Sep, John Layt wrote: > Porting a dozen or so lines from KIcon(foo) to KIconFactory::icon(foo) is > nowhere near the effort Just to make sure that everyone has the right perspective on the size of any porting effort: Calligra alone has over 1200 of KIcon(foo) line

Re: Proposal to use QIcon in APIs in KF5.

On Wednesday, September 07, 2011 00:56:58 John Layt wrote: > On Tuesday 06 Sep 2011 23:14:03 Albert Astals Cid wrote: > > A Dimarts, 6 de setembre de 2011, Stephen Kelly vàreu escriure: > > > I want to know what people expect in terms of source > > > compatibility and what people are willing to acc

Re: Proposal to use QIcon in APIs in KF5.

On Tuesday 06 Sep 2011 23:14:03 Albert Astals Cid wrote: > A Dimarts, 6 de setembre de 2011, Stephen Kelly vàreu escriure: > > I want to know what people expect in terms of source > > compatibility and what people are willing to accept. At the moment I > > don't know those things. > > To be honest

Re: Proposal to use QIcon in APIs in KF5.

A Dimarts, 6 de setembre de 2011, Stephen Kelly vàreu escriure: > I want to know what people expect in terms of source > compatibility and what people are willing to accept. At the moment I don't > know those things. To be honest, application developers were promised almost total source compatibi

Proposal to use QIcon in APIs in KF5.

Hi, I re-read the IRC log from the last email and noticed the recommendation of and API review instead of meta-discussion, which I missed at the time. That is probably a good recommendation. Posting the log was probably a bad call on my part, and we can hopefully have a more useful discussion

Re: Re: Replacing the KIcon type with a factory method and is frameworks a good idea at all?

A Dimarts, 6 de setembre de 2011, Ingo Klöcker vàreu escriure: > Hi all, > > I just want to comment on one thing: > > [14:30:15] steveire: you're basically saying we should > > favor hypothetical Qt developers over actual KDE app developers. > > Apart from the fact (as far as I understood the di

Re: Review Request: KVersionControlPlugin2 interface to implement add some features not available in current interface.

> On Sept. 6, 2011, 4:28 p.m., Sebastian Doerner wrote: > > Looks good to me. Peter, are you fine with this? The plugin itself will > > follow next. > > Peter Penz wrote: > @Frank: I'm fine with the interface extensions! > > @Vishesh: Thanks for the patch, it looks fine. Please giv

Re: Replacing the KIcon type with a factory method and is frameworks a good idea at all?

Hi all, I just want to comment on one thing: > [14:30:15] steveire: you're basically saying we should > favor hypothetical Qt developers over actual KDE app developers. Apart from the fact (as far as I understood the discussion) that Steve isn't favoring one over the other but rather trying to

Re: Review Request: KVersionControlPlugin2 interface to implement add some features not available in current interface.

> On Sept. 6, 2011, 4:28 p.m., Sebastian Doerner wrote: > > Looks good to me. Peter, are you fine with this? The plugin itself will > > follow next. > > Peter Penz wrote: > @Frank: I'm fine with the interface extensions! > > @Vishesh: Thanks for the patch, it looks fine. Please giv

suggestion & PATCH: center shutdown-dialog on screen containing mouse-pointer

Hello! This concerns kde-workspace In my dual-screen setup I have a second instance of the kde-menu on the second screen and what has always been bugging me: When I activate "logout" or "shutdown" or alike from this kde-menu the confirmation-dialog always gets shown on screen #0 no matter what.

Re: Review Request: KVersionControlPlugin2 interface to implement add some features not available in current interface.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102541/#review6305 --- Looks good to me. Peter, are you fine with this? The plugin itse

Re: Review Request: KVersionControlPlugin2 interface to implement add some features not available in current interface.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102541/#review6300 --- lib/konq/kversioncontrolplugin.h

Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

> On Sept. 6, 2011, 9:13 a.m., Sebastian Trueg wrote: > > The weird thing here is that this widget can also be opened from the KCM. > > Thus, the KCM could start itself. Not a great idea. Maybe we should stick > > to the action in the context menu of the system tray icon for now. Or you > > ma

Re: Review Request: KVersionControlPlugin2 interface to implement add some features not available in current interface.

> On Sept. 6, 2011, 4:28 p.m., Sebastian Doerner wrote: > > Looks good to me. Peter, are you fine with this? The plugin itself will > > follow next. @Frank: I'm fine with the interface extensions! @Vishesh: Thanks for the patch, it looks fine. Please give me a little bit time to get Dolphin 2

Re: Review Request: Change konqueror tabs look and feel

Am Mon, 5 Sep 2011 03:20:45 -0500 schrieb Yang Su : > On Sun, Sep 4, 2011 at 6:15 AM, Stefan Majewsky > wrote: > > > I'm a bit disappointed that an important point of the whole > > "uniform tab size" model is missing in this and also in the Rekonq > If the only reason for having equal-size tab

Re: Review Request: KVersionControlPlugin2 interface to implement add some features not available in current interface.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102541/ --- (Updated Sept. 6, 2011, 3:51 p.m.) Review request for Dolphin, KDE Base Ap

Re: Replacing the KIcon type with a factory method and is frameworks a good idea at all?

A Dimarts, 6 de setembre de 2011, Stephen Kelly vàreu escriure: > We've just had a long discussion about the future of KIcon in APIs, > which led into a discussion about what we're doing in frameworks at > all and why. > > Several people don't think refactoring kdelibs into independent > framework

Re: Replacing the KIcon type with a factory method and is frameworks a good idea at all?

Hello, On Tuesday 06 September 2011 10:41:22 Michael Pyne wrote: > * With all /that/ said, if all KIcon has over QIcon is the automatic usage > of KIconLoader (and look at the source [kdelibs/kdeui/icons/kicon.cpp], > that really is pretty much all it has) then I personally don't think it > should

Re: Replacing the KIcon type with a factory method and is frameworks a good idea at all?

On Tuesday, September 06, 2011 14:39:35 Stephen Kelly wrote: > We've just had a long discussion about the future of KIcon in APIs, > which led into a discussion about what we're doing in frameworks at > all and why. > > Several people don't think refactoring kdelibs into independent > frameworks i

Review Request: KVersionControlPlugin2 interface to implement add some features not available in current interface.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102541/ --- Review request for Dolphin, KDE Base Apps, Peter Penz, and Sebastian Doerner

Replacing the KIcon type with a factory method and is frameworks a good idea at all?

We've just had a long discussion about the future of KIcon in APIs, which led into a discussion about what we're doing in frameworks at all and why. Several people don't think refactoring kdelibs into independent frameworks is a good thing. Do we need to decide if it's worth it? I'm posting the l

Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102523/#review6294 --- The weird thing here is that this widget can also be opened from