Re: Review Request: Konqueror: Ask for session restore ONLY on plain startup (not for every window)

2011-08-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101850/#review6144 --- konqueror/src/konqmain.cpp

Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/#review6143 --- This review has been submitted with commit ebc84058d15b250417d1

Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-29 Thread Peter Penz
> On Aug. 29, 2011, 9:40 a.m., Peter Penz wrote: > > Thanks for the update! Looks good and is exactly like the proposal you, > > Frank and I discussed per e-mail. As usual I've added a punch of my > > nitpicking stuff ;-) Please push it to master after fixing, you don't need > > to add another

Re: Review Request: Inserts the program version in more cases in bug reports.

2011-08-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102479/#review6137 --- This review has been submitted with commit 0f88ec8fd9b11d002eae

Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-29 Thread Tirtha Chatterjee
> On Aug. 29, 2011, 9:40 a.m., Peter Penz wrote: > > Thanks for the update! Looks good and is exactly like the proposal you, > > Frank and I discussed per e-mail. As usual I've added a punch of my > > nitpicking stuff ;-) Please push it to master after fixing, you don't need > > to add another

Re: Review Request: plasma_applet_folderview - folder previews on mouse hover

2011-08-29 Thread Kevin Krammer
On Monday, 2011-08-29, Greg T wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102300/#review6133 > --- > > > Hey guys, no

Re: Review Request: plasma_applet_folderview - folder previews on mouse hover

2011-08-29 Thread Christoph Feck
> On Aug. 29, 2011, 10:41 a.m., Greg T wrote: > > Hey guys, no reaction? this isn't the right place? Maybe add "plasma" group to reviewers. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboa

Re: Review Request: plasma_applet_folderview - folder previews on mouse hover

2011-08-29 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102300/#review6133 --- Hey guys, no reaction? this isn't the right place? - Greg On

Re: Review Request: accept KAssitantDialog when calling next() on last page and if that is valid

2011-08-29 Thread Milian Wolff
> On Aug. 29, 2011, 8:42 a.m., Aaron J. Seigo wrote: > > kdeui/dialogs/kassistantdialog.cpp, lines 118-122 > > > > > > should probably be changed to use kdelibs style ... I just used the surrounding code style, but

Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-29 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/#review6128 --- Ship it! Thanks for the update! Looks good and is exactly like

Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-29 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/ --- (Updated Aug. 29, 2011, 9:14 a.m.) Review request for KDE Base Apps and Pe

Re: Review Request: Inserts the program version in more cases in bug reports.

2011-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102479/#review6126 --- Ship it! a bit of an ugly hack, but what can one do? :) drko

Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-29 Thread Alexander Potashev
2011/8/26 Alexander Potashev : > This argument wins. Just give me a couple of days to get to changing > all classes to "data only in private class" strategy. Done. -- Alexander Potashev

Re: Review Request: accept KAssitantDialog when calling next() on last page and if that is valid

2011-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102475/#review6125 --- Ship it! kdeui/dialogs/kassistantdialog.cpp

Re: Review Request: Find list items by typing their initial letters.

2011-08-29 Thread Aaron J. Seigo
> On Aug. 28, 2011, 12:49 p.m., Peter Penz wrote: > > Looks fine! Please just push it to master after fixing the minor > > const-comments. > > Tirtha Chatterjee wrote: > Pushed to master. I forgot to mention the review number in the commit > message. if you forget the review # in the comm