Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-28 Thread Alexander Potashev
2011/8/29 Albert Astals Cid : > What's special in those classes? Well, nothing, nevermind ;) They are just much simpler than the *Job classes. -- Alexander Potashev

Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-28 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/#review6114 --- Thanks, but you need please to rebase your diff against master f

Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-28 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/ --- (Updated Aug. 28, 2011, 11:33 p.m.) Review request for KDE Base Apps and P

Re: Review Request: Find list items by typing their initial letters.

2011-08-28 Thread Tirtha Chatterjee
> On Aug. 28, 2011, 12:49 p.m., Peter Penz wrote: > > Looks fine! Please just push it to master after fixing the minor > > const-comments. Pushed to master. I forgot to mention the review number in the commit message. - Tirtha --- This

Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-28 Thread Albert Astals Cid
A Divendres, 26 d'agost de 2011, Alexander Potashev vàreu escriure: > 2011/8/26 David Faure : > > A last argument, code is easier to maintain if it follows the same rules > > everywhere. So in all "public library" code (Qt, kdelibs, and all other > > public libs) we should do things the same way, t

Re: Review Request: Find list items by typing their initial letters.

2011-08-28 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- (Updated Aug. 28, 2011, 12:21 p.m.) Review request for KDE Base Apps and P

Review Request: Inserts the program version in more cases in bug reports.

2011-08-28 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102479/ --- Review request for KDE Runtime and Darío Andrés Rodríguez. Summary ---

Review Request: accept KAssitantDialog when calling next() on last page and if that is valid

2011-08-28 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102475/ --- Review request for kdelibs. Summary --- The apidox for KAssitantDialo

Re: Review Request: Find list items by typing their initial letters.

2011-08-28 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/#review6096 --- Ship it! Looks fine! Please just push it to master after fixing

Re: 4.7 mergable into frameworks. No need to cherry-pick

2011-08-28 Thread Chusslove Illich
> [: Stephen Kelly :] > Also, if you make a change which is likely not to apply cleanly to > frameworks, it's probably best for you to merge it sooner rather than wait > for someone else to do it wrongly. Good point, I might have missed that. So, I'll always check if 4.7 change applies cleanly, an

Re: 4.7 mergable into frameworks. No need to cherry-pick

2011-08-28 Thread Stephen Kelly
Chusslove Illich wrote: >> [: Stephen Kelly :] >> We don't have to make one commit on 4.7 == one merge into frameworks. >> >> We can just delay the merge and do it once a day or week. No one is using >> frameworks, so we just need to make sure the commits get in eventually or >> before it becomes

Re: Review Request: Find list items by typing their initial letters.

2011-08-28 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/#review6086 --- Looks very good from my point of view. The new files kitemlistk

Re: 4.7 mergable into frameworks. No need to cherry-pick

2011-08-28 Thread Chusslove Illich
> [: Stephen Kelly :] > We don't have to make one commit on 4.7 == one merge into frameworks. > > We can just delay the merge and do it once a day or week. No one is using > frameworks, so we just need to make sure the commits get in eventually or > before it becomes hard to merge. Who exactly is