Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-27 Thread Rolf Eike Beer
> Allow opening files and directories by pressing 'Enter' key. In case > multiple files are selected when enter is pressed, all of them are opened. > In case of multiple directories, the first directory gets opened in the > current tab, while the other directories open in new tabs. Nice idea, but:

Re: Review Request: Find list items by typing their initial letters.

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- (Updated Aug. 27, 2011, 11:22 p.m.) Review request for KDE Base Apps and P

Re: Review Request: Find list items by typing their initial letters.

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- (Updated Aug. 27, 2011, 8:36 p.m.) Review request for KDE Base Apps and Pe

Re: Review Request: Find list items by typing their initial letters.

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- (Updated Aug. 27, 2011, 8:22 p.m.) Review request for KDE Base Apps and Pe

Review Request: Find list items by typing their initial letters.

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/ --- Review request for KDE Base Apps and Peter Penz. Summary --- This pat

Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/ --- (Updated Aug. 27, 2011, 12:31 p.m.) Review request for KDE Base Apps and P

Re: Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/ --- (Updated Aug. 27, 2011, noon) Review request for KDE Base Apps and Peter P

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Tirtha Chatterjee
> On Aug. 27, 2011, 9:31 a.m., Peter Penz wrote: > > Thanks for the update, but could you please revert the changes with > > KGlobalSettings::changeCursorOverIcon()? I consider this option an > > unnecessary "micro-option" and plan to implement the same behavior as in > > Dolphin 1.7. Yeah su

Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/ --- Review request for KDE Base Apps and Peter Penz. Summary --- Allow op

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- (Updated Aug. 27, 2011, 7:31 a.m.) Review request for KDE Base Apps and Pe

Re: [Kde-scm-interest] git workflow draft

2011-08-27 Thread Michael Pyne
On Saturday, August 27, 2011 21:27:06 Michael Pyne wrote: > On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: > > Was this decided upon at some point? I got conflicting stories from > > sysadmin and other developers. Yesterday after migrating kdeaccessibility > > to git I was asked by a s

Re: [Kde-scm-interest] git workflow draft

2011-08-27 Thread Michael Pyne
On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: > Was this decided upon at some point? I got conflicting stories from > sysadmin and other developers. Yesterday after migrating kdeaccessibility > to git I was asked by a sysadmin to rename the X.Y branches to KDE/X.Y I > think concensu

Re: Review Request: Find list items by typing their initial letters.

2011-08-27 Thread Peter Penz
> On Aug. 27, 2011, 9:08 p.m., Peter Penz wrote: > > Thanks for this patch. As discussed per e-mail already I think from a > > design point of view this is fine and the patch looks good! I've added > > quite a lot of nitpicking comments, would be great if you could fix those > > things and do

Re: Review Request: Find list items by typing their initial letters.

2011-08-27 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102465/#review6075 --- Thanks for this patch. As discussed per e-mail already I think f

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Peter Penz
> On Aug. 27, 2011, 9:31 a.m., Peter Penz wrote: > > Thanks for the update, but could you please revert the changes with > > KGlobalSettings::changeCursorOverIcon()? I consider this option an > > unnecessary "micro-option" and plan to implement the same behavior as in > > Dolphin 1.7. > > Tir

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/#review6056 --- This review has been submitted with commit b0db096e4a3efc58da1c

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/#review6050 --- Thanks for the update, but could you please revert the changes w

Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- Review request for KDE Base Apps and Peter Penz. Summary --- Honours