Review Request: Fix for kio_sftp login problems

2011-08-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102428/ --- Review request for KDE Runtime and Andreas Schneider. Summary --- The

Review Request: Fix KUrlCompletionPrivate::urlCompletion's behavior

2011-08-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102425/ --- Review request for kdelibs and David Faure. Summary --- The attached

Re: git workflow draft

2011-08-24 Thread Jeremy Whiting
On Wed, Aug 24, 2011 at 5:29 AM, Thomas Zander wrote: > On Wednesday 24 August 2011 06.20.06 Torgny Nyblom wrote: > > My vote goes for the X.Y scheme as the repo is already under the > > KDE namespace. > > That information is lost as soon as the repository is cloned, though. > > As disc and bandw

Re: Review Request: GSoC: Errors handling during file transfer.

2011-08-24 Thread Cyril Oblikov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102388/ --- (Updated Aug. 24, 2011, 4:29 p.m.) Review request for kdelibs and David Fa

Re: Review Request: GSoC: Errors handling during file transfer.

2011-08-24 Thread Cyril Oblikov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102388/ --- (Updated Aug. 24, 2011, 4:25 p.m.) Review request for kdelibs and David Fa

Re: Review Request: GSoC: Errors handling during file transfer.

2011-08-24 Thread Cyril Oblikov
> On Aug. 22, 2011, 4:06 p.m., David Faure wrote: > > kio/kio/interactiondialog/allinteractionitem.h, line 47 > > > > > > You can't use i18n in a header file, nor in a static object. Instead, > > fill the list on de

Re: Review Request: Do not crash when KXMLGUIFactoryPrivate::saveDefaultActionProperties' parameter contains null QActions

2011-08-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102419/#review5988 --- This review has been submitted with commit b37cc1c84c923c10a494

Re: Review Request: Do not crash when KXMLGUIFactoryPrivate::saveDefaultActionProperties' parameter contains null QActions

2011-08-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102419/#review5987 --- This review has been submitted with commit 35f5e5d814a1f489e9ed

Re: Review Request: Do not crash when KXMLGUIFactoryPrivate::saveDefaultActionProperties' parameter contains null QActions

2011-08-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102419/#review5984 --- Ship it! Sure, but finding where the null pointer comes from (i

Re: git workflow draft

2011-08-24 Thread Thomas Zander
On Wednesday 24 August 2011 06.20.06 Torgny Nyblom wrote: > My vote goes for the X.Y scheme as the repo is already under the > KDE namespace. That information is lost as soon as the repository is cloned, though. As disc and bandwidth gets cheaper we'll probably see more mirror sites do full mirr

Re: Review Request: Fixed rating in knewstupp3.

2011-08-24 Thread Oldřich Jedlička
> On Aug. 23, 2011, 8:35 p.m., Jeremy Paul Whiting wrote: > > Looks good. If you have commit access, go for it, otherwise let us know > > and I can. Thanks. I don't have the commit access, so please commit it. - Oldřich --- This is an