Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-08-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101949/#review5969 --- This review has been submitted with commit a47e3211681aa3123a7a

Re: git workflow draft

2011-08-23 Thread Rolf Eike Beer
Am Dienstag, 23. August 2011, 08:15:50 schrieb Aaron J. Seigo: > On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: > > Was this decided upon at some point? I got conflicting stories > > fromsysadmin and other developers. Yesterday after migrating > > kdeaccessibilityto git I was asked by

Review Request: Do not crash when KXMLGUIFactoryPrivate::saveDefaultActionProperties' parameter contains null QActions

2011-08-23 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102419/ --- Review request for kdelibs and David Faure. Summary --- This patch ad

Re: git workflow draft

2011-08-23 Thread Torgny Nyblom
On Tue, 23 Aug 2011 08:15:50 +0200, Aaron J. Seigo wrote: On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: Was this decided upon at some point? I got conflicting stories fromsysadmin and other developers. Yesterday after migrating kdeaccessibilityto git I was asked by a sysadmin to r

Re: Review Request: Fixed rating in knewstupp3.

2011-08-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102416/#review5967 --- This review has been submitted with commit d2dd87af8b6bd2146b4e

System clock change notification

2011-08-23 Thread John Layt
We've long had various bugs filed for our software clocks not properly syncing when the Linux system clock changes, and we've always wanted some way to be notified when changes did occur instead of having to always poll for them. Thanks to a blog on Planet Gnome [1] I've found out that apparent

Re: Review Request: Fixed rating in knewstupp3.

2011-08-23 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102416/#review5953 --- Ship it! Looks good. If you have commit access, go for it, oth

Review Request: Fixed rating in knewstupp3.

2011-08-23 Thread Oldřich Jedlička
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102416/ --- Review request for kdelibs. Summary --- The slot disconnection uses w

Re: git workflow draft

2011-08-23 Thread Jeremy Whiting
On Tue, Aug 23, 2011 at 12:38 AM, Ben Cooksley wrote: > On Tue, Aug 23, 2011 at 6:15 PM, Aaron J. Seigo wrote: > > On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: > >> Was this decided upon at some point? I got conflicting stories > fromsysadmin > >> and other developers. Yesterday a

Re: systemd and KDE (was: Re: kdeinit)

2011-08-23 Thread Tom Gundersen
On Tue, Aug 23, 2011 at 4:48 PM, Stefan Majewsky wrote: >> the only thing that might be interesting is to provide a serviceForSource >> implementation that allows interacting with a unit, if a user is able to do >> anything useful (such as activate/deactive a unit?). i'm not sure that's >> possibl

Re: systemd and KDE (was: Re: kdeinit)

2011-08-23 Thread Stefan Majewsky
On Tue, Aug 23, 2011 at 4:48 PM, Stefan Majewsky wrote: > I don't see such signals, and this can be a real problem. Looked again, and there is a single change signal, plus a set of properties which are invalidated by this signal. Should be enough to keep the cache sane. Greetings Stefan

Re: systemd and KDE (was: Re: kdeinit)

2011-08-23 Thread Stefan Majewsky
On Tue, Aug 23, 2011 at 8:10 AM, Aaron J. Seigo wrote: > is there a way to get notified from systemd when a unit changes activation or > load state? because those would also be useful in the engine, obviously. I don't see such signals, and this can be a real problem. libqsystemd currently impleme

Re: Review Request: GSoC: Errors handling during file transfer.

2011-08-23 Thread David Faure
> On Aug. 22, 2011, 4:06 p.m., David Faure wrote: > > kio/kio/copyjob.cpp, line 624 > > > > > > No C-style casts please. Use static_cast(foo) or > > constructor-syntax like time_t(foo). > > Cyril Oblikov wrote: >

Re: Review Request: GSoC: Errors handling during file transfer.

2011-08-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102388/#review5944 --- kio/kio/copyjob.cpp

Re: Review Request: GSoC: Errors handling during file transfer.

2011-08-23 Thread Cyril Oblikov
> On Aug. 22, 2011, 4:06 p.m., David Faure wrote: > > kio/kio/copyjob.h, line 263 > > > > > > ... yes? :) > > (end of sentence missing) fixed > On Aug. 22, 2011, 4:06 p.m., David Faure wrote: > > kio/kio/cop

Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-08-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101949/#review5929 --- This review has been submitted with commit 71109e44500859a412a8