Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-18 Thread Scott Kitterman
On Monday, August 15, 2011 05:31:26 PM Alexander Neundorf wrote: > 5) Required cmake version > > > David noted that we (KDE) are very conservative with the required CMake > version, i.e. we still depend on CMake 2.6.4, which is more than a year > old. Me (Alex) no

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

2011-08-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/ --- (Updated Aug. 18, 2011, 9:45 p.m.) Review request for kdelibs, David Faure

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

2011-08-18 Thread Dawit Alemayehu
> On Aug. 18, 2011, 8:39 p.m., Albert Astals Cid wrote: > > kio/kio/hostinfo.cpp, line 406 > > > > > > You are connecting thread finished to lookupFinished to try to reuse > > the thread and then in the constructor

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

2011-08-18 Thread Albert Astals Cid
> On Aug. 14, 2011, 11:02 p.m., Albert Astals Cid wrote: > > When using your code with my simple test program > > > > #include "hostinfo_p.h" > > #include > > #include > > #include > > > > int main(int a, char **b) > > { > > QApplication app(a, b); > > QTime t; > > t.

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

2011-08-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5799 --- kio/kio/hostinfo.cpp

Re: Review Request: Handle focus in KUrlNavigator

2011-08-18 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102345/ --- (Updated Aug. 18, 2011, 6 p.m.) Review request for kdelibs. Changes

Re: How to view resolved conflicts in a merge?

2011-08-18 Thread David Faure
On Tuesday 16 August 2011 22:09:21 Stephen Kelly wrote: > The merge showed that some commits in 4.7 have not made it into > frameworks. We really should merge in that direction, not cherry-pick > as everyone is currently doing. Another solution is to do what I did for the master->4.7 "merge". Inst

Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-08-18 Thread Allen Winter
> On Aug. 17, 2011, 1:19 p.m., Allen Winter wrote: > > Has this been committed? If so, please close this review; else please > > commit and close this review. > > > > Bjoern Ricks wrote: > Commit to trunk and/or 4.7? Only master -- better not muck around with 4.7 too much. The real solut

Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-18 Thread Alexander Potashev
2011/8/17 Thomas Zander : > Most C++ libraries use this, but I suggest to take a look at kdelibs for > inspiration. Implementation of p-pointers not always the same in the whole kdelibs. I preferred not to use neither Q_DECLARE_PRIVATE nor inheritance of *Private classes (as described at http://te

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-18 Thread Bjoern Ricks
On Thursday 18 August 2011 09:14:09 Volker Krause wrote: > We of course also want coverage of different hardware architectures and OS, > but that basically requires individual setups, and each of those requires > someone to maintain it. If you have access to such systems, running > automated builds

Re: idea for better usability with hdmi plug-and-play

2011-08-18 Thread todd rme
On Wed, Aug 17, 2011 at 7:01 PM, Simon Oosthoek wrote: > Hi kde core developers, > > I have an idea for better usability, which I tried to propose as a > feature request, but it ended up in "the wrong part of town". As you can > see in the (currently invalid) bug: > https://bugs.kde.org/show_bug.c

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-18 Thread Volker Krause
On Wednesday 17 August 2011 07:11:21 henry7...@gmail.com wrote: > Very interesting, but it appears to assume all the world is linux x86 (these > days probably x86-64, but the such VMs wouldn't run on any 32 bit machines > that might be left). Many of our big problems are things that work fine > the