Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-16 Thread Alexander Potashev
2011/8/17 Alexander Potashev : > So, the NoteInfoPrivate class may not have any declaration (except for > the forward declaration) until it will be necessary, right? There is "Q_DECLARE_PRIVATE" macro, interesting... Should I use it instead? -- Alexander Potashev

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

2011-08-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/ --- (Updated Aug. 17, 2011, 5:40 a.m.) Review request for kdelibs, David Faure

Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-16 Thread Alexander Potashev
2011/8/15 Albert Astals Cid : > A Dilluns, 15 d'agost de 2011, Alexander Potashev vàreu escriure: >> How about adding a "QMap m_ext;" to *Info classes, >> so that I can store additional variables there? Most (but not all) >> *Job classes are unlikely to be expanded later, because they perform >> ve

How to see the resolution of merge of KDE/4.7 into KF5

2011-08-16 Thread Stephen Kelly
Hi, I've just locally merged KDE/4.7 into frameworks. Before I push I want to review the conflicts and their resolutions, and I expect other developers would want to do the same. The merge showed that some commits in 4.7 have not made it into frameworks. We really should merge in that directio

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Laszlo Papp
> Also: we need to be sure that prelinkers do prelink PIE, despite the article > that Laszlo linked to. 1) prelink tries very very hard to skip PIE 2) ld.so ignores prelink information for PIE anyways so even if you force a PIE prelink you don't get anything There is no point in prelinking PIE si

Re: Review Request: Handle focus in KUrlNavigator

2011-08-16 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102345/#review5753 --- kfile/kurlnavigatorbutton.cpp

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Thiago Macieira
On Tuesday, 16 de August de 2011 20:53:45 Alexander Neundorf wrote: > > However, it's still not perfectly correct: the issue is the difference > > between -fPIE and -fPIC. In a PIE, the compiler and linker *know* that > > this ELF module is the first open loaded, > > Sorry, I don't understand that

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread John Layt
On Tuesday 16 Aug 2011 15:55:57 Oswald Buddenhagen wrote: > On Tue, Aug 16, 2011 at 03:40:22PM +0200, Albert Astals Cid wrote: > > A Dimarts, 16 d'agost de 2011, Oswald Buddenhagen vàreu escriure: > > > On Tue, Aug 16, 2011 at 10:59:18AM +0200, Thiago Macieira wrote: > > > > In my opinion, kdeinit

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Thiago Macieira
On Tuesday, 16 de August de 2011 16:55:57 Oswald Buddenhagen wrote: > in fact, the pragmatic solution would be dropping the kde platform and > concentrating on what we are good at: applications (and the underlying > qt-based frameworks). and a workspace, for those 50% of our community > who can bel

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Alexander Neundorf
On Tuesday 16 August 2011, Thiago Macieira wrote: > On Tuesday, 16 de August de 2011 19:36:17 Alexander Neundorf wrote: > > The idea here was not to get rid of this mechanism completely. > > If I understood correctly, with a PIE executable it is possible to dlopen > > the executable and call a sym

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Thiago Macieira
On Tuesday, 16 de August de 2011 19:36:17 Alexander Neundorf wrote: > The idea here was not to get rid of this mechanism completely. > If I understood correctly, with a PIE executable it is possible to dlopen > the executable and call a symbol from it. > This would make it possible to simply creat

Review Request: Handle focus in KUrlNavigator

2011-08-16 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102345/ --- Review request for kdelibs. Summary --- This patch makes KUrlNavigato

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Jeremy Whiting
On Mon, Aug 15, 2011 at 3:31 PM, Alexander Neundorf wrote: > ** > snip > > - > > 7) (Getting rid of) kdeinit > > - > > There was a discussion about what makes a KDE application different from a > non-KDE application.

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Torgny Nyblom
On Tuesday 16 August 2011 19.48.39 Alexander Neundorf wrote: [...] > There are currently several parties interested in running builds/test. > There is you working on Jenkins, Volker is working on setting up virtual > machines so users can do builds in a seti@home style, and Marcus is trying > to se

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Alexander Neundorf
On Tuesday 16 August 2011, Torgny Nyblom wrote: > On Monday 15 August 2011 23.31.26 Alexander Neundorf wrote: > [...] > > > - > > 8) Testing > > - > > > > We shortly discussed testing, continuous builds and nightly bu

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Alexander Neundorf
On Tuesday 16 August 2011, Boudewijn Rempt wrote: > On Tuesday 16 August 2011 Aug, Stephen Kelly wrote: > > Boudewijn Rempt wrote: > > > Lazy is good... When doing a pure Qt app with CMake, I actually use a > > > copy of all the KDE cmake extensions :-). > > > > Which do you use? Do you also use t

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Oswald Buddenhagen
On Tue, Aug 16, 2011 at 07:24:19PM +0200, Alexander Neundorf wrote: > When looking at this statement carefully, applications, the underlying qt- > based frameworks and a workspace is actually pretty much what we do. > we actually do a bit more, and the side threads of the recent systemsettings thr

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Alexander Neundorf
On Tuesday 16 August 2011, Thiago Macieira wrote: ... > Another advantage of PIE is that the executable itself is position- > independent, meaning that the code can be shared if more than one instance > is loaded. For single-instance applications, this is not a gain. > > The disadvantage of PIE is

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Torgny Nyblom
On Monday 15 August 2011 23.31.26 Alexander Neundorf wrote: [...] > - > 8) Testing > - > > We shortly discussed testing, continuous builds and nightly builds. > I hope Volker (or somebody) can write a better summary. >

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Alexander Neundorf
On Tuesday 16 August 2011, Albert Astals Cid wrote: > A Dimarts, 16 d'agost de 2011, Oswald Buddenhagen vàreu escriure: > > On Tue, Aug 16, 2011 at 03:40:22PM +0200, Albert Astals Cid wrote: > > > A Dimarts, 16 d'agost de 2011, Oswald Buddenhagen vàreu escriure: > > > > On Tue, Aug 16, 2011 at 10:5

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Boudewijn Rempt
On Tuesday 16 August 2011 Aug, Stephen Kelly wrote: > Boudewijn Rempt wrote: > > > Lazy is good... When doing a pure Qt app with CMake, I actually use a copy > > of all the KDE cmake extensions :-). > > Which do you use? Do you also use them when creating libraries, not just > apps? Yes, also f

Re: Re: Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Albert Astals Cid
A Dimarts, 16 d'agost de 2011, Oswald Buddenhagen vàreu escriure: > On Tue, Aug 16, 2011 at 03:40:22PM +0200, Albert Astals Cid wrote: > > A Dimarts, 16 d'agost de 2011, Oswald Buddenhagen vàreu escriure: > > > On Tue, Aug 16, 2011 at 10:59:18AM +0200, Thiago Macieira wrote: > > > > In my opinion,

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Stephen Kelly
Boudewijn Rempt wrote: > Lazy is good... When doing a pure Qt app with CMake, I actually use a copy > of all the KDE cmake extensions :-). Which do you use? Do you also use them when creating libraries, not just apps?

Re: Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Oswald Buddenhagen
On Tue, Aug 16, 2011 at 03:40:22PM +0200, Albert Astals Cid wrote: > A Dimarts, 16 d'agost de 2011, Oswald Buddenhagen vàreu escriure: > > On Tue, Aug 16, 2011 at 10:59:18AM +0200, Thiago Macieira wrote: > > > In my opinion, kdeinit should stay. > > > > try to convince lennart of that. when i sugg

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Thiago Macieira
On Tuesday, 16 de August de 2011 13:16:44 Laszlo Papp wrote: > > btw, why cannot non-pic libs be prelinked? works for non-pie executables, > > after all. > > Well, by definition, non-pic libraries cannot be prelinked since the > symbols are at fixed addresses. You can not change the symbols using >

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Thiago Macieira
On Tuesday, 16 de August de 2011 12:50:47 Laszlo Papp wrote: > Hi, > > > kdeinit can be replaced by prelinking, assuming you are not a user of the > > NVidia binary drivers. If you are, you can't prelink, so kdeinit is a > > help: > > > > /usr/sbin/prelink: /usr/bin/gears: Cannot prelink against

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Laszlo Papp
> There was an article by Jakub explaining this. I can not seem to find it > right now. Found! :) The first one: http://lwn.net/Articles/190495/ Why PIE should not be prelinked and in general about the main purpose of PIE. > btw, why cannot non-pic libs be prelinked? works for non-pie executable

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Boudewijn Rempt
On Monday 15 August 2011 Aug, Alexander Neundorf wrote: > Me (Alex) argued > that most of the stuff in these macros adds only convenience for (lazy) KDE > developers, and will probably not be accepted. Lazy is good... When doing a pure Qt app with CMake, I actually use a copy of all the KDE cm

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Laszlo Papp
Hi, > kdeinit can be replaced by prelinking, assuming you are not a user of the > NVidia binary drivers. If you are, you can't prelink, so kdeinit is a help: > > /usr/sbin/prelink: /usr/bin/gears: Cannot prelink against non-PIC shared > library /usr/lib/nvidia-current/libGL.so.1 The nvidia driver

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Oswald Buddenhagen
On Tue, Aug 16, 2011 at 10:59:18AM +0200, Thiago Macieira wrote: > In my opinion, kdeinit should stay. > try to convince lennart of that. when i suggested to add kdeinit-like functionality to systemd his response was "no way". and if we ignore systemd, we'll lose in the longer run. the selinux guy

kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-16 Thread Thiago Macieira
On Monday, 15 de August de 2011 23:31:26 Alexander Neundorf wrote: > - > 7) (Getting rid of) kdeinit > - > > There was a discussion about what makes a KDE application different from a > non-KDE application. One thing

Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Alexander Neundorf
Hi, last week at Desktop Summit we had a KDE buildsystem BoF, where we discussed the state of our buildsystem with regard to Qt5 and the KDE frameworks modularization efforts. The nice thing is it seems there is a small community building up around this topic :-) Attendees were: Marco Martin,