Re: Review Request: Avoid terminating the thread in kio/kio/hostinfo.cpp

2011-08-14 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/ --- (Updated Aug. 15, 2011, 5:20 a.m.) Review request for kdelibs. Changes -

Re: Review Request: Avoid terminating the thread in kio/kio/hostinfo.cpp

2011-08-14 Thread Dawit Alemayehu
> On Aug. 15, 2011, 4:34 a.m., Commit Hook wrote: > > This review has been submitted with commit > > caece88d2c5b5b6f0da3dc048878831814aab9f3 by Jekyll Wu to branch master. The above commit message is invalid. It was intended for review 102239 (off by one). - Dawit

Re: Review Request: Avoid terminating the thread in kio/kio/hostinfo.cpp

2011-08-14 Thread Dawit Alemayehu
> On Aug. 14, 2011, 11:02 p.m., Albert Astals Cid wrote: > > When using your code with my simple test program > > > > #include "hostinfo_p.h" > > #include > > #include > > #include > > > > int main(int a, char **b) > > { > > QApplication app(a, b); > > QTime t; > > t.

Re: Review Request: Avoid terminating the thread in kio/kio/hostinfo.cpp

2011-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5700 --- This review has been submitted with commit caece88d2c5b5b6f0da3

Re: Review Request: Do not terminate threads

2011-08-14 Thread Albert Astals Cid
> On Aug. 12, 2011, 3:45 a.m., Dawit Alemayehu wrote: > > #1. Doesn't this approach have similar issues to the one that forced me to > > change the previous QtConcurrent::run based implementation ? That is, > > doesn't the use of a single thread expose this function to lookup requests > > back

Re: Review Request: Avoid terminating the thread in kio/kio/hostinfo.cpp

2011-08-14 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5696 --- When using your code with my simple test program #include "host

Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-14 Thread Albert Astals Cid
A Dimarts, 9 d'agost de 2011, Alexander Potashev vàreu escriure: > Hi, > > playground-libs/libkvkontakte moved to kdereview today. The next > target for this project is extragear/libs. This project is a library > for interaction with the most popular social network in Russia > VKontakte.ru (also a

Re: Review Request: Dolphin's preview configuration doesn't support over 2 GB files.

2011-08-14 Thread Jussi Judin
> On Aug. 14, 2011, 10:31 a.m., Peter Penz wrote: > > Thanks for the patch, looks fine! Please push it to master (if you don't > > have a git-account please let me know and I'll push it for you) No I don't so you need to do it. - Jussi ---

Re: KDE 5, Qt 5 and QML - What is advised for writing new (KDE) applications in the long term?

2011-08-14 Thread Mark
On Fri, Aug 12, 2011 at 5:11 PM, Shaun Reich wrote: > On Fri, Aug 12, 2011 at 10:22 AM, Mark wrote: >> 1. Write the application in Qt mostly and use kdelibs where needed? >> 2. Same as 1. but make the GUI in QML like i did in the example above? >> 3. Skip C++ altogether and make in in QML only? >

Re: Review Request: Dolphin's preview configuration doesn't support over 2 GB files.

2011-08-14 Thread Peter Penz
> On Aug. 14, 2011, 10:31 a.m., Peter Penz wrote: > > Thanks for the patch, looks fine! Please push it to master (if you don't > > have a git-account please let me know and I'll push it for you) > > Jussi Judin wrote: > No I don't so you need to do it. I've pushed it to master now :-) -

Re: Review Request: Dolphin's preview configuration doesn't support over 2 GB files.

2011-08-14 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102319/#review5683 --- Ship it! Thanks for the patch, looks fine! Please push it to ma

Review Request: Dolphin's preview configuration doesn't support over 2 GB files.

2011-08-14 Thread Jussi Judin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102319/ --- Review request for KDE Base Apps. Summary --- Fix Dolphin's preview s

Re: [Kde-pim] One Free N900 (Re: Kontact Touch went 2nd place in Contest, one N900 to be given away)

2011-08-14 Thread Marc Deop Argemí
On Friday 12 August 2011 15:02:48 Bernhard Reiter wrote: > We have not gotten any suggestions for people to receive the phone. > So if you had written a simple: I want it, you would have been the one. Well, i do want one, specially after mine going to the graveyard recently. The thing is that I d

Re: Review Request: Fix missing "..." in KBookmarkAction displayed text

2011-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5682 --- This review has been submitted with commit 3cc10496aa6eb4aae27b

Re: Review Request: Fix missing "..." in KBookmarkAction displayed text

2011-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5681 --- This review has been submitted with commit ddcf5c0fd58bbe4e8572

Re: Review Request: Locale-independent parsing of floats in trader queries

2011-08-14 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101610/ --- (Updated Aug. 14, 2011, 9:43 a.m.) Review request for kdelibs. Changes -