Re: Review Request: Do not terminate threads

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5654 --- #1. Doesn't this approach have similar issues to the one that fo

Re: Review Request: Avoid terminating the thread in kio/kio/hostinfo.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/ --- (Updated Aug. 12, 2011, 3:45 a.m.) Review request for kdelibs. Changes -

Review Request: [KDE/Windows] Do not set cursorFlashTime, but respect Control Panel setting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102313/ --- Review request for kdelibs and kdewin. Summary --- The bad thing with

Re: Review Request: Do not terminate threads

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/ --- (Updated Aug. 11, 2011, 10:10 p.m.) Review request for kdelibs and Dawit A

Re: Review Request: Do not terminate threads

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5653 --- kio/kio/hostinfo.cpp

Re: Master or 4.7 under VirtualBox/KVM

On Thu, 11 Aug 2011 13:45:41 +0200, İsmail Dönmez wrote: Hi; On Wed, Aug 3, 2011 at 7:39 PM, Martin Gräßlin wrote: On Sunday 31 July 2011 12:58:05 Michael Jansen wrote: > Did we manage to break kde under virtual machines? Or is the problem here? > > Has someone a recent kde running in a

Re: Formal complaint concerning the use of the name "System Settings" by GNOME

On Wed, 2011-08-10 at 13:47 +0200, todd rme wrote: > On Wed, Aug 10, 2011 at 1:42 PM, Richard Hughes wrote: > > On 4 August 2011 07:27, George Spelvin wrote: > >> I think what is needed is a series of more specific alternate names in > >> a .desktop file, with more levels than the current Generic

Re: Master or 4.7 under VirtualBox/KVM

Hi; On Wed, Aug 3, 2011 at 7:39 PM, Martin Gräßlin wrote: > On Sunday 31 July 2011 12:58:05 Michael Jansen wrote: > > Did we manage to break kde under virtual machines? Or is the problem > here? > > > > Has someone a recent kde running in a vm? > For the record: I just found the commit which bro

Review Request: plasma_applet_folderview - folder previews on mouse hover

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102300/ --- Review request for KDE Base Apps. Summary --- Hello, this is my attem

Review Request: rate control in ftp kio slave with review comments fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102307/ --- Review request for kdelibs, Dawit Alemayehu, David Faure, Thiago Macieira,

Re: Review Request: Fix missing "..." in KBookmarkAction displayed text

> On Aug. 11, 2011, 9:13 a.m., David Faure wrote: > > Ah, I see. Indeed after reading QAction::iconText() it's all clear ;) > > > > But yeah this is quite obviously a bug in qaction (qt_strippedText), which > > should remove "..." only at the end. It's my first patch in kdelibs, where should i

Re: Review Request: Add the resource paramater in resource queries

> On Wednesday 10 August 2011 15:22:51 Vishesh Handa wrote: >> If I push it into the 'frameworks' branch, then it won't be a part of >> KDE >> until KDE Platform 5, which is quite far away. > > Yes, this is why we were talking about splitting out nepomuk into its own > repo, since it's already sepa

Re: Review Request: Do not terminate threads

> On Aug. 11, 2011, 11:11 a.m., Thiago Macieira wrote: > > kio/kio/hostinfo.cpp, line 118 > > > > > > This class could be simplified to a simple struct. Yeah, but what's the benefit? > On Aug. 11, 2011, 11:11 a.m

Re: Review Request: Do not terminate threads

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5636 --- kio/kio/hostinfo.cpp

Re: Review Request: Make KSambaSharePrivate::getNetUserShareInfo less noisy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102172/#review5634 --- This review has been submitted with commit de6bae2c9331ca2a1e94

Re: Review Request: Make KSambaSharePrivate::getNetUserShareInfo less noisy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102172/#review5633 --- This review has been submitted with commit 75d7cc47fc071f227049

Re: Review Request: Do not terminate threads

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/ --- (Updated Aug. 11, 2011, 10:34 a.m.) Review request for kdelibs and Dawit A

Re: Review Request: Do not terminate threads

> On Aug. 11, 2011, 9:41 a.m., David Faure wrote: > > kio/kio/hostinfo.cpp, line 236 > > > > > > Maybe move nameLookupThread as a member of hostInfoAgentPrivate, to > > avoid multiplying the global statics (and the

Re: Review Request: Do not terminate threads

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/ --- (Updated Aug. 11, 2011, 10:32 a.m.) Review request for kdelibs and Dawit A

Re: Review Request: Make KSambaSharePrivate::getNetUserShareInfo less noisy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102172/#review5627 --- Ship it! Sure, nice addition to my initial ac7fe47dc commit. -

Re: Review Request: new kded daemon to check .thumbnail directory space usage

On Thursday 04 August 2011 12:14:44 Christoph Feck wrote: > * Integration with Nepomuk, so that thumbnails automatically get > moved/deleted when the original file is. This can be done independently of nepomuk. When you move or delete a file using KIO, a dbus signal is emitted (see KDirNotify). W

Re: Fix kopete/kdenetwork build against Qt 4.8

On Thursday 04 August 2011 07:46:57 Jeremy Whiting wrote: > Hello, > > Qt 4.8 has a change to moc which makes virtual inheritance from QObject no > longer possible. This caused a problem in Jovie that was fixed by not > virtually inheriting from QObject anymore. There is a similar compile > prob

Re: Review Request: Do not terminate threads

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5623 --- Good job, this is tricky code indeed. Some comments below. kio

Re: Review Request: Add the resource paramater in resource queries

On Wednesday 10 August 2011 15:22:51 Vishesh Handa wrote: > If I push it into the 'frameworks' branch, then it won't be a part of KDE > until KDE Platform 5, which is quite far away. Yes, this is why we were talking about splitting out nepomuk into its own repo, since it's already separate. But

Re: Plan to transition to KDE Frameworks

On Wednesday 10 August 2011 11:49:29 Scott Kitterman wrote: > My concern isn't minor API extensions that might be needed to fix > a 4.7 bug, but with backporting new features to kdelibs 4.7 to support > (rest of the SC) 4.8 development. Right, we don't want that. The idea is there will not be n

Re: Review Request: Do not terminate threads

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/ --- (Updated Aug. 11, 2011, 9:23 a.m.) Review request for kdelibs and Dawit Al

Re: Review Request: Fix missing "..." in KBookmarkAction displayed text

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5621 --- Ship it! Ah, I see. Indeed after reading QAction::iconText() it