Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Tushar Mehta
> On Aug. 10, 2011, 1:07 p.m., David Faure wrote: > > kioslave/ftp/speedController.h, line 37 > > > > > > why not just return the int, like int bytesToRead()? acknowledged. With the current design of the code we do

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Tushar Mehta
> On Aug. 10, 2011, 3:05 p.m., Thiago Macieira wrote: > > kioslave/ftp/CMakeLists.txt, line 11 > > > > > > We usually do not use capitals in source code in kdelibs. (there are > > exceptions, but not in KIO). > >

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Tushar Mehta
> On Aug. 10, 2011, 1:07 p.m., David Faure wrote: > > kioslave/ftp/speedController.h, line 24 > > > > > > kde_file.h isn't used in this header -> move the #include to the .cpp > > file. I have used it for usleep. I

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Tushar Mehta
> On Aug. 10, 2011, 1:51 p.m., Thomas Zander wrote: > > kioslave/ftp/speedController.h, line 37 > > > > > > I'm wondering if the function name contains a typo; maybe you meant > > 'calcHowMuchToRead' (notice the ex

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Tushar Mehta
> On Aug. 10, 2011, 1:07 p.m., David Faure wrote: > > kioslave/ftp/speedController.h, line 3 > > > > > > This seems to be your own code, the copyright is yours, not mine :) Hey :) This is my first patch to the KDE an

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Tushar Mehta
> On Aug. 10, 2011, 3:05 p.m., Thiago Macieira wrote: > > kioslave/ftp/speedController.h, line 55 > > > > > > This will not work for kio_http. You need to limit the transfer rate > > from the ioslave to the applicat

Re: Review Request: middle click to close tabs

2011-08-10 Thread Marius Knaust
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102288/ --- (Updated Aug. 10, 2011, 3:50 p.m.) Review request for kdelibs and Thomas M

Re: Review Request: middle click to close tabs

2011-08-10 Thread Marius Knaust
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102288/ --- (Updated Aug. 10, 2011, 3:44 p.m.) Review request for kdelibs and Thomas M

Re: How to create libraries in KDE Frameworks 5

2011-08-10 Thread Stephen Kelly
Stephen Kelly wrote: > After using kde4_add_library the macro generate_export_header should be > used. > > kde4_add_library(itemmodels ...) > generate_export_header(itemmodels > DEPRECATED_NAME KDE_DEPRECATED > ) Just fyi, Instead of this, use only kf5_add_library. I've already ported existing

Re: Plan to transition to KDE Frameworks

2011-08-10 Thread Scott Kitterman
On Wednesday, August 10, 2011 08:39:49 AM David Faure wrote: > On Tuesday 09 August 2011 19:26:17 Scott Kitterman wrote: > > On Tuesday, August 09, 2011 07:05:53 PM David Faure wrote: > > > On Monday 08 August 2011 00:42:50 Scott Kitterman wrote: > > > > On Saturday, August 06, 2011 09:32:02 AM Dav

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Dawit Alemayehu
> On Aug. 10, 2011, 3:05 p.m., Thiago Macieira wrote: > > kioslave/ftp/speedController.h, line 55 > > > > > > This will not work for kio_http. You need to limit the transfer rate > > from the ioslave to the applicat

Re: Plan to transition to KDE Frameworks

2011-08-10 Thread David Faure
On Tuesday 09 August 2011 19:26:17 Scott Kitterman wrote: > On Tuesday, August 09, 2011 07:05:53 PM David Faure wrote: > > On Monday 08 August 2011 00:42:50 Scott Kitterman wrote: > > > On Saturday, August 06, 2011 09:32:02 AM David Faure wrote: > > > .. > > > > > > > The next step is to backport

Re: Review Request: Add the resource paramater in resource queries

2011-08-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102283/ --- (Updated Aug. 10, 2011, 3:22 p.m.) Review request for kdelibs, Nepomuk and

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102267/#review5606 --- kioslave/ftp/CMakeLists.txt

Re: Review Request: Add the resource paramater in resource queries

2011-08-10 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102283/#review5602 --- IMHO we should not push this before having the support in the KI

Re: Review Request: Add the resource paramater in resource queries

2011-08-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102283/ --- (Updated Aug. 10, 2011, 2:15 p.m.) Review request for kdelibs, Nepomuk and

Review Request:

2011-08-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102283/ --- Review request for kdelibs, Nepomuk and Sebastian Trueg. Summary ---

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Thomas Zander
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102267/#review5598 --- kioslave/ftp/speedController.h

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread Lukas Appelhans
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102267/#review5595 --- Patch works fine here by the way. Use case for this is KGet. -

Re: Review Request: Speed limit in ftp kio slave

2011-08-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102267/#review5593 --- kioslave/ftp/ftp.cpp

Re: Review Request: Fix missing "..." in KBookmarkAction displayed text

2011-08-10 Thread Yoann Laissus
> On Aug. 9, 2011, 10:45 p.m., David Faure wrote: > > Since you're setting iconText, this is about actions into a toolbar, not > > into a menu, right? > > > > So Qt strips "..." from toolbar button texts? What's the logic there? I'm > > just curious, the patch looks ok, from your description.

Re: Formal complaint concerning the use of the name "System Settings" by GNOME

2011-08-10 Thread todd rme
On Wed, Aug 10, 2011 at 1:42 PM, Richard Hughes wrote: > On 4 August 2011 07:27, George Spelvin wrote: >> I think what is needed is a series of more specific alternate names in >> a .desktop file, with more levels than the current GenericName and Name. > > I think the KDE system settings desktop

Re: Formal complaint concerning the use of the name "System Settings" by GNOME

2011-08-10 Thread Richard Hughes
On 4 August 2011 07:27, George Spelvin wrote: > I think what is needed is a series of more specific alternate names in > a .desktop file, with more levels than the current GenericName and Name. I think the KDE system settings desktop file just needs an addition of: OnlyShowIn=KDE; Richard.

Re: Review Request: Fix missing "..." in KBookmarkAction displayed text

2011-08-10 Thread Christoph Feck
> On Aug. 9, 2011, 10:45 p.m., David Faure wrote: > > Since you're setting iconText, this is about actions into a toolbar, not > > into a menu, right? > > > > So Qt strips "..." from toolbar button texts? What's the logic there? I'm > > just curious, the patch looks ok, from your description.

Re: Review Request: Umpteenth try to fix KCharSelect crash

2011-08-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102263/#review5569 --- Fixes the crash for me. - Albert On Aug. 9, 2011, 4:34 p.m.,