---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102256/#review5560
---
This review has been submitted with commit
b4f96a8f74431223b539
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101902/#review5559
---
This review has been submitted with commit
d0335a61536c3e9b2dfb
On Tuesday, August 09, 2011 07:05:53 PM David Faure wrote:
> On Monday 08 August 2011 00:42:50 Scott Kitterman wrote:
> > On Saturday, August 06, 2011 09:32:02 AM David Faure wrote:
> > ..
> >
> > > The next step is to backport the few bits of new api that went into
> > > master and that applicati
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101902/#review5557
---
Ship it!
Missing license; missing an increased d-bus timeout, l
On Monday 08 August 2011 00:42:50 Scott Kitterman wrote:
> On Saturday, August 06, 2011 09:32:02 AM David Faure wrote:
> ..
>
> > The next step is to backport the few bits of new api that went into master
> > and that application developers started using, into the 4.7 branch of
> > kdelibs. I'll w
On Tue, Aug 9, 2011 at 03:15, Michael Pyne wrote:
> On Monday, August 08, 2011 18:44:40 Tomaz Canabrava wrote:
>> Juk is an easy target, and in need of love.
>
> Honestly I was going to recommend the same thing.
>
> I don't agree that it's (all) easy (although there is certainly a lot of "low-
> h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102267/
---
Review request for kdelibs.
Summary
---
- This patch contains the bas
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102256/#review
---
This review has been submitted with commit
bd53435c033c4674d309
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102262/#review5554
---
Since you're setting iconText, this is about actions into a tool
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102262/
---
Review request for kdelibs.
Summary
---
When a bookmark name, is too
On Tue, May 24, 2011 at 6:06 PM, Aleix Pol wrote:
> Hi!
> Alex and I, we have been working lately on the Kamoso port to QtGstreamer,
> which has brought us a lot of stability, until the point that we are happy
> enough to leave playground.
>
> After a lot of discussion about where do we thing Kam
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102263/
---
Review request for kdelibs and Albert Astals Cid.
Summary
---
This is
> On July 20, 2011, 3:29 p.m., Peter Penz wrote:
> > Thanks for the update!
> >
> > >> would only make sense to push it to the 4.7 branch.
> > > What exactly do you mean by 'only'? Isn't 4.7 the branch just
> > > about to be released and which will be in all distros until sometime next
> > > ye
On Tuesday 09 August 2011 17:19:49 Olivier Goffart wrote:
> The proper thing to use here is a QWaitCondition
Which is easy to write racy code with (if B calls wake() before A calls
wait(), A missed the notification for good and it will sleep forever), so I
usually prefer a QSemaphore (which uses
On Dimarts 09 Agost 2011 14:57:06 David Faure wrote:
> > I just tried a test calling that function with 0 as timeout (so it always
> > timeouts) and sometimes it waits until 1 second so it is quite clear it
> > is waiting for the thread.
>
> Yes, Thiago explained to me the notion of cancellation p
> I just tried a test calling that function with 0 as timeout (so it always
> timeouts) and sometimes it waits until 1 second so it is quite clear it is
> waiting for the thread.
Yes, Thiago explained to me the notion of cancellation points, and proved me
wrong. And since anyway terminate is a ba
On Tuesday 09 August 2011 12:59:49 Thomas Zander wrote:
> On Monday 08 August 2011 16.28.43 Dawit A wrote:
> > > Apologies for still not getting it..> You stated you wanted to have
> > > a
> > > timeout to avoid a blocking UI, which as
> > > far as I understand you would also avoid if you don't cre
On Dimarts 09 Agost 2011 12:14:53 Thomas Zander wrote:
> On Tuesday 09 August 2011 12.59.49 Thomas Zander wrote:
> > Another solution for using a timeout can be something like the
> > attached version (I didn't even try to compile it, maybe the helper
> > object has to be
> > moved to a _p.h file t
> On Aug. 8, 2011, 1:53 p.m., David Faure wrote:
> >
>
> David Faure wrote:
> (Sorry, flaky wifi lost the comment)
>
> I am very much against a nested event loop (QEventLoop::exec), it's a
> well-known fact nowadays that it creates unexpected re-entrancy and crashes.
>
> A
2011/8/9 Christoph Feck :
> It doesn't compile because asserts reference undeclared variables.
> Attached patch shows where the errors are.
I've applied your patch to authenticationdialog.cpp and reworked error
reporting in allnoteslistjob.cpp and also in allmessageslistjob.cpp.
Thanks!
--
Alex
> On Aug. 9, 2011, 9:40 a.m., David Faure wrote:
> > What I don't like about a single button, is that it creates a race.
> >
> > The calculation takes too long, you want to abort it. You click on the
> > button, and half a second before, the calculation actually ended. So your
> > click trigge
On Tuesday 09 August 2011 12:07:49 Alexander Potashev wrote:
> Hi,
>
> playground-libs/libkvkontakte moved to kdereview today. The next
> target for this project is extragear/libs. This project is a
> library for interaction with the most popular social network in
> Russia VKontakte.ru (also avail
On Tuesday 09 August 2011 12.59.49 Thomas Zander wrote:
> Another solution for using a timeout can be something like the
> attached version (I didn't even try to compile it, maybe the helper object
> has to be
> moved to a _p.h file to get moc to run on it..)
Oh, and the mutex has to be made recu
On Monday 08 August 2011 16.28.43 Dawit A wrote:
> > Apologies for still not getting it..> You stated you wanted to have a
> > timeout to avoid a blocking UI, which as
> > far as I understand you would also avoid if you don't create a new
> > method that never blocks in the first place.
>
> The uri
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/#review5537
---
This review has been submitted with commit
2e2812f8e12154f2e267
> On Aug. 9, 2011, 9:40 a.m., David Faure wrote:
> > What I don't like about a single button, is that it creates a race.
> >
> > The calculation takes too long, you want to abort it. You click on the
> > button, and half a second before, the calculation actually ended. So your
> > click trigge
Hello,
I'm facing a bug with oxygen and KToolBar when compositing is active
that I need expert advice on.
The issue: when you detach (unlock and move out of the window) a
KToolbar from a main window, oxygen gives it the "translucent
background" flag, and uses it to draw nice beveled corner o
Hi,
playground-libs/libkvkontakte moved to kdereview today. The next
target for this project is extragear/libs. This project is a library
for interaction with the most popular social network in Russia
VKontakte.ru (also available at vk.com) using its public API
documented at http://vkontakte.ru/pa
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102149/#review5534
---
What I don't like about a single button, is that it creates a ra
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/#review5532
---
API looks ok. Implementation could prevent duplication by making
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/
---
(Updated Aug. 9, 2011, 8:39 a.m.)
Review request for kdelibs.
Changes
--
> On May 31, 2011, 9:24 p.m., Kevin Ottens wrote:
> > Note that I can't really comment on the activities specific parts, Ivan
> > would probably be a better reviewer for that parts. Anyway I found a couple
> > of smaller issues which need fixing.
The below have been fixed locally, but I haven'
> On Aug. 8, 2011, 10:51 p.m., David Jarvie wrote:
> > If the proposed patch is unacceptable, I suggest adding a new method
> >
> > static void allowWindowModal(bool allow);
> >
> > If called with true, this would enable the behaviour described in the
> > apidocs for subsequent KMessageBox ins
Hi,
> The itemmodels_export.h file is created in the build directory instead of
> being checked in. That means that it must be installed with a referenece to
> the build dir, like
>
> install(FILES
> ${CMAKE_CURRENT_BUILD_DIR}/itemmodels_export.h
> )
>
I think there is a mistake here to
34 matches
Mail list logo
