Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5467 --- >From the code POV seems fine to me, will try it later when some

Review Request: Do not terminate threads

2011-08-06 Thread Dawit A
On Sat, Aug 6, 2011 at 7:46 AM, Albert Astals Cid wrote: > On Dijous 04 Agost 2011 15:28:49 Dawit A wrote: >> On Thu, Aug 4, 2011 at 5:31 AM, Albert Astals Cid wrote: >> >    This is an automatically generated e-mail. To reply, visit: >> > http://git.reviewboard.kde.org/r/102179/ >> > >> > On Aug

Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/ --- Review request for kdelibs. Summary --- This patch replaces the creat

Re: Review Request: Fix KGlobalSettingsTest failure

2011-08-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102098/#review5460 --- This review has been submitted with commit a383ac8c7d3f666018e3

Re: Review Request: Fix [-Wunused-parameter] compiler warnings

2011-08-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101881/#review5456 --- This review has been submitted with commit cfeaa8ec35b93cbcff99

Re: Review Request: Export the function isShiftAsModifierAllowed() from KKeySequenceWidget

2011-08-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101515/#review5447 --- This review has been submitted with commit 316a2e7d9864af1e1576

Re: Review Request: Allow use of shift together with multimedia keys in shortcuts

2011-08-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101530/#review5448 --- This review has been submitted with commit ff2a3fbc82334825a3e1

Re: Review Request: Transparent QList handling in KUrl::List

2011-08-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101702/#review5446 --- This review has been submitted with commit d0776af040879c2e4abb

Re: Plan to transition to KDE Frameworks

2011-08-06 Thread David Faure
On Saturday 06 August 2011 10:10:16 Michael Pyne wrote: > If you do use prefix just make sure the path is whereever you want kdelibs > (frameworks branch) to be installed. Sure; the reason I included the line is to encourage people to install kdelibs-frameworks in a different prefix than the res

Re: Plan to transition to KDE Frameworks

2011-08-06 Thread Michael Pyne
On Saturday, August 06, 2011 15:32:02 David Faure wrote: > (*) Howto for kdesrc-build users: > > module kdelibs-frameworks > repository kde:kdelibs > branch frameworks > cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE:STRING=debugfull > -DCMAKE_PREFIX_PATH:PATH=/d/kde/inst/kdesuppor

Re: Plan to transition to KDE Frameworks

2011-08-06 Thread Eike Hein
On 08/06/2011 03:32 PM, David Faure wrote: To say this clearly: NO COMMITS ARE POSSIBLE IN KDELIBS MASTER. Sebas' proposal has finally been adopted, albeit with a minor modification: Always winter in trunk! :-) -- Best regards, Eike Hein

Re: Plan to transition to KDE Frameworks

2011-08-06 Thread David Faure
On Tuesday 07 June 2011 01:43:44 David Faure wrote: > Once the 4.7 branch is created, the plan is to do the following: > > - application developers can work in master as usual, no change there. > > - we create a new branch in kdelibs (say, "frameworks") for the work on > splitting up kdelibs and

Re: Review Request: Do not terminate threads

2011-08-06 Thread Albert Astals Cid
On Dijous 04 Agost 2011 15:28:49 Dawit A wrote: > On Thu, Aug 4, 2011 at 5:31 AM, Albert Astals Cid wrote: > >This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/102179/ > > > > On August 4th, 2011, 3:19 a.m., *Dawit Alemayehu* wrote: > > > > I do

Re: Review Request: Pass KAboutData::productName() to DrKonqi

2011-08-06 Thread George Kiagiadakis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102231/#review5428 --- I think the patch is fine, but I need to note two things: 1) I

Re: Workshop & BoF schedule at Desktop Summit

2011-08-06 Thread John Layt
On Friday 05 Aug 2011 17:53:42 Alexander Neundorf wrote: > Hi, > > John, Dario, please see at the end of the mail. > Would you mind if the "KDE Frameworks and Qt5" BoF is moved from Wednesday > 6:00PM to Wednesday 4:00PM ? > I would appreciate that, otherwise I won't be able to attend it. I'm not