Re: Review Request: Do not terminate threads

2011-08-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5369 --- I do not like this patch for the very reason you stated. I do no

Re: Review Request: Make sure QHostInfo metatype is registered

2011-08-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102178/#review5368 --- Ship it! This looks ok to me. Someone declared the meta-type fo

Re: Review Request: Start D-Bus after setting KDE_FULL_SESSION

2011-08-03 Thread Kevin Krammer
> On Aug. 3, 2011, 6:19 p.m., Oswald Buddenhagen wrote: > > this sounds wrong. what if dbus is started earlier, e.g. by a PAM module? > > this can easily happen once we use the new SecretService. > > there should be some interface to push environment variables "into the bus" > > after it is run

Re: KF5 & Qt5 - QtCS Session

2011-08-03 Thread John Layt
On Thursday 28 Jul 2011 15:25:38 Laszlo Papp wrote: > > ... > > * KJob - Qt-Addon for 5.1 > > Is the lack of manpower the reason or something else it is not planned > against 5.0 ? I have made some simple modifications in our project > where it is now KDE dependency free. Partly manpower, but mai

Re: Review Request: Start D-Bus after setting KDE_FULL_SESSION

2011-08-03 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102194/#review5362 --- this sounds wrong. what if dbus is started earlier, e.g. by a PA

Re: Master or 4.7 under VirtualBox/KVM

2011-08-03 Thread Martin Gräßlin
On Sunday 31 July 2011 12:58:05 Michael Jansen wrote: > Did we manage to break kde under virtual machines? Or is the problem here? > > Has someone a recent kde running in a vm? For the record: I just found the commit which broke it: 6aa2b5caf625a142e92bf4e7c99452bfad968a8c which basically remove

Re: Review Request: Resize KMessageBox::detailedError at start to display all text

2011-08-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101931/#review5352 --- This review has been submitted with commit 370d3ed6e5153fc61b77

Re: Review Request: Resize KMessageBox::detailedError at start to display all text

2011-08-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101931/#review5351 --- This review has been submitted with commit bd953f345b2413a44373

Re: Review Request: Generate email for docbook authors

2011-08-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/#review5350 --- This review has been submitted with commit 6fe43f5c89e9d9cb

Re: Review Request: Generate email for docbook authors

2011-08-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/#review5349 --- This review has been submitted with commit 2534d85a86546fa210d3

Review Request: Remove monthly auto backups from the GUI

2011-08-03 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102195/ --- Review request for KDE Runtime and Sebastian Trueg. Summary --- Month

Review Request: Start D-Bus after setting KDE_FULL_SESSION

2011-08-03 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102194/ --- Review request for kdelibs, Kevin Kofler, George Kiagiadakis, and David Faur