Re: Review Request: Generate email for docbook authors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/ --- (Updated July 12, 2011, 5:59 a.m.) Review request for kdelibs, Tom Albers,

Re: Review Request: fix for #277372 - dolphin part looses view state on every tab change

> On July 11, 2011, 9 p.m., Peter Penz wrote: > > Thanks for the patch, looks good! Committed to 4.7 (is already fixed for Dolphin 2.0 that will get merged to master around beginning of August) - Peter --- This is an automatically gene

Re: Review Request: DolphinDetailsView: fix column auto size fail on custom font styles

> On July 11, 2011, 9:38 p.m., Peter Penz wrote: > > Thanks for the patch! It looks good, but it only makes sense to push it to > > the 4.7 branch: For master Dolphin 2.0 will be integrated until beginning > > of August which has a new view-engine that makes this patch obsolete. If > > you pla

Re: Review Request: fix #277269 Dolphin(Part) Detail/Tree view, highlighted selection paint glitch

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101924/#review4621 --- Thanks again for your investigations. Like for the previous patc

Re: Review Request: fix #277269 Dolphin(Part) Detail/Tree view, highlighted selection paint glitch

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101924/#review4620 --- dolphin/src/views/dolphintreeview.cpp

Re: Review Request: DolphinDetailsView: fix column auto size fail on custom font styles

> On July 11, 2011, 9:38 p.m., Peter Penz wrote: > > Thanks for the patch! It looks good, but it only makes sense to push it to > > the 4.7 branch: For master Dolphin 2.0 will be integrated until beginning > > of August which has a new view-engine that makes this patch obsolete. If > > you pla

Review Request: fix #277269 Dolphin(Part) Detail/Tree view, highlighted selection paint glitch

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101924/ --- Review request for KDE Base Apps, David Faure and Peter Penz. Summary

Re: Review Request: DolphinDetailsView: fix column auto size fail on custom font styles

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101923/#review4618 --- Ship it! Thanks for the patch! It looks good, but it only makes

Review Request: DolphinDetailsView: fix column auto size fail on custom font styles

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101923/ --- Review request for KDE Base Apps, David Faure and Peter Penz. Summary

Review Request: Generate email for docbook authors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101921/ --- Review request for kdelibs, Tom Albers and Luigi Toscano. Summary ---

Re: Review Request: fix for #277372 - dolphin part looses view state on every tab change

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101919/#review4616 --- Ship it! Thanks for the patch, looks good! - Peter On July 1

Review Request: fix for #277372 - dolphin part looses view state on every tab change

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101919/ --- Review request for KDE Base Apps, David Faure and Peter Penz. Summary

Re: moving libkface and libkmap from kdereview to extragear/libs.

There is a libkimap in kdepimlibs. I could see people confusing libkmap with libkimap On Monday, July 11, 2011 01:57:20 pm Gilles Caulier wrote: > Too generic. Ah. I don't know this information. > > Do you remember the thread about ? it's in mailing list or in IRC ? > > Gilles > > 2011/7/11 A

Re: moving libkface and libkmap from kdereview to extragear/libs.

A Monday, July 11, 2011, Gilles Caulier va escriure: > Too generic. Ah. I don't know this information. > Do you remember the thread about ? it's in mailing list or in IRC ? http://lists.kde.org/?l=kde-core-devel&m=129098917515088&w=2 http://lists.kde.org/?l=kde-core-devel&m=129941467832522&w=2 A

Re: moving libkface and libkmap from kdereview to extragear/libs.

Too generic. Ah. I don't know this information. Do you remember the thread about ? it's in mailing list or in IRC ? Gilles 2011/7/11 Albert Astals Cid > A Monday, July 11, 2011, Gilles Caulier va escriure: > > Hi all, > > > > It's possible to move libkface : > > > > https://projects.kde.org/pr

Re: moving libkface and libkmap from kdereview to extragear/libs.

A Monday, July 11, 2011, Gilles Caulier va escriure: > Hi all, > > It's possible to move libkface : > > https://projects.kde.org/projects/kdereview/libkface > > and libkmap : > > https://projects.kde.org/projects/kdereview/libkmap > > from kdereview to extragear/libs (as it have been done for

Re: Review Request: Can't switch back to laptop display when external display gets disconnected

> On Feb. 20, 2011, 3:51 p.m., Lukáš Tinkl wrote: > > Looks OK to me > > Lamarque Souza wrote: > Can this patch be commited to trunk? > > Lamarque Souza wrote: > Ok, I will commit this patch then. Patch submitted. I do not know why but it has not been marked as so. Someone please clos

moving libkface and libkmap from kdereview to extragear/libs.

Hi all, It's possible to move libkface : https://projects.kde.org/projects/kdereview/libkface and libkmap : https://projects.kde.org/projects/kdereview/libkmap from kdereview to extragear/libs (as it have been done for libmediawiki) ? https://projects.kde.org/projects/extragear/libs These li

moving libkface and libkmap from kdereview to extragear/libs.

Hi all, It's possible to move libkface : https://projects.kde.org/projects/kdereview/libkface and libkmap : https://projects.kde.org/projects/kdereview/libkmap from kdereview to extragear/libs (as it have been done for libmediawiki) ? https://projects.kde.org/projects/extragear/libs These li

Re: Review Request: [PATCH] Change HTML thumbnail generator to use kdewebkit to fix bug 248478

On Wed, Jun 15, 2011 at 6:03 AM, Sebastian Kügler wrote: > On Friday, June 03, 2011 20:53:43 Dawit A wrote: >> Do you have any plans for pushing this into git master/KDE 4.6 branch >> ? Either your patch or mine needs to make it into KDE 4.7. > > I'd prefer Dawit's patch, since it will also work w

Review Request: Do not crash because a badly servicetype_profilerc is found

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101914/ --- Review request for kdelibs. Summary --- Should I commit to origin? ac

Re: Review Request: Fix [-Wunused-parameter] compiler warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101881/#review4602 --- This review has been submitted with commit 5e012b55379288f6ead9

Re: Review Request: Changed KUrl::toLocalFile to use QUrl::path() instead QUrl::toLocalFile() on non-Windows platforms

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101906/ --- (Updated July 11, 2011, 4:12 p.m.) Review request for kdelibs and David Fa

Re: Review Request: KRecentDocument support for the K Activity Manager Daemon

> On July 11, 2011, 11:24 a.m., Aaron J. Seigo wrote: > > kio/kfile/krecentdocument.cpp, line 103 > > > > > > should be an asyncCall? > > Ivan Čukić wrote: > yes, we don't need a return value or anything >

Re: Review Request: KRecentDocument support for the K Activity Manager Daemon

> On July 11, 2011, 11:24 a.m., Aaron J. Seigo wrote: > > kio/kfile/krecentdocument.cpp, line 103 > > > > > > should be an asyncCall? > > Ivan Čukić wrote: > yes, we don't need a return value or anything >

Re: Review Request: KRecentDocument support for the K Activity Manager Daemon

> On July 11, 2011, 11:24 a.m., Aaron J. Seigo wrote: > > kio/kfile/krecentdocument.cpp, line 103 > > > > > > should be an asyncCall? yes, we don't need a return value or anything apart from that, can I commit?

Re: Review Request: Changed KUrl::toLocalFile to use QUrl::path() instead QUrl::toLocalFile() on non-Windows platforms

> On July 10, 2011, 1:20 p.m., Ingo Klöcker wrote: > > This changes the behavior of toLocalFile() for non-local URLs. Instead of > > an empty string your version returns the (remote) path. I'm not sure how > > relevant this is because it makes little sense to call toLocalFile() on > > non-loca

Re: Review Request: KRecentDocument support for the K Activity Manager Daemon

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101885/#review4590 --- aside from the blocking nature of the call which is easily fixab