Re: -Wunused-but-set-variable warnings

2011-07-04 Thread Dawit A
On Mon, Jul 4, 2011 at 2:07 PM, Albert Astals Cid wrote: > A Monday, July 04, 2011, Dawit A va escriure: > >> The following files all contain set but unused variables: > >> > >> snip > >> > >> Unlike the -Wunused-parameter fixing this warning messages requires > >> context because the variable may

Re: -Wunused-but-set-variable warnings

2011-07-04 Thread Dawit A
On Mon, Jul 4, 2011 at 5:05 PM, Matthias Fuchs wrote: > Am Montag 04 Juli 2011, 20:07:20 schrieb Albert Astals Cid: >> A Monday, July 04, 2011, Dawit A va escriure: >> > The following files all contain set but unused variables: >> > >> > snip >> > >> > Unlike the -Wunused-parameter fixing this war

Review Request: Konqueror: Ask for session restore ONLY on plain startup (not for every window)

2011-07-04 Thread Marcel Partap
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101850/ --- Review request for KDE Base Apps and David Faure. Summary --- This pa

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-07-04 Thread Marcel Partap
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/ --- (Updated July 4, 2011, 11:29 p.m.) Review request for kdelibs and David Faur

Re: Translation in Qt5

2011-07-04 Thread Chusslove Illich
> [: Oswald Buddenhagen :] > because "everyone" is complaining about the extra contexts, including our > qml team. so there will be change. the question is what is necessary to > compensate it (@tags) and what we can usefully piggy-back on it as we > change anyway. I would be interested at what th

Re: Bug#199209

2011-07-04 Thread Steven Sroka
>On 3 July 2011 18:59, Steven Sroka wrote: > I hate asking this, but can someone with some free time take at look > at #199209? It's bug that affects openSUSE and it's been unassigned > for two years now. *Mental Note* Buy S. Burmeister a keg. > > I'm only asking now because we are in the bug fi

Re: -Wunused-but-set-variable warnings

2011-07-04 Thread Sune Vuorela
On 2011-07-04, Albert Astals Cid wrote: > --Boundary-01=_YFgEOebgzUxkqvf > Content-Type: text/plain; > charset="us-ascii" > Content-Transfer-Encoding: 7bit > > A Monday, July 04, 2011, Dawit A va escriure: >> The following files all contain set but unused variables: >> >> snip >> >> Unlike the

Re: -Wunused-but-set-variable warnings

2011-07-04 Thread Matthias Fuchs
Am Montag 04 Juli 2011, 20:07:20 schrieb Albert Astals Cid: > A Monday, July 04, 2011, Dawit A va escriure: > > The following files all contain set but unused variables: > > > > snip > > > > Unlike the -Wunused-parameter fixing this warning messages requires > > context because the variable may b

Re: -Wunused-but-set-variable warnings

2011-07-04 Thread Albert Astals Cid
A Monday, July 04, 2011, Dawit A va escriure: > The following files all contain set but unused variables: > > snip > > Unlike the -Wunused-parameter fixing this warning messages requires > context because the variable may be set and unused due to a mistake > that can potentially be causing a bug.

Re: -Wunused-but-set-variable warnings

2011-07-04 Thread Michael Pyne
On Monday, July 04, 2011 12:02:47 Dawit A wrote: > The following files all contain set but unused variables: > > kdelibs/kdecore/util/kshareddatacache.cpp:751:14: warning: variable > ‘freedPagesRequired’ set but not used [-Wunused-but-set-variable] Thanks for the heads-up on this one! > Unlike th

Re: Is startkde supposed to set MALLOC_CHECK_=3 on release candidates?

2011-07-04 Thread Michael Pyne
On Sunday, July 03, 2011 15:35:11 Nikos Chantziaras wrote: > Is startkde supposed to set MALLOC_CHECK_=3 on release candidates? It > does for 4.7 RC1 and I wonder is this is intended, since the script > mentions this is for trunk/developer builds. No, it is not supposed to do this. I have removed

Re: Translation in Qt5

2011-07-04 Thread Oswald Buddenhagen
On Mon, Jul 04, 2011 at 04:46:27PM +0200, Chusslove Illich wrote: > > [: Oswald Buddenhagen :] > I don't think there is a clear benefit in unifying KDE and Qt translation > systems. > > _From the point of view of Qt, considering their paying customers, why > change anything in Linguist system? > b

-Wunused-but-set-variable warnings

2011-07-04 Thread Dawit A
The following files all contain set but unused variables: kdelibs/kdecore/io/kar.cpp:109:19: warning: variable ‘uid’ set but not used [-Wunused-but-set-variable] kdelibs/kdecore/io/kar.cpp:109:24: warning: variable ‘gid’ set but not used [-Wunused-but-set-variable] kdelibs/kdecore/util/kshareddat

Re: Translation in Qt5

2011-07-04 Thread Chusslove Illich
> [: Oswald Buddenhagen :] > fwiw, somebody has to actually do the work if anything is supposed to > happen with qt's translation framework, and it doesn't look like any troll > has the capacity. we need to assess what is in kde, what can be directly > reused, what needs a rewrite, and who has time

Re: Review Request: New Kwallet scheme for Khtml user-password form saving (enabling multiple accounts per site)

2011-07-04 Thread todd rme
On Thu, Aug 12, 2010 at 12:34 AM, Michael Leupold wrote: > Oswald Buddenhagen wrote: >> On Tue, Aug 10, 2010 at 04:03:44PM +0200, Martin Sandsmark wrote: >>> On Tue, Aug 10, 2010 at 08:48:03AM +0200, Oswald Buddenhagen wrote: >>> > otoh, konqueror's current behavior is a royal PITA to use.  there