---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101365/
---
(Updated June 22, 2011, 2:08 a.m.)
Review request for KDE Runtime.
Summa
On Tue, Jun 21, 2011 at 2:23 PM, David Faure wrote:
>This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6681/
>
> OK for url() then.
>
> Re the code above, you're probably right, it wasn't tested with
> Ctrl+Shift+Tab, only with Ctrl+Tab.
>
>
>
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101707/#review4064
---
This review has been submitted with commit
b44f3f30f27fb905f0f9
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101707/
---
(Updated June 21, 2011, 7:21 p.m.)
Review request for Build System, kdelib
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/#review10246
---
OK for url() then.
Re the code above, you're probably right, it
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/
---
(Updated June 21, 2011, 4:20 p.m.)
Review request for kdelibs and David Faur
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101707/#review4053
---
Ship it!
Looks right to me. Thanks for fixing.
- Sune
On Jun
There is one particular issue with this patch. When you first start
konqueror, the introduction page is shown with a blank location bar. If you
then simply press escape in location bar, the location bar switches to
"about:konqueror" because that is the url of the current view. Perhaps the
patch nee
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101573/#review4061
---
This review has been submitted with commit
6b5271fa5fa585b6cf35
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101569/#review4060
---
This review has been submitted with commit
ccbf81cef41f16c03586
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101570/#review4059
---
This review has been submitted with commit
034324e01cdb20c7ec7d
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/#review10245
---
Looks good, apart from some details.
/trunk/KDE/kdebase/apps/ko
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101569/#review4057
---
Ship it!
Looks ok.
- David
On June 10, 2011, 7:38 p.m., Matt
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/
---
(Updated June 21, 2011, 11:26 a.m.)
Review request for kdelibs and David Fau
On Tue, Jun 21, 2011 at 9:20 AM, Rolf Eike Beer
wrote:
> Sune Vuorela wrote:
>> diff --git a/templates/lib/abstractlocalizer.cpp
>> b/templates/lib/abstractlocalizer.cpp index 4e5b15d..104d888 100644
>> --- a/templates/lib/abstractlocalizer.cpp
>> +++ b/templates/lib/abstractlocalizer.cpp
>> @@ -4
On 2011-06-21, Rolf Eike Beer wrote:
> So if it is a double you are truncating it to a float (on ARM). I don't know
> if
> that is intentional.
Given the api is taking qreal's, I think it is intentional.
/Sune
Sune Vuorela wrote:
> diff --git a/templates/lib/abstractlocalizer.cpp
> b/templates/lib/abstractlocalizer.cpp index 4e5b15d..104d888 100644
> --- a/templates/lib/abstractlocalizer.cpp
> +++ b/templates/lib/abstractlocalizer.cpp
> @@ -46,8 +46,8 @@ QString AbstractLocalizer::localize( const QVarian
17 matches
Mail list logo
