Re: Request: Inclusion of kio-upnp-ms to kde-runtime KIO slaves

2011-06-02 Thread Friedrich W. H. Kossebau
Hi, (all follow-ups only to kde-core-devel please, copying also amarok-devel this time to get your attention and comments, amarokers) guess you are still heavily occupied by more important things, Nikhil :) Still I think it would be good to have the upnp-ms kio-slave as part of the SC 4.7 rele

Re: Review Request: Update KActionCollection member documentation

2011-06-02 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101494/#review3646 --- Ship it! Looks OK, the new apidox even looks similar to its cou

Re: Request: Inclusion of kio-upnp-ms to kde-runtime KIO slaves

2011-06-02 Thread Nikhil Marathe
On Thu, Jun 2, 2011 at 2:39 PM, Friedrich W. H. Kossebau wrote: > Hi, > > (all follow-ups only to kde-core-devel please, copying also amarok-devel this > time to get your attention and comments, amarokers) > > guess you are still heavily occupied by more important things, Nikhil :) > Still  I thin

Re: Review Request: kcm-grub2

2011-06-02 Thread Raphael Kubo da Costa
Konstantinos Smanis writes: > On Thu, May 26, 2011 at 00:03, Konstantinos Smanis > wrote: >>> The following line should probably be simplified (see >>> http://websvn.kde.org/?revision=1184860&view=revision): >>> >>> src/kcm_grub2.cpp:113:                    QTreeWidgetItem *item = new >>> QTreeW

Creating a public pixmap overlays method based on icon overlays?

2011-06-02 Thread Matthias Fuchs
Hi, I was looking at BUG:190579 [1] and realised that there is a general problem in KDE that does not only apply to folders: As soon as you have preview enabled you won't get any more icon overlays for images, no matter if you look at images directly or at folders containing images (the later m

Review Request: Update KActionCollection member documentation

2011-06-02 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101494/ --- Review request for kdelibs. Summary --- KActionCollection is missing

Re: Review Request: Fix auth warnings when authentication is legitimate

2011-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101493/#review3629 --- This review has been submitted with commit 53730995400665b24be3

Re: Review Request: Fix auth warnings when authentication is legitimate

2011-06-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101493/#review3628 --- Ship it! Good catch. - Dawit On June 2, 2011, 12:03 p.m., Gr

Review Request: Fix auth warnings when authentication is legitimate

2011-06-02 Thread Grégory Oestreicher
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101493/ --- Review request for kdelibs and Dawit Alemayehu. Summary --- Commit 3b

Re: Review Request: Preffer new hunspell library over the old one in the finder

2011-06-02 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101484/#review3626 --- Ship it! HUNSPELL is the only optional dependency that is missi

Review Request: Fix keypress stealing issue

2011-06-02 Thread Thomas Friedrichsmeier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101491/ --- Review request for kdelibs and David Faure. Summary --- Shortcut cont