Review Request: Preffer new hunspell library over the old one in the finder

2011-06-01 Thread Tomáš Chvátal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101484/ --- Review request for kdelibs. Summary --- When using FindHUNSPELL on sy

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-06-01 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/ --- (Updated June 1, 2011, 10:54 a.m.) Review request for KDE Base Apps, KDE R

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-06-01 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/ --- (Updated June 1, 2011, 10:04 a.m.) Review request for KDE Base Apps, KDE R

Re: Review Request: Keeps the selection after showing/hiding hidden files.

2011-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101487/#review3624 --- This review has been submitted with commit 154e601205d0137b02db

Re: Review Request: Keeps the selection after showing/hiding hidden files.

2011-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101487/#review3623 --- This review has been submitted with commit 7993626ee89a7924d55d

Re: Review Request: Keeps the selection after showing/hiding hidden files.

2011-06-01 Thread Matthias Fuchs
> On June 1, 2011, 10:48 p.m., Peter Penz wrote: > > Thanks for the patch. I just had a look and if I don't miss anything it > > should > > be sufficient to just add the line: > > m_selectedItems = selectedItems(); > > to DolphinView::setShowHiddenFiles(). > > > > I'm not really happy with ho

Re: Review Request: Keeps the selection after showing/hiding hidden files.

2011-06-01 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101487/#review3621 --- Thanks for the patch. I just had a look and if I don't miss anyt

Review Request: Keeps the selection after showing/hiding hidden files.

2011-06-01 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101487/ --- Review request for KDE Base Apps, Peter Penz and Frank Reininghaus. Summar

Re: Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

2011-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/#review3620 --- This review has been submitted with commit d44186bce4670d2985fb

Re: Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

2011-06-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/#review3619 --- Ship it! Looks good, thanks. - Christoph On June 1, 2011, 7:

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Olivier Goffart
Le Wednesday 01 June 2011, Dawit A a écrit : > Isn't this problem easily solvable by changing those slots defined in > Q_PRIVATE_SLOT to actual private slots of KIO::Scheduler and > forwarding the call to the existing code ? See attached patch. there could also be a static private schedulerPrivate

Re: QComboBox vs KConfigDialogManager

2011-06-01 Thread Jeremy Whiting
On Tue, May 31, 2011 at 11:13 PM, Aaron J. Seigo wrote: > On Tuesday, May 31, 2011 21:55:59 Jeremy Whiting wrote: > > 1) Check if the widget has a kcfg_property is set on the widget. If so, > use > > that property's value as the property to record. > > 2) Check if the widget has a User property

Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

2011-06-01 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/ --- Review request for kdelibs and Eike Hein. Summary --- QComboBox in qt

Re: Review Request: PATCH: When user selects 'Open With...', show the open with dialog

2011-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101474/#review3618 --- This review has been submitted with commit e36179d6d9a34f2cbfdb

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Dawit A
Isn't this problem easily solvable by changing those slots defined in Q_PRIVATE_SLOT to actual private slots of KIO::Scheduler and forwarding the call to the existing code ? See attached patch. On Wed, Jun 1, 2011 at 10:47 AM, Jeremy Whiting wrote: > Until those that know the code get this issue

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Jeremy Whiting
Until those that know the code get this issue sorted out, I've pasted a small workaround that gets it to build here: http://paste.kde.org/77059/ Jeremy On Wed, Jun 1, 2011 at 2:39 AM, Thiago Macieira wrote: > On Wednesday, 1 de June de 2011 01:42:13 argonel wrote: > > This makes a promise that

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Thiago Macieira
On Wednesday, 1 de June de 2011 01:42:13 argonel wrote: > This makes a promise that any class can use a private slot without > access checking. It doesn't say how that slot was declared, just that > the private slot can be invoked by any other class. The change to > Q_PRIVATE_SLOT introduces access

Re: Review Request: kcm-grub2

2011-06-01 Thread Konstantinos Smanis
On Thu, May 26, 2011 at 00:03, Konstantinos Smanis wrote: >> The following line should probably be simplified (see >> http://websvn.kde.org/?revision=1184860&view=revision): >> >> src/kcm_grub2.cpp:113:                    QTreeWidgetItem *item = new >> QTreeWidgetItem(ui.treeWidget_recover, QStrin

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-06-01 Thread Jeffery MacEachern
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101348/ --- (Updated June 1, 2011, 6:07 a.m.) Review request for kdelibs, Ivan Čukić,