Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-05-31 Thread argonel
On Mon, Apr 25, 2011 at 6:54 PM, Olivier Goffart wrote: > In this case, we have to see if we can fix it in Qt. I do not see any solution > on top of my head. We have to discuss if it is ok to break this use case if > there is no solution. The Qt documentation, about signals and slots[1] says thi

Re: QComboBox vs KConfigDialogManager

2011-05-31 Thread Aaron J. Seigo
On Tuesday, May 31, 2011 21:55:59 Jeremy Whiting wrote: > 1) Check if the widget has a kcfg_property is set on the widget. If so, use > that property's value as the property to record. > 2) Check if the widget has a User property to save (This was not set in > QComboBox in 4.7 but is set in 4.8 to

QComboBox vs KConfigDialogManager

2011-05-31 Thread Jeremy Whiting
Hey all, I wanted to document the source of a bug I just found the cause of and get some input on possible fixes. The bug I noticed was that using qt 4.8 konversation stopped showing timestamps in the chat window. After discussing with Eike I realized the TimestampFormat in my konversationrc was

Re: Review Request: PATCH: Honor size and coordinates when creating new Konqueror windows

2011-05-31 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101477/ --- (Updated June 1, 2011, 3:33 a.m.) Review request for KDE Base Apps and Dav

Re: Review Request: Disallow names of files containing '/' or being equal to "." or "..".

2011-05-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101456/#review3609 --- This review has been submitted with commit 465ec0c76958657cdb75

Re: Review Request: Disallow names of files containing '/' or being equal to "." or "..".

2011-05-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101456/#review3608 --- This review has been submitted with commit def6e86db16246e12660

Re: Review Request: Disallows renaming to names containing '/' names being equal to "." or "..".

2011-05-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101454/#review3607 --- This review has been submitted with commit 680b8f918900b2b8b99f

Re: Review Request: Disallows renaming to names containing '/' names being equal to "." or "..".

2011-05-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101454/#review3606 --- This review has been submitted with commit d034afc892e21a0b8fd9

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-05-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101348/#review3605 --- Note that I can't really comment on the activities specific part

Re: regarding kde's plugin mechanism

2011-05-31 Thread Aaron J. Seigo
On Tuesday, May 31, 2011 19:31:19 tushar mehta wrote: > Do we have any document or reference for understanding kde's plugin > mechanism? what aspect of the plugin system are you curious about? there is api documentation and i believe some tutorials on techbase. but if you have slightly more spe

regarding kde's plugin mechanism

2011-05-31 Thread tushar mehta
Do we have any document or reference for understanding kde's plugin mechanism? I need to understand how custom transferfactory and custom transfer-objects (derived from the transfer-class) related to each plugin works. any sample code, text anything will be helpful for me. thank you.

Re: Klipper

2011-05-31 Thread Aaron J. Seigo
On Tuesday, May 31, 2011 19:38:20 Lubos Lunak wrote: > separate process, what is the gain of the UI separation (this is not a > rhetoric question)? so that we can easily change the UI, have multiple UIs, combine it with other features in future .. all without touching the business logic code, whi

Re: Review Request: make the add search engine window right aligned to the search bar

2011-05-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101475/#review3603 --- This review has been submitted with commit 7fd2209d8c110c9fb08d

Re: Review Request: make the add search engine window right aligned to the search bar

2011-05-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101475/#review3602 --- This review has been submitted with commit 658bff15e373602425fa

Review Request: PATCH: Honor size and coordinates when creating new Konqueror windows

2011-05-31 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101477/ --- Review request for KDE Base Apps and David Faure. Summary --- Current

Re: Klipper

2011-05-31 Thread Lubos Lunak
On Tuesday 31 of May 2011, Esben Mose Hansen wrote: > On 2011-05-16 18:35, todd rme wrote: > > Would that make klipper a potential target for the upcoming > > modularization efforts, then? > > As a pseudo-sometime maintainer of Klipper, I have thought about this > extensively. So this is my take on

Re: Review Request: [PATCH] Change HTML thumbnail generator to use kdewebkit to fix bug 248478

2011-05-31 Thread Dawit A
Maksim, Did you push this commit ? I guess this is from your own local commit because I do not see the change after an update. Anyhow, please include BUG: 252818 when you decide to push this fix. I have withdrawn my review request since this is a much smaller change and quicker fix. On Sat, May

Re: Klipper

2011-05-31 Thread Aaron J. Seigo
On Tuesday, May 31, 2011 11:58:42 Esben Mose Hansen wrote: > Now, since we are discussing this, I can put my question to the crowd: > Does this sound like a dataengine with two plasmoids to you? Or should > it be a service that communicates over dbus? i think the division of labour as you outlined

Re: Klipper

2011-05-31 Thread Esben Mose Hansen
On 2011-05-16 18:35, todd rme wrote: Would that make klipper a potential target for the upcoming modularization efforts, then? As a pseudo-sometime maintainer of Klipper, I have thought about this extensively. So this is my take on it. Klipper should be modularized like this: 1. The core b

Re: Klipper

2011-05-31 Thread Esben Mose Hansen
On 2011-05-16 18:35, todd rme wrote: Would that make klipper a potential target for the upcoming modularization efforts, then? As a pseudo-sometime maintainer of Klipper, I have thought about this extensively. So this is my take on it. Klipper should be modularized like this: 1. The core b