Re: Review Request: make the add search engine window right aligned to the search bar

2011-05-30 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101475/#review3599 --- Ship it! Would that not simply make the reverse true, i.e. the

Review Request: make the add search engine window right aligned to the search bar

2011-05-30 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101475/ --- Review request for KDE Base Apps, Dawit Alemayehu and David Faure. Summary

Review Request: PATCH: When user selects 'Open With...', show the open with dialog

2011-05-30 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101474/ --- Review request for KDE Base Apps and David Faure. Summary --- The att

Review Request: Enable per event icons in KNotify

2011-05-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101470/ --- Review request for KDE Runtime and Plasma. Summary --- This patch ena

Re: Review Request: Disallow names of files containing '/' or being equal to "." or "..".

2011-05-30 Thread Richard J. Moore
> On May 28, 2011, 9:29 a.m., David Faure wrote: > > The handling of '/' could use KIO::encodeFileName instead, for consistency. > > I agree about "." and ".." though ;) > > Mark Gaiser wrote: > I wonder.. don't we need a "isFilename" function that checks if a > filename meets all the char

Re: Review Request: make folderview icons translucent if composite is enabled

2011-05-30 Thread Mathias Stephan Panzenböck
> On May 29, 2011, 1:05 p.m., Thomas Lübking wrote: > > Not sure wheher it's really worth it (though using ARGB over XShape might > > actually bring better performance) but I assume the style (oxygen) can deal > > this more efficiently (via polishment) and also globally (not only for the > > f

Re: Review Request: make folderview icons translucent if composite is enabled

2011-05-30 Thread Thomas Lübking
> On May 29, 2011, 1:05 p.m., Thomas Lübking wrote: > > Not sure wheher it's really worth it (though using ARGB over XShape might > > actually bring better performance) but I assume the style (oxygen) can deal > > this more efficiently (via polishment) and also globally (not only for the > > f

Re: Review Request: make folderview icons translucent if composite is enabled

2011-05-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101463/#review3574 --- Not sure wheher it's really worth it (though using ARGB over XSh