Re: Review Request: Disallow names of files containing '/' or being equal to "." or "..".

2011-05-29 Thread Matthias Fuchs
> On May 28, 2011, 9:29 a.m., David Faure wrote: > > The handling of '/' could use KIO::encodeFileName instead, for consistency. > > I agree about "." and ".." though ;) > > Mark Gaiser wrote: > I wonder.. don't we need a "isFilename" function that checks if a > filename meets all the char

Re: Review Request: Disallow names of files containing '/' or being equal to "." or "..".

2011-05-29 Thread Mark Gaiser
> On May 28, 2011, 9:29 a.m., David Faure wrote: > > The handling of '/' could use KIO::encodeFileName instead, for consistency. > > I agree about "." and ".." though ;) > > Mark Gaiser wrote: > I wonder.. don't we need a "isFilename" function that checks if a > filename meets all the char

Re: Review Request: Set the main window on KDirLister created in DolphinView::ViewAccessor

2011-05-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101469/#review3584 --- This review has been submitted with commit f5568a8eefb94b5df1d3

Re: Review Request: Enable per event icons in KNotify

2011-05-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101470/#review3583 --- Ship it! great; backwards compatible, and forwards looking. com

Re: Review Request: Set the main window on KDirLister created in DolphinView::ViewAccessor

2011-05-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101469/#review3581 --- This review has been submitted with commit 24e79c009b1530b54919

Re: Review Request: Set the main window on KDirLister created in DolphinView::ViewAccessor

2011-05-29 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101469/#review3580 --- Ship it! Thanks for the patch, looks good! - Peter On May 29

Re: Review Request: make folderview icons translucent if composite is enabled

2011-05-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101463/#review3579 --- this patch is a total hack. while the idea of using argb for the

Review Request: Set the main window on KDirLister created in DolphinView::ViewAccessor

2011-05-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101469/ --- Review request for KDE Base Apps and Peter Penz. Summary --- The atta

Review Request: make folderview icons translucent if composite is enabled

2011-05-29 Thread Mathias Stephan Panzenböck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101463/ --- Review request for KDE Base Apps. Summary --- This patch makes dragge