Re: Review Request: Disallows renaming to names containing '/' names being equal to "." or "..".

2011-05-27 Thread Matthias Fuchs
> On May 27, 2011, 11:33 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 8dbc4b0752dc12121c37000c764a7e025daae4b7 by Matthias Fuchs. The review request for the changes in KDirModel and KFileItemDelegate can be found here: https://git.reviewboard.kde.org/r/101456/

Re: Review Request: Disallows renaming to names containing '/' names being equal to "." or "..".

2011-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101454/#review3559 --- This review has been submitted with commit 8dbc4b0752dc12121c37

Re: Review Request: Disallows renaming to names containing '/' names being equal to "." or "..".

2011-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101454/#review3558 --- This review has been submitted with commit 79ccd0202d106a9c16b7

Review Request: Disallow names of files containing '/' or being equal to "." or "..".

2011-05-27 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101456/ --- Review request for kdelibs and David Faure. Summary --- nt This add

Re: Review Request: DolphinColumnView navigation works more intuitively.

2011-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101449/#review3557 --- This review has been submitted with commit 30011f6985c2945b0d9c

Re: Review Request: DolphinColumnView navigation works more intuitively.

2011-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101449/#review3556 --- This review has been submitted with commit 7e6fd6fba45eed056070

Re: Review Request: Disallows renaming to names containing '/' names being equal to "." or "..".

2011-05-27 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101454/ --- (Updated May 27, 2011, 11:07 p.m.) Review request for KDE Base Apps and Pe

Review Request: Jar archives also uses the zip protocol.

2011-05-27 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101455/ --- Review request for KDE Runtime and David Faure. Summary --- nt This

Re: Review Request:

2011-05-27 Thread Peter Penz
> On May 27, 2011, 10:43 p.m., Frank Reininghaus wrote: > > If "Rename Inline" is enabled, DolphinView::renameSelectedItems() calls > > m_viewAccessor.itemView()->edit(proxyIndex), which then opens the editor in > > KFileItemDelegate. When the editing is done, > > KFileItemDelegate::setModelDa

Re: Review Request:

2011-05-27 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101454/#review3554 --- Thanks for the patch! > I could not find the method that change

Re: Review Request:

2011-05-27 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101454/#review3553 --- If "Rename Inline" is enabled, DolphinView::renameSelectedItems(

Review Request:

2011-05-27 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101454/ --- Review request for KDE Base Apps and Peter Penz. Summary --- So far t

Notification of master mirror move

2011-05-27 Thread Ben Cooksley
Hi all, The upload point for adding files to KDE's mirror network has now changed to a new server. Whilst DNS changes propagate, you may find that you cannot access upload.kde.org. @Packagers: you now access the new server via @ftpmaster.kde.org. Your username has not changed from the one you had

Re: Review Request: [PATCH] Change HTML thumbnail generator to use kdewebkit to fix bug 248478

2011-05-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101365/ --- (Updated May 27, 2011, 9:57 p.m.) Review request for KDE Runtime. Summar

Re: Review Request: DolphinColumnView navigation works more intuitively.

2011-05-27 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101449/#review3551 --- Ship it! Thanks for the patch! Looks good, please push it to ma

Re: Review Request: DolphinColumnView navigation works more intuitively.

2011-05-27 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101449/#review3550 --- dolphin/src/views/dolphincolumnview.cpp

Review Request: DolphinColumnView navigation works more intuitively.

2011-05-27 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101449/ --- Review request for KDE Base Apps and Peter Penz. Summary --- If no it

Re: Review Request: make QTEST_KDEMAIN_CORE_WITH_COMPONENTNAME compile with -DQT_NO_CAST_FROM_ASCII

2011-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101444/#review3548 --- This review has been submitted with commit cbbbc79a5df68f3a43e5

Re: Review Request: make QTEST_KDEMAIN_CORE_WITH_COMPONENTNAME compile with -DQT_NO_CAST_FROM_ASCII

2011-05-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101444/#review3545 --- Ship it! looks good. - Aaron J. On May 26, 2011, 10:01 p.m.,

Re: Command line options stripped for KUniqueApplication

2011-05-27 Thread Aaron J. Seigo
On Thursday, May 26, 2011 21:10:07 Urban Widmark wrote: > The kde (and qt, kuniqueapp) command line options are stripped when > using the KUniqueApplication class (saveAppArgs()/loadAppArgs()). I > believe a KApplication never has them removed. > > Some options are useful for an application to rec

Re: KMainWindow::parseGeometry()

2011-05-27 Thread Aaron J. Seigo
On Thursday, May 26, 2011 20:53:46 Urban Widmark wrote: > Posting here to get some feedback. If it looks ok (or you are all too it looks ok; two small comments: * updatesizeonly -> updateSizeOnly * patches should be submitted, if possible, via git.reviewboard.kde.org which improves the patch re

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-05-27 Thread Lukas Sommer
> On May 25, 2011, 10:19 a.m., Christoph Feck wrote: > > The big problem with this patch is that the user interface only offers a > > ComboBox with two fixed values. What does the interface show when you > > modified the value to, say, 200 dpi? Well, the user interface offers three different v

KMainWindow::parseGeometry()

2011-05-27 Thread Urban Widmark
Hello, Two fixes to KMainWindow::parseGeometry(). The method takes a parameter, parsewidth, which if set makes it *only* update the size of the window. Otherwise it only updates the position. That makes no sense, an X geometry can be both position and size. This patch changes what the flag does s

Command line options stripped for KUniqueApplication

2011-05-27 Thread Urban Widmark
The kde (and qt, kuniqueapp) command line options are stripped when using the KUniqueApplication class (saveAppArgs()/loadAppArgs()). I believe a KApplication never has them removed. Some options are useful for an application to receive, even if it already has an initial window. I am looking at th