Re: Review Request: kcm-grub2

2011-05-24 Thread Alexander Potashev
2011/5/25 Konstantinos Smanis : > Any updates? The two week review period is over. The following line should probably be simplified (see http://websvn.kde.org/?revision=1184860&view=revision): src/kcm_grub2.cpp:113:QTreeWidgetItem *item = new QTreeWidgetItem(ui.treeWidget_reco

Re: Proposal: DBus activation of Accessibility

2011-05-24 Thread 陈翔宇
Kubuntu 11.04 langurage can't change to chinese . 2011/5/18 UndiFineD : > Currently in Ubuntu Natty 11.04, Dbus in compiz does not work perfectly. > might be better in Ubuntu Classic. > > 2011/5/17 Matthias Clasen : >> On Mon, May 16, 2011 at 5:29 PM, Frederik Gladhorn wrote: >>> Hi, >>> sorry fo

Re: Review Request: kcm-grub2

2011-05-24 Thread Konstantinos Smanis
On Thu, May 12, 2011 at 01:48, Konstantinos Smanis wrote: > On Tue, May 10, 2011 at 07:33, Ben Cooksley wrote: >> On Tue, May 10, 2011 at 9:36 AM, Christoph Feck wrote: >>> On Monday 09 May 2011 19:34:04 Konstantinos Smanis wrote: I think kcm-grub2 has reached a pleasant level of maturity a

Kamoso in extragear/multimedia

2011-05-24 Thread Aleix Pol
Hi! Alex and I, we have been working lately on the Kamoso port to QtGstreamer, which has brought us a lot of stability, until the point that we are happy enough to leave playground. After a lot of discussion about where do we thing Kamoso should go, we have decided that we want to put it in extrag

Re: Review Request: Ignores dots at the beginning of a file name when suggesting a file name

2011-05-24 Thread Matthias Fuchs
> On May 24, 2011, 6:08 p.m., Commit Hook wrote: > > This review has been submitted with commit > > ac6790ebf207c566b14a9041974d60df7741d415 by Matthias Fuchs. Also commited it to master f2a6626f9fc1a5ed07d7115ef79d05273d8522b7 - Matthias ---

Re: Review Request: Ignores dots at the beginning of a file name when suggesting a file name

2011-05-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101429/#review3488 --- This review has been submitted with commit ac6790ebf207c566b14a

Re: Review Request: Display the tab title on root (/) folder properly in konqueror filemanager mode

2011-05-24 Thread Matthias Fuchs
> On May 24, 2011, 5:59 p.m., Commit Hook wrote: > > This review has been submitted with commit > > f2a6626f9fc1a5ed07d7115ef79d05273d8522b7 by Matthias Fuchs. Sorry copied this review id by mistake, my commit is for 101429 so ignore it. - Matthias --

Re: Review Request: Display the tab title on root (/) folder properly in konqueror filemanager mode

2011-05-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101374/#review3486 --- This review has been submitted with commit f2a6626f9fc1a5ed07d7

Re: Review Request: a very little fix

2011-05-24 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101433/#review3485 --- kdecore/config/kconfigdata.h

Re: Review Request: Display the tab title on root (/) folder properly in konqueror filemanager mode

2011-05-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101374/#review3483 --- This review has been submitted with commit 52941af13c1d0fa59bbd

Re: Review Request: Display the tab title on root (/) folder properly in konqueror filemanager mode

2011-05-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101374/#review3482 --- This review has been submitted with commit 2867851d31718a9b6820

Review Request: a very little fix

2011-05-24 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101433/ --- Review request for kdelibs. Summary --- corrected to the right variab

Re: Review Request: Display the tab title on root (/) folder properly in konqueror filemanager mode

2011-05-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101374/#review3481 --- Ship it! Looks good to me. - Dawit On May 23, 2011, 8:31 p.m

Re: Review Request: Ignores dots at the beginning of a file name when suggesting a file name

2011-05-24 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101429/#review3480 --- Ship it! one way to do it :) - Aaron J. On May 24, 2011, 10:

Review Request: The tooltip's tag are mismatch on krandrtray

2011-05-24 Thread Max Lin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/ --- Review request for KDE Base Apps. Summary --- After launch krandrtray

Re: BC question about derived private classes

2011-05-24 Thread Thiago Macieira
On Tuesday, 24 de May de 2011 13:46:59 John Layt wrote: > I'm now marking a number of the base class virtual methods as deprecated, > so I'm getting lots of warnings on the derived classes where they simply > pass the call to the base class, so I'm thinking of simply deleting these > reimplemement

BC question about derived private classes

2011-05-24 Thread John Layt
Hi, KCalendarSystem is a public class with many virtual methods which are reimplemented in derived classes such as KCalendarSystemGregorian. The derived classes are not exported or part of the api, only KCalendarSystem is exposed, but the derived classes are created and returned in a static fa

Re: Review Request: Ignores dots at the beginning of a file name when suggesting a file name

2011-05-24 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101429/ --- (Updated May 24, 2011, 10:55 a.m.) Review request for kdelibs and David Fa

Re: Review Request: Ignores dots at the beginning of a file name when suggesting a file name

2011-05-24 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101429/#review3473 --- kio/kio/renamedialog.cpp