Re: kdewebkit compilation fails for Mobile profile in trunk

2011-05-22 Thread Kevin Ottens
On Sunday 22 May 2011 10:51:39 Matthias Fuchs wrote: > Am Sonntag 22 Mai 2011, 00:26:58 schrieb Dawit A: > > On Sat, May 21, 2011 at 5:50 PM, Andreas Pakulat wrote: > > > On 21.05.11 13:25:32, Dawit A wrote: > > >> No that is a moc issue. The code is properly @ifdef'ed out in the > > >> code, but

Re: Review Request: Better documentation for KConfigDialog::addPage()

2011-05-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101409/#review3453 --- This review has been submitted with commit 6379152334a4857f8dde

Re: Review Request: Better documentation for KConfigDialog::addPage()

2011-05-22 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101409/ --- (Updated May 21, 2011, 11:03 a.m.) Review request for kdelibs. Changes -

Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-05-22 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/ --- Review request for KDE Base Apps, KDE Runtime and kdelibs. Summary ---

Re: Review Request: Better documentation for KConfigDialog::addPage()

2011-05-22 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101409/#review3438 --- Okay. Could someone with commit rights apply this patch, please

Re: Request: Inclusion of kio-upnp-ms to kde-runtime KIO slaves

2011-05-22 Thread Friedrich W. H. Kossebau
Hi Nikhil, Jeudi, le 12. mai 2011, à 01:38, Nikhil Marathe a écrit: > On Wed, May 11, 2011 at 4:04 PM, Friedrich W. H. Kossebau > > wrote: > > Hi Nikhil, > > > > you know that today, April 12th, is already Hard Feature Freeze?! Would > > be really sad if your upnp-ms kio-slave misses the deadli

Re: kdewebkit compilation fails for Mobile profile in trunk

2011-05-22 Thread Matthias Fuchs
Am Sonntag 22 Mai 2011, 00:26:58 schrieb Dawit A: > On Sat, May 21, 2011 at 5:50 PM, Andreas Pakulat wrote: > > On 21.05.11 13:25:32, Dawit A wrote: > >> No that is a moc issue. The code is properly @ifdef'ed out in the > >> code, but the generated moc file does not seem to exclude it. That is > >