Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

> On May 8, 2011, 9:03 p.m., Michael Pyne wrote: > > kfile/knameandurlinputdialog.cpp, line 67 > > > > > > It is inappropriate to create QWidgets that have no parent, unless you > > have a different means of ensurin

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

> On May 8, 2011, 9:03 p.m., Michael Pyne wrote: > > kfile/knameandurlinputdialog.cpp, line 67 > > > > > > It is inappropriate to create QWidgets that have no parent, unless you > > have a different means of ensurin

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3210 --- It looks like you introduce a memory leak, although that's easy

Re: Changing the defaults for HTTP ACCEPT, ACCEPT-LANGUAGE and USERAGENT headers

On Sun, May 8, 2011 at 3:56 PM, Maksim Orlovich wrote: > 1) Does this actually fix anything? Did you do any testing? Well the idea behind it is to have a default string that is as close to what the other browsers are sending as possible in order to avoid getting a different results. You can see t

Re: Changing the defaults for HTTP ACCEPT, ACCEPT-LANGUAGE and USERAGENT headers

1) Does this actually fix anything? Did you do any testing? 2) 'like Gecko' was added by Apple guys for a very good reason (UA sniffing) 3) It would be incorrect to add xhtml accepts to khtml's accept-type. XHTML parsing is buggy, and isn't really worth prioritizing fixing (on accounts on basically

Re: svn -> git transition status ?

On Sunday 08 May 2011 12:52:30 todd rme wrote: > On Sun, May 8, 2011 at 12:44 PM, Raphael Kubo da Costa wrote: > > Alexander Neundorf writes: > > > > The rest of the modules are at an unknown/early/inexistent migration > > state. > > Weren't there issues with kdeartwork and GIT because of the

Changing the defaults for HTTP ACCEPT, ACCEPT-LANGUAGE and USERAGENT headers

In hopes of making Konqueror's default settings for the aforementioned HTTP headers inline with other browsers, I want to change the default settings for these three header as outlined below. ** Please note that this only affects the default! Each and every application can tell the ioslave what to

Re: Review Request: Fix timer leak in KWalletD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101313/#review3209 --- Ship it! Seems reasonable to me. - Dawit On May 8, 2011, 3:0

Re: svn -> git transition status ?

On Sun, May 8, 2011 at 6:52 PM, todd rme wrote: > Weren't there issues with kdeartwork and GIT because of the large > number of binary files (like wallpapers)? The same (still unresolved) issues are with kdegames, which has 400 MB of history just for data files (which make up 80% of a 100 MB SVN

Re: svn -> git transition status ?

On 5/8/11, Raphael Kubo da Costa wrote: > kdeutils: The conversion rules are pretty much finished, PovAddict and I > just need some free time to double-check everything (we're more cautious > than ever after the kdeedu problems). > > kdeaccessibility: IIRC, kdeaccessibility is in a similar state,

Re: svn -> git transition status ?

On Sun, May 8, 2011 at 12:44 PM, Raphael Kubo da Costa wrote: > Alexander Neundorf writes: > > The rest of the modules are at an unknown/early/inexistent migration > state. > Weren't there issues with kdeartwork and GIT because of the large number of binary files (like wallpapers)? -Todd

Re: svn -> git transition status ?

Alexander Neundorf writes: > what's the current status with our svn to git transition ? > There are still several modules in svn (kdeaccessibility, kdeadmin, > kdeartwork, kdebindings, kdegames, kdegraphics, kdemultimedia, kdenetwork, > kdesdk, kdetoys, kdeutils, kdewebdev). kdeutils: The conv

svn -> git transition status ?

Hi, what's the current status with our svn to git transition ? There are still several modules in svn (kdeaccessibility, kdeadmin, kdeartwork, kdebindings, kdegames, kdegraphics, kdemultimedia, kdenetwork, kdesdk, kdetoys, kdeutils, kdewebdev). Is it planned to move them also to git ? Is somebo

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/ --- (Updated May 8, 2011, 3:42 p.m.) Review request for kdelibs. Changes ---

Review Request: Fix KAuth::Action::execute() not returning error description string

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101314/ --- Review request for kdelibs and Dario Freddi. Summary --- KAuth::Actio

Review Request: Fix timer leak in KWalletD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101313/ --- Review request for KDE Runtime and Michael Leupold. Summary --- KWall

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3200 --- Adding some before and after screenshots would probably get you

Re: Top 15 Mailinglists with messages in moderation May 1st

Am Samstag, 7. Mai 2011, 17:47:28 schrieb Anne-Marie Mahfouf: > On Sunday 01 May 2011 16:00:57 Tom Albers wrote: > > Hi, > > > > New month, new list. If lists are unused, let me know, I will delete > > them. If someone wants to help with moderation for any of these list, > > let me know as well. >

Re: Review Request: KMessageWidget: Adapt height to text changes

> On May 2, 2011, 5:49 p.m., Aurélien Gâteau wrote: > > Thanks for the patch Mattias! This is indeed an annoying bug but your fix > > does not work when the widget is resized. heightForWidth() needs to be > > implemented I think. The problem is that resizing takes no effect yet either. Here wi