Re: Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-05-02 Thread Dawit Alemayehu
> On May 2, 2011, 8:26 p.m., Dawit Alemayehu wrote: > > Instead of doing all that, please rename the local static function in > > accessmanagerreply_p.cpp to "isLocalResource(...)" and be done with it. > > Nicolas Alvarez wrote: > So the one checking for scheme=="data" should remain isLocal

Re: Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-05-02 Thread Nicolas Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/ --- (Updated May 2, 2011, 9:34 p.m.) Review request for kdelibs. Changes ---

Re: Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-05-02 Thread Nicolas Alvarez
> On May 2, 2011, 8:26 p.m., Dawit Alemayehu wrote: > > Instead of doing all that, please rename the local static function in > > accessmanagerreply_p.cpp to "isLocalResource(...)" and be done with it. So the one checking for scheme=="data" should remain isLocalRequest, and the one not checkin

Re: Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-05-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/#review3076 --- Instead of doing all that, please rename the local static functi

Re: Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-05-02 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/#review3075 --- Looks ok I think. Alex - Alexander On May 2, 2011, 7:26 p.m

Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-05-02 Thread Nicolas Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/ --- Review request for kdelibs. Summary --- kdelibs compilation is broken

Re: Review Request: KMessageWidget: Adapt height to text changes

2011-05-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101272/#review3074 --- kdeui/widgets/kmessagewidget.cpp

Re: Season of KDE project on speed optimization

2011-05-02 Thread David Edmundson
On Mon, May 2, 2011 at 1:39 PM, Sebastian Kügler wrote: > > On Friday, April 29, 2011 14:55:01 Markus Slopianka wrote: > > Am Freitag 29 April 2011, 12:52:18 schrieb Lydia Pintscher: > > > Aaditya applied for a Season of KDE slot. He wants to work on speed > > > optimization. Do we have a nice pro

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

2011-05-02 Thread Hugo Pereira Da Costa
> On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: > > Hello Aurelien, > > > > Though I have nothing to say against the current design of your kmessagebox > > widget, something I miss in your implementation is the possibility for a > > widget style to override/replace your rendering.

Re: Chinese Lunar Calendar Support in Kdelibs

2011-05-02 Thread John Layt
On Thursday 28 Apr 2011 09:57:18 Liang Qi wrote: > Yes, I just browsed the web page for GSOC 2011 last night and found > that calendar project in KDE, then searched this mailing list and > found this talk. > > But I can't find out more details about "adding astronomical calendars > to KDE" project

Re: Review kdelibs whiting/fixQByteArrays

2011-05-02 Thread Olivier Goffart
Le Monday 02 May 2011, David Faure a écrit : > Another one: > > - envs << QString::fromLatin1( QByteArray("DISPLAY=") + dpystring ); > +envs << QString::fromLatin1( QByteArray(QByteArray("DISPLAY=") + > dpystring) ); Should be QLatin1String("DISPLAY=") + QLatin1String(dpystring) (Assum

Re: Review Request: KMessageWidget: Adapt height to text changes

2011-05-02 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101272/#review3071 --- Thanks for the patch Mattias! This is indeed an annoying bug but

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

2011-05-02 Thread Aurélien Gâteau
> On May 1, 2011, 10:17 a.m., Hugo Pereira Da Costa wrote: > > Also, I wanted to add that Gtk already has a widget similar to your idea, > > called GtkInfoBar, and which is rendered by oxygen-gtk like in the > > screenshot below: > > > > http://simplest-image-hosting.net/jpg-0-plasma-desktopou

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

2011-05-02 Thread Aurélien Gâteau
> On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: > > Hello Aurelien, > > > > Though I have nothing to say against the current design of your kmessagebox > > widget, something I miss in your implementation is the possibility for a > > widget style to override/replace your rendering.

Re: QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Thiago Macieira
Em Monday, 2 de May de 2011, às 16:55:50, Hugo Pereira Da Costa escreveu: > The access should be safe though, since if the handle returned is > invalid, then a native X11 pixmap is created directly, instead of > re-using existing QPixmap. Yes, the access is safe, but the access causes the warning.

Re: QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Thiago Macieira
Em Monday, 2 de May de 2011, às 16:39:23, Hugo Pereira Da Costa escreveu: > What's the widget style you are using ? > > > I remember a recent discussion in #qt-labs about this, and I think it > > has > > already been fixed in Qt 4.8 branch. > > > > The issue, if I understood the discussion correctl

Re: QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Hugo Pereira Da Costa
Le 05/02/2011 04:47 PM, Wolfgang Rohdewald a écrit : On Montag 02 Mai 2011, Hugo Pereira Da Costa wrote: Le 05/02/2011 04:33 PM, Christoph Feck a écrit : On Monday 02 May 2011 16:15:42 Wolfgang Rohdewald wrote: since updating to kubuntu 11.04 I am getting this message while KApplication is cre

Re: QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Wolfgang Rohdewald
On Montag 02 Mai 2011, Hugo Pereira Da Costa wrote: > Le 05/02/2011 04:33 PM, Christoph Feck a écrit : > > On Monday 02 May 2011 16:15:42 Wolfgang Rohdewald wrote: > >> since updating to kubuntu 11.04 I am getting this message > >> while KApplication is created, but only if I use raster or > >> ope

Re: QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Wolfgang Rohdewald
On Montag 02 Mai 2011, Christoph Feck wrote: > On the other hand, I am highly interested why kpat tries to > use X11 pixmaps at all. Adding kde-games-devel. well - it already happens when constructing KApplication and you can get it with about all apps, I also tried okular and konqueror. -- Wol

Re: QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Thiago Macieira
Em Monday, 2 de May de 2011, às 16:15:42, Wolfgang Rohdewald escreveu: > since updating to kubuntu 11.04 I am getting this message > while KApplication is created, but only if I use raster or opengl > as graphics system: > > kpat --graphicssystem raster > QPixmap::handle(): Pixmap is not an X11 cla

Re: QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Hugo Pereira Da Costa
Le 05/02/2011 04:33 PM, Christoph Feck a écrit : On Monday 02 May 2011 16:15:42 Wolfgang Rohdewald wrote: since updating to kubuntu 11.04 I am getting this message while KApplication is created, but only if I use raster or opengl as graphics system: kpat --graphicssystem raster QPixmap::handle(

Re: QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Christoph Feck
On Monday 02 May 2011 16:15:42 Wolfgang Rohdewald wrote: > since updating to kubuntu 11.04 I am getting this message > while KApplication is created, but only if I use raster or opengl > as graphics system: > > kpat --graphicssystem raster > QPixmap::handle(): Pixmap is not an X11 class pixmap >

QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Wolfgang Rohdewald
since updating to kubuntu 11.04 I am getting this message while KApplication is created, but only if I use raster or opengl as graphics system: kpat --graphicssystem raster QPixmap::handle(): Pixmap is not an X11 class pixmap this seems to happen with all KDE programs. Any idea? kdelibs 4.6.2 q

Re: Review kdelibs whiting/fixQByteArrays

2011-05-02 Thread Thiago Macieira
Em Monday, 2 de May de 2011, às 14:59:02, David Faure escreveu: > +[...] XInternAtom( disp, QByteArray( QByteArray( msg_type_P ) + "_BEGIN" ) > ); > > Ah it's because XInternAtom takes a const char*, so in theory this should > even be QByteArray( QByteArray( msg_type_P ) + "_BEGIN" ).constData()

Re: saving/restoring session in kded module

2011-05-02 Thread David Faure
On Friday 29 April 2011, Andriy Rysin wrote: > Well saving layouts is most useful if the switcher is in > "per-application" mode (I guess even more when in "per window" but hat > mode currently can't save layouts as it uses wid for the key which is > transient). If you restore your session (and thu

Re: Review kdelibs whiting/fixQByteArrays

2011-05-02 Thread David Faure
On Sunday 01 May 2011, Olivier Goffart wrote: > Le Saturday 30 April 2011, David Faure a écrit : > > On Friday 29 April 2011, Jeremy Whiting wrote: > > > Since David added QT_USE_FAST_OPERATOR_PLUS to our build rules for > > > kdelibs, it wont build here. > > > > Oops? > > > > > I've got a commit

Re: Season of KDE project on speed optimization

2011-05-02 Thread Sebastian Kügler
On Friday, April 29, 2011 14:55:01 Markus Slopianka wrote: > Am Freitag 29 April 2011, 12:52:18 schrieb Lydia Pintscher: > > Aaditya applied for a Season of KDE slot. He wants to work on speed > > optimization. Do we have a nice project for him? > > Depends what he finds slow. > A possibility woul

Review Request: KMessageWidget: Adapt height to text changes

2011-05-02 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101272/ --- Review request for kdelibs and Aurélien Gâteau. Summary --- When ther