Re: Replacement for Qt's Undo Framework

2011-04-27 Thread Olivier Goffart
Le Tuesday 26 April 2011, Albert Astals Cid a écrit : > A Dimarts, 26 d'abril de 2011, Olivier Goffart va escriure: > > > What do you think about inclusion of KUndo*2 into kdelibs? > > > > I have not seen the details about KUndo2 yet, but what are the reasons > > that keep you from improving QUnd

Re: GeoClue dependencies

2011-04-27 Thread Kevin Krammer
On Thursday, 2011-04-28, John Layt wrote: > Hi, > > There's been a short discussion on the GeoClue mailing list related to > resolving the issues we have around their dependencies on gconf and > gsettings > > and the latest response has been: > > The GConf dependency is already gone. And I wouldn

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
> On April 27, 2011, 11:42 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 367 > > > > > > Sorry, I still have a question. > > > > After a username change, setHost is going to be called, right? So i

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/#review2935 --- kioslave/ftp/ftp.cpp

Review Request: Fix for a couple of KIO put-slave-on-hold bugs

2011-04-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101244/ --- Review request for kdelibs. Summary --- The attached patch address a

Re: GeoClue dependencies

2011-04-27 Thread Thiago Macieira
On Wednesday, 27 de April de 2011 23:16:32 John Layt wrote: > Hi, > > There's been a short discussion on the GeoClue mailing list related to > resolving the issues we have around their dependencies on gconf and > gsettings > > and the latest response has been: > > The GConf dependency is already

GeoClue dependencies

2011-04-27 Thread John Layt
Hi, There's been a short discussion on the GeoClue mailing list related to resolving the issues we have around their dependencies on gconf and gsettings and the latest response has been: > The GConf dependency is already gone. And I wouldn't take a patch to > remove the GSettings dependency. Th

Re: Chinese Lunar Calendar Support in Kdelibs

2011-04-27 Thread John Layt
On Wednesday 27 Apr 2011 21:27:37 Liang Qi wrote: > Hi, John and Feng Huang, > > It's glad to see the interests on this "old" topic. > > Sorry, I forgot to update the info about relicense of ccal(at least > part for chinese calendar date calculate). My change is in > http://code.google.com/p/kcal

Re: Empty merges per release

2011-04-27 Thread John Layt
On Wednesday 27 Apr 2011 19:59:05 Alexander Neundorf wrote: > I mean, I can help with simple things. > > If we agree that the following pages should be gone > http://techbase.kde.org/Development/Tutorials/Git > http://techbase.kde.org/Development/Tutorials/Git/Pushing > http://techbase.kde.org/Dev

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/ --- (Updated April 27, 2011, 9:27 p.m.) Review request for kdelibs and David F

Re: Review Request: Using KWallet to store Cookies

2011-04-27 Thread Ingo Klöcker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101241/#review2929 --- No review of your patch. Rather a question about it's usefulness

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
> On April 27, 2011, 7:58 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 605 > > > > > > Oh, I thought we could remove the boolean altogether. > > > > I don't really understand the way the patch wo

Re: Chinese Lunar Calendar Support in Kdelibs

2011-04-27 Thread Liang Qi
Hi, John and Feng Huang, It's glad to see the interests on this "old" topic. Sorry, I forgot to update the info about relicense of ccal(at least part for chinese calendar date calculate). My change is in http://code.google.com/p/kcalendar/source/browse/trunk/README Yes, I also updated the link f

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/#review2926 --- kioslave/ftp/ftp.cpp

Re: Empty merges per release

2011-04-27 Thread Alexander Neundorf
On Wednesday 27 April 2011, John Layt wrote: > On Wednesday 27 Apr 2011 17:52:32 Alexander Neundorf wrote: > > On Wednesday 27 April 2011, Thiago Macieira wrote: > > > I know we decided to use cherry-picks to bring commits from past > > > versions to master, > > > > Is this what is described here ?

Re: Review Request: Allow KWidgetItemDelegate::createItemWidgets to know what index corresponds to the widgets

2011-04-27 Thread Rafael Fernández López
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101219/#review2924 --- Ship it! That's a no brainer. Please, ship it. As a side note:

Re: Empty merges per release

2011-04-27 Thread John Layt
On Wednesday 27 Apr 2011 17:52:32 Alexander Neundorf wrote: > On Wednesday 27 April 2011, Thiago Macieira wrote: > > I know we decided to use cherry-picks to bring commits from past versions > > to master, > > Is this what is described here ? > http://techbase.kde.org/Development/Tutorials/Git/Rec

Re: Empty merges per release

2011-04-27 Thread Alexander Neundorf
On Wednesday 27 April 2011, Thiago Macieira wrote: > I know we decided to use cherry-picks to bring commits from past versions > to master, Is this what is described here ? http://techbase.kde.org/Development/Tutorials/Git/Recipes Our git docs are still not in good shape: http://techbase.kde.o

Re: Empty merges per release

2011-04-27 Thread Oswald Buddenhagen
On Wed, Apr 27, 2011 at 12:17:48PM -, Tom Albers wrote: > - Original Message - > > (oh well, who cares, given all that scripty crap in the history) > > I consider our translations very important for KDE. Would be nice if > people -in general- do not consider translations and the contri

Re: Empty merges per release

2011-04-27 Thread Tom Albers
- Original Message - > (oh well, who > cares, > given all that scripty crap in the history) I consider our translations very important for KDE. Would be nice if people -in general- do not consider translations and the contributors working on that as second class community members. Callin

Re: Empty merges per release

2011-04-27 Thread Thiago Macieira
Em Wednesday, 27 de April de 2011, às 12:46:40, Oswald Buddenhagen escreveu: > if you want to make that git feature useful in the kde-ish cherry-pick > regime, tag the stable branch points - if you want to know when a commit > on a stable branch hit master, you need the extra step of following the

Re: Empty merges per release

2011-04-27 Thread Oswald Buddenhagen
On Wed, Apr 27, 2011 at 09:40:08AM +0200, Thiago Macieira wrote: > I know we decided to use cherry-picks to bring commits from past versions to > master, but this has caused that the 4.5 and 4.6 commits are never in the > past > history of master. > which is the state we had with svn. it was co

Re: [Kde-scm-interest] Re: libtagaro -> kdereview [-> kdegames]

2011-04-27 Thread Stefan Majewsky
On Fri, Apr 22, 2011 at 3:39 PM, Torgny Nyblom wrote: > +1 a module is a unit and should be treated as such even if the different apps > are in different gits. So should I move the code to SVN then? This discussion was on kde-games-devel already, and the mass figured it's quite stupid to move cod

Re: Review Request: First part of fixes for password caching in KIO: SlaveBase::openPaswordDialog

2011-04-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101174/#review2915 --- This review has been submitted with commit 03f949d61bb556a34de1

Empty merges per release

2011-04-27 Thread Thiago Macieira
I know we decided to use cherry-picks to bring commits from past versions to master, but this has caused that the 4.5 and 4.6 commits are never in the past history of master. I recommend at least once, after a release, that the tag is merged back into master, using strategy "ours" if necessary.

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/ --- (Updated April 27, 2011, 7:28 a.m.) Review request for kdelibs and David F