Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-24 Thread Michael Pyne
On Sunday, April 24, 2011 16:42:22 Christoph Feck wrote: > On Sunday 24 April 2011 15:04:38 Thiago Macieira wrote: > > Olivier, these are your moc changes. > > Given that Q_PRIVATE_SLOT is a private definition, shouldn't we rather fix > the code in KDE? Perhaps, but let's let the developers makin

Re: Review Request: Show "Version Fixed In" if available, for reports marked as FIXED

2011-04-24 Thread Darío Andrés Rodríguez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101200/#review2849 --- Just remembered there was another patch: https://bugs.kde.org/s

Review Request: Explain a little more why DrKonqi require some amount of characters/information

2011-04-24 Thread Darío Andrés Rodríguez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101203/ --- Review request for KDE Runtime and George Kiagiadakis. Summary --- Ad

Review Request: Show "Version Fixed In" if available, for reports marked as FIXED

2011-04-24 Thread Darío Andrés Rodríguez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101200/ --- Review request for KDE Runtime and George Kiagiadakis. Summary --- Us

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-24 Thread Christoph Feck
On Sunday 24 April 2011 15:04:38 Thiago Macieira wrote: > On Sunday, 24 de April de 2011 12:53:18 Christoph Feck wrote: > > Hi, > > > > Qt 4.8 has been branched, and (early as I am :) I tried compiling KDE > > with it. It already fails compiling kdelibs/kio/kio/scheduler.cpp > > because of this er

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-24 Thread Thiago Macieira
On Sunday, 24 de April de 2011 12:53:18 Christoph Feck wrote: > Hi, > > Qt 4.8 has been branched, and (early as I am :) I tried compiling KDE with > it. It already fails compiling kdelibs/kio/kio/scheduler.cpp because of > this error: > > /local/build/KDE/libs/kdelibs/kio/scheduler.moc:77:21: error

kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-24 Thread Christoph Feck
Hi, Qt 4.8 has been branched, and (early as I am :) I tried compiling KDE with it. It already fails compiling kdelibs/kio/kio/scheduler.cpp because of this error: /local/build/KDE/libs/kdelibs/kio/scheduler.moc:77:21: error: ‘class KIO::Scheduler’ has no member named ‘schedulerPrivate’ The is

Review Request: Allow KWidgetItemDelegate::createItemWidgets to know what index corresponds to the widgets

2011-04-24 Thread Eli MacKenzie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101219/ --- Review request for kdelibs and Rafael Fernández López. Summary --- Id