Review Request: Do not preserve username information on redirection in KIO

2011-04-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101153/ --- Review request for kdelibs. Summary --- This patch completely removes

Re: Review Request: Using KWallet to store Cookies

2011-04-18 Thread Dawit A
Would you be able to create a new request in git.reviewboard.kde.org for this so that it won't fall through the cracks ? Perhaps there is still a chance for this making the KDE 4.7 release. The only reservation I have is the ability to unit test things when cookies are stored in the kwallet. Have y

Re: kwin crashes short after start

2011-04-18 Thread Thomas Lübking
Am 19.04.2011, 04:14 Uhr, schrieb Gary Greene : Please don't, re blacklisting. I actually have a working VMware Fusion with full Compositing, and would be very unhappy to have to go back to a non-composited desktop. (No crash here, using an ATI Radeon HD 2400 on the host system.) Includin

Re: kwin crashes short after start

2011-04-18 Thread Gary Greene
On 18 Apr 2011, at 1:31 PM, Thomas Lübking wrote: > Am 18.04.2011, 21:57 Uhr, schrieb Ingo Klöcker : >> This was meant as a workaround. And, of course, you can edit kwinrc (or >> whatever rc file) without having a desktop. > > given the comments in bug #271166 this is > a) on vmware (they cheat

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread Dawit Alemayehu
> On April 18, 2011, 10:38 p.m., David Faure wrote: > > Looks ok now. Let's hope it works, too :-) In terms of sending the mime-type it definitely works and is an essential part of the fix to make put-ftp-ioslave-on-hold happen. However, putting ftp ioslaves on hold still will not work for mo

Re: Review Request: fix wrong file extension for kmplot

2011-04-18 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101059/#review2740 --- Ship it! I guess some typo when in created kde.xml (more than 4

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/#review2739 --- Ship it! Looks ok now. Let's hope it works, too :-) - David

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/ --- (Updated April 18, 2011, 10:29 p.m.) Review request for kdelibs and David

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread Dawit Alemayehu
> On April 18, 2011, 8:31 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2405 > > > > > > If m_size is UnknownSize and the file is less than 1024 bytes, this > > code is going to hit the timeout, waiting

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
> On April 18, 2011, 8:31 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2405 > > > > > > If m_size is UnknownSize and the file is less than 1024 bytes, this > > code is going to hit the timeout, waiting

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread Dawit Alemayehu
> On April 18, 2011, 8:31 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2405 > > > > > > If m_size is UnknownSize and the file is less than 1024 bytes, this > > code is going to hit the timeout, waiting

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/ --- (Updated April 18, 2011, 9:28 p.m.) Review request for kdelibs and David F

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
> On April 18, 2011, 8:31 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2405 > > > > > > If m_size is UnknownSize and the file is less than 1024 bytes, this > > code is going to hit the timeout, waiting

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread Dawit Alemayehu
> On April 18, 2011, 8:31 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2405 > > > > > > If m_size is UnknownSize and the file is less than 1024 bytes, this > > code is going to hit the timeout, waiting

Re: kwin crashes short after start

2011-04-18 Thread Thomas Lübking
Am 18.04.2011, 21:57 Uhr, schrieb Ingo Klöcker : This was meant as a workaround. And, of course, you can edit kwinrc (or whatever rc file) without having a desktop. given the comments in bug #271166 this is a) on vmware (they cheat a "gallium" driver) b) only on first login to a fresh new accou

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/#review2733 --- kioslave/ftp/ftp.cpp

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/ --- (Updated April 18, 2011, 8:12 p.m.) Review request for kdelibs and David F

Re: kwin crashes short after start

2011-04-18 Thread Ingo Klöcker
On Monday 18 April 2011, Guy Maurel wrote: > Hello! > > On Saturday, April 16, 2011 08:17:10 PM Ingo Klöcker wrote: > > On Saturday 16 April 2011, Guy Maurel wrote: > > > Hello! > > > > > > With a new account, after loging, I get everytime a crash at: > > > ... > > > #7 0x7f38b20627f1 in KWi

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/#review2732 --- kioslave/ftp/ftp.cpp

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/ --- (Updated April 18, 2011, 7:39 p.m.) Review request for kdelibs and David F

Kcmgrub2

2011-04-18 Thread Alberto Mattea
Hi, kcmgrub2 has been under review for two weeks now. I've done all the suggested changes. Would it be possible to move it to kdemain/sysadmin or (if that's not possible) to extragear/sysadmin? Thanks Alberto

Re: kwin crashes short after start

2011-04-18 Thread Guy Maurel
Hello! On Saturday, April 16, 2011 08:17:10 PM Ingo Klöcker wrote: > On Saturday 16 April 2011, Guy Maurel wrote: > > Hello! > > > > With a new account, after loging, I get everytime a crash at: > > ... > > #7 0x7f38b20627f1 in KWin::GLShader::load (this=0x1e4e520, > > vertexSource=..., fragm

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
> On April 18, 2011, 12:43 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 1766 > > > > > > Maybe this should be "while we haven't read 1024 bytes", but of course > > the file could be smaller than that so

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread Dawit Alemayehu
> On April 18, 2011, 12:43 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 1766 > > > > > > Maybe this should be "while we haven't read 1024 bytes", but of course > > the file could be smaller than that so

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/#review2723 --- Ship it! Thanks. kioslave/ftp/ftp.cpp

Re: Please, return removed Konqueror feature bug (embedded advanced text editor) in KDE 4.6

2011-04-18 Thread Vladimir Koković
On Sat, 16 Apr 2011 12:00:20 +0200, Dominik Haumann wrote: On Saturday, 16. April 2011, David Faure wrote: On Friday 15 April 2011, Vladimir Koković wrote: > HI, > > Please, return removed Konqueror feature bug (embedded advanced text > editor) in KDE 4.6 !!! Wrong list, and wrong request. W