Re: Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-14 Thread Maksim Orlovich
Ah, I misread the default. But still, I don't think we want to send DNT:0 if the user unchecks the checkbox, given how the label is worded -- IMHO we wouldn't want to send the header at all. On 4/14/11, Dawit Alemayehu wrote: > > --- > This

Re: [Kde-games-devel] Re: Move Tagaro code into SVN?

2011-04-14 Thread Stefan Majewsky
On Wed, Apr 13, 2011 at 11:47 PM, Parker Coates wrote: > If it means adding a new library for distributions to package, I think > it has to go through kdereview, even if it does so with a "this is not > a stable API" disclaimer. It's a relatively big change, so I think > third parties (packagers,

Re: Window switch notification for plasma applets

2011-04-14 Thread Andriy Rysin
Well, the keyboard daemon which stores layout per window map has no knowledge about indicator applets right now and I would like to keep it this way. Also second approach does not allow to store layout per applet. So I'll play with QGraphicsScene::focusItem() to see if it's not too ugly. Thanks

Re: Review Request: fix broken nepomuk ui files to make messages translatable

2011-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/#review2647 --- This review has been submitted with commit d76640d967057e93f277

Re: Review Request: fix broken nepomuk ui files to make messages translatable

2011-04-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/#review2648 --- This review has been submitted with commit 398f4964691e76f8d60e

Re: Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-14 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101124/ --- (Updated April 14, 2011, 5:08 p.m.) Review request for kdelibs. Changes

Re: Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-14 Thread Dawit A
On Thu, Apr 14, 2011 at 12:42 PM, Maksim Orlovich wrote: > Very cool. But re: original change. Are you sure we want to be sending > the opt-in header by default? No. We are sending the opt-out header by default. The "DNT: 1" which will be sent, when the "DoNotTrack" is set to "true" (the default)

Re: Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-14 Thread Maksim Orlovich
Very cool. But re: original change. Are you sure we want to be sending the opt-in header by default? (Also, does KProtocolManager copy kioslaverc into the metadata or something, or will that need a separate change?). Can't really review this right now, but one thing that I noticed: // Read the con

Re: Window switch notification for plasma applets

2011-04-14 Thread Aaron J. Seigo
On Wednesday, April 13, 2011 20:31:01 Andriy Rysin wrote: > well as per top-level windows. So the question is whether there's a way to > tell "active/focused" applet and get notified on switch? ah, and getting the current view() for the Applet or even checking the PID (since the switcher could be

Re: Window switch notification for plasma applets

2011-04-14 Thread Aaron J. Seigo
On Wednesday, April 13, 2011 20:31:01 Andriy Rysin wrote: > So the question is whether there's a way to > tell "active/focused" applet and get notified on switch? not currently; well, at least not easily :) QGraphicsScene does provide QGraphicsItem * QGraphicsScene::focusItem(), and you could de

Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-14 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101124/ --- Review request for kdelibs. Summary --- The attach patch adds GUI con

Re: Review Request: fix broken nepomuk ui files to make messages translatable

2011-04-14 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/#review2626 --- Ship it! Looks fine to me. I simply used the designer field tha