Re: KLocalizedString regression

2011-03-25 Thread John Tapsell
On 25 March 2011 21:42, Chusslove Illich wrote: >> [: John Tapsell :] >> Except that in my case, I'm forcing this on the users of my API. Just to >> get around this! >> >> Can't you see how crazy this is? > > An integer is mandatory to decide the plural form, a float cannot be used, > due to the f

Re: KLocalizedString regression

2011-03-25 Thread Chusslove Illich
> [: John Tapsell :] > Except that in my case, I'm forcing this on the users of my API. Just to > get around this! > > Can't you see how crazy this is? An integer is mandatory to decide the plural form, a float cannot be used, due to the following. Suppose there are m plural forms for a given lang

Re: Review Request: Move the KPasswordDialog "Anonymous" checkbox below the input boxes...

2011-03-25 Thread John Layt
> On March 22, 2011, 6:23 p.m., John Layt wrote: > > My thoughts are if the anonymous tickbox is first focus it should be above > > the username/password fields and the username/password fields should be > > disabled if anonymous is selected. But that may look a little weird with > > the text

Re: Review Request: Move the KPasswordDialog "Anonymous" checkbox below the input boxes...

2011-03-25 Thread Ingo Klöcker
> On March 22, 2011, 6:23 p.m., John Layt wrote: > > My thoughts are if the anonymous tickbox is first focus it should be above > > the username/password fields and the username/password fields should be > > disabled if anonymous is selected. But that may look a little weird with > > the text

Re: Review Request: Move the KPasswordDialog "Anonymous" checkbox below the input boxes...

2011-03-25 Thread John Layt
> On March 22, 2011, 6:23 p.m., John Layt wrote: > > My thoughts are if the anonymous tickbox is first focus it should be above > > the username/password fields and the username/password fields should be > > disabled if anonymous is selected. But that may look a little weird with > > the text

Re: Review Request: KDateEdit moving into kdelibs

2011-03-25 Thread Torgny Nyblom
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6014/#review10017 --- Closing as it seems abandoned and involved repos are in git now.

Re: KLocalizedString regression

2011-03-25 Thread Thiago Macieira
Em sexta-feira, 25 de março de 2011, às 15:17:33, John Tapsell escreveu: > The graph would show "1 second" "2 seconds" "3 seconds" on the > axis in this case. IMHO it should show: 1 s 2 s 3 s -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Senior

Re: KLocalizedString regression

2011-03-25 Thread John Tapsell
On 25 March 2011 15:06, Thiago Macieira wrote: > Em sexta-feira, 25 de março de 2011, às 14:39:22, John Tapsell escreveu: >> I have a widget, KSignalPlotter, which plots data points. >> >> The usage is: >> >> KSignalPlotter plotter; >> plotter.setUnit( ki18ncp("Units", "%1 second", "%1 seconds") )

Re: KLocalizedString regression

2011-03-25 Thread Thiago Macieira
Em sexta-feira, 25 de março de 2011, às 14:39:22, John Tapsell escreveu: > I have a widget, KSignalPlotter, which plots data points. > > The usage is: > > KSignalPlotter plotter; > plotter.setUnit( ki18ncp("Units", "%1 second", "%1 seconds") ); > plotter.addBeam(Qt::red); > plotter.addSample( QList

Re: KLocalizedString regression

2011-03-25 Thread John Tapsell
On 25 March 2011 14:20, Thiago Macieira wrote: > Em sexta-feira, 25 de março de 2011, às 13:59:11, John Tapsell escreveu: >> > Well, yes. Two grammar-wise different text fragments (enumerable vs. >> > measurable quantities) are being used in alternation, so each should be >> > represented by its o

Re: KLocalizedString regression

2011-03-25 Thread John Tapsell
On 25 March 2011 13:59, John Tapsell wrote: > On 25 March 2011 13:19, Chusslove Illich wrote: >>> [: John Tapsell :] >>> If the number is small, I want to show "2 seconds" but if it's large I >>> want like "2.2e4" seconds. >>> >>> You're saying that my API needs to require the user to now pass *t

Re: KLocalizedString regression

2011-03-25 Thread Thiago Macieira
Em sexta-feira, 25 de março de 2011, às 13:59:11, John Tapsell escreveu: > > Well, yes. Two grammar-wise different text fragments (enumerable vs. > > measurable quantities) are being used in alternation, so each should be > > represented by its own string. The author of KUnitConversion wanted the >

Re: KLocalizedString regression

2011-03-25 Thread John Tapsell
On 25 March 2011 13:19, Chusslove Illich wrote: >> [: John Tapsell :] >> If the number is small, I want to show "2 seconds" but if it's large I >> want like "2.2e4" seconds. >> >> You're saying that my API needs to require the user to now pass *two* >> strings for that? > > Well, yes. Two grammar-

Re: Review Request: Move the KPasswordDialog "Anonymous" checkbox below the input boxes...

2011-03-25 Thread Thomas Lübking
> On March 22, 2011, 6:23 p.m., John Layt wrote: > > My thoughts are if the anonymous tickbox is first focus it should be above > > the username/password fields and the username/password fields should be > > disabled if anonymous is selected. But that may look a little weird with > > the text

Re: KLocalizedString regression

2011-03-25 Thread Chusslove Illich
> [: John Tapsell :] > If the number is small, I want to show "2 seconds" but if it's large I > want like "2.2e4" seconds. > > You're saying that my API needs to require the user to now pass *two* > strings for that? Well, yes. Two grammar-wise different text fragments (enumerable vs. measurable q

Re: KLocalizedString regression

2011-03-25 Thread John Tapsell
On 25 March 2011 12:45, Chusslove Illich wrote: >> [: John Tapsel :] >>   ki18ncp("Units", "%1 second", "%1 seconds").subs(1.1, 0, 'f', 1).toString() >> >> used to work (return "1.1 seconds") but now it returns ("1.1 >> seconds(I18N_PLURAL_ARGUMENT_MISSING)") which screws up my graphing >> widget.

Re: KLocalizedString regression

2011-03-25 Thread Chusslove Illich
> [: John Tapsel :] > ki18ncp("Units", "%1 second", "%1 seconds").subs(1.1, 0, 'f', 1).toString() > > used to work (return "1.1 seconds") but now it returns ("1.1 > seconds(I18N_PLURAL_ARGUMENT_MISSING)") which screws up my graphing > widget. This is the way it (should have) always worked. The p

KLocalizedString regression

2011-03-25 Thread John Tapsell
Hi all, ki18ncp("Units", "%1 second", "%1 seconds").subs(1.1, 0, 'f', 1).toString() used to work (return "1.1 seconds") but now it returns ("1.1 seconds(I18N_PLURAL_ARGUMENT_MISSING)") which screws up my graphing widget. This causes my unit tests to fail. Can someone fix this pretty please?

Re: Review Request: Move the KPasswordDialog "Anonymous" checkbox below the input boxes...

2011-03-25 Thread Thomas Lübking
> On March 22, 2011, 6:23 p.m., John Layt wrote: > > My thoughts are if the anonymous tickbox is first focus it should be above > > the username/password fields and the username/password fields should be > > disabled if anonymous is selected. But that may look a little weird with > > the text