Re: Review Request: Move the KPasswordDialog "Anonymous" checkbox below the input boxes...

2011-03-24 Thread Dawit Alemayehu
> On March 22, 2011, 6:23 p.m., John Layt wrote: > > My thoughts are if the anonymous tickbox is first focus it should be above > > the username/password fields and the username/password fields should be > > disabled if anonymous is selected. But that may look a little weird with > > the text

Review Request: PATCH: FTP handle files that start or stop with whitespaces

2011-03-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100943/ --- Review request for kdelibs. Summary --- The attach patch is a fix for

Re: Review Request: PATCH: Emit finished signal after calling ftpCloseCommand in Ftp::copy and friends

2011-03-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100941/ --- (Updated March 24, 2011, 6:19 p.m.) Review request for kdelibs. Summary

Review Request: Emit the finished signal after calling ftpCloseCommand in Ftp::copy and friends

2011-03-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100941/ --- Review request for kdelibs. Summary --- The attached patch fixes the

Re: Review Request: Move the KPasswordDialog "Anonymous" checkbox below the input boxes...

2011-03-24 Thread Aurélien Gâteau
> On March 22, 2011, 6:23 p.m., John Layt wrote: > > My thoughts are if the anonymous tickbox is first focus it should be above > > the username/password fields and the username/password fields should be > > disabled if anonymous is selected. But that may look a little weird with > > the text

Re: Review Request: Adding Ångström to KUnitConversion

2011-03-24 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100923/#review2136 --- Ship it! - Petri On March 23, 2011, 8:32 p.m., Etienne Rebete