Re: Review Request: Patch for "FTP ioslave unnecessarily asks for password"

2011-03-19 Thread Dawit Alemayehu
> On March 18, 2011, 11:22 p.m., David Faure wrote: > > Hmm, this whole block is inside "if (failedAuth>0)", so this means kio_ftp > > tried to log in, but without using the cached credentials? > > Ah, probably because it tries anonymous first. Which kind of sucks on sites > > where you have re

Re: Review Request: Fix handling of FTP urls whose path name ends with a type code

2011-03-19 Thread Andreas Hartmetz
On Friday 18 March 2011 20:58:52 David Faure wrote: > On Wednesday 16 March 2011, Thiago Macieira wrote: > > Suggestion: > > path.left(path.length() - sizeof ";type="); > > Unreadable. > > > sizeof(";type=") == strlen(";type=X") > > A hidden off-by-one, how nice to have in our co

Re: KSambaShare destructor proposed patch

2011-03-19 Thread Rodrigo Belém
On Sat, Mar 19, 2011 at 8:51 AM, Fabrice Ménard wrote: > Le vendredi 18 mars 2011 20:55:52 David Faure a écrit : >> Looks good, please commit -- if you don't have a kde svn/git account yet, >> please get one, your patches are good ;) > Thanks > > I don't have an account  yet. I will commit to you

Re: KSambaShare destructor proposed patch

2011-03-19 Thread Fabrice Ménard
Le vendredi 18 mars 2011 20:55:52 David Faure a écrit : > Looks good, please commit -- if you don't have a kde svn/git account yet, > please get one, your patches are good ;) Thanks I don't have an account yet. Before I get one, I'll have to study thoroughly techbase.kde and try to better unders

Introducing libmediawiki

2011-03-19 Thread Alexandre Mendes
Hello, We worked on a library, "libmediawiki", to interface the MediaWiki API with Qt, which is a part of the project silk. Also we have produce two new widgets and a kipi plugin to export images to commons.wikimedia.org. They use our library . We think our work can interest some kde developpers a