Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Dawit A
On Wed, Mar 9, 2011 at 6:32 PM, Andreas Hartmetz wrote: > On Wednesday 09 March 2011 23:43:23 Dawit A wrote: [snipped] >> Yes, it is, but not for those reasons. That entry was not put there >> simply because we had an HTTP proxy implementation, but because FTP >> requests can be routed through an

Re: Review Request: Dolphin details view optimization

2011-03-09 Thread Samuel Rødal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100826/ --- (Updated March 9, 2011, 11:38 p.m.) Review request for KDE Base Apps. Ch

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Andreas Hartmetz
On Wednesday 09 March 2011 23:43:23 Dawit A wrote: > On Wed, Mar 9, 2011 at 2:53 PM, Andreas Hartmetz wrote: > > On Wednesday 09 March 2011 20:06:40 Dawit A wrote: > >> On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: > >> > On Wednesday 09 March 2011, Dawit Alemayehu wrote: > >> >> proxiedBy

Re: Review Request: Dolphin details view optimization

2011-03-09 Thread Samuel Rødal
> On March 9, 2011, 10:40 p.m., Christoph Feck wrote: > > Does it handle color changes made by the user? > > Milian Wolff wrote: > it won't. > > @Samuel: connecting to this signal (and recomputing the color) should > help with this > http://api.kde.org/4.x-api/kdelibs-apidocs/kdeu

Re: Review Request: Dolphin details view optimization

2011-03-09 Thread Milian Wolff
> On March 9, 2011, 10:40 p.m., Christoph Feck wrote: > > Does it handle color changes made by the user? it won't. @Samuel: connecting to this signal (and recomputing the color) should help with this http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKGlobalSettings.html#a4a8de991c8e2

Re: need to backport patch in kinit/kinit_win.cpp to 4.6

2011-03-09 Thread Patrick Spendrin
Am 09.03.2011 22:26, schrieb Wolfgang Rohdewald: > Hi, > > > when compiling kdelibs 4.6 on Windows, I get an > > error in kinit_win.cpp at line 110 (I am afraid I deleted it) > > > but the commit in kdelibs below obviously fixes it. So I > > want to backport it to kdelibs. > > > Would that

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Dawit A
On Wed, Mar 9, 2011 at 2:53 PM, Andreas Hartmetz wrote: > On Wednesday 09 March 2011 20:06:40 Dawit A wrote: >> On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: >> > On Wednesday 09 March 2011, Dawit Alemayehu wrote: >> >> proxiedBy always returns true since ftp.protocol no longer contains a >

Re: Review Request: Dolphin details view optimization

2011-03-09 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100826/#review1870 --- Does it handle color changes made by the user? - Christoph On

Review Request: Dolphin details view optimization

2011-03-09 Thread Samuel Rødal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100826/ --- Review request for KDE Base Apps. Summary --- Constructing a KColorSc

need to backport patch in kinit/kinit_win.cpp to 4.6

2011-03-09 Thread Wolfgang Rohdewald
Hi, when compiling kdelibs 4.6 on Windows, I get an error in kinit_win.cpp at line 110 (I am afraid I deleted it) but the commit in kdelibs below obviously fixes it. So I want to backport it to kdelibs. Would that be OK, and how would I do it? Like this: git checkout --track origin/KDE/4.6 git

Re: QZeitgeist and Phonon

2011-03-09 Thread Alexander Neundorf
On Tuesday 08 March 2011, John Layt wrote: > On Monday 07 March 2011 23:58:08 Trever Fischer wrote: > > Very recently, we introduced an optional build time dependency on > > QZeitgeist. Today, someone said I should mention this to k-c-d. So here > > goes: > > That was me, I was just concerned we we

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Andreas Hartmetz
On Wednesday 09 March 2011 20:06:40 Dawit A wrote: > On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: > > On Wednesday 09 March 2011, Dawit Alemayehu wrote: > >> proxiedBy always returns true since ftp.protocol no longer contains a > >> "ProxiedBy=" entry. > > > > Yes it does, of course. But t

Re: Future of KSysguard - removing remote monitoring

2011-03-09 Thread David Naylor
On Wednesday 09 March 2011 01:26:46 Alberto Villa wrote: > On Tuesday 08 March 2011 15:15:33 John Tapsell wrote: > > So unless anyone can talk me out of it now, I am going to remove the > > > > ability to monitor remote hosts entirely, and to use one of the many > > excellent cross-platform debu

Re: Future of KSysguard - removing remote monitoring

2011-03-09 Thread Alberto Villa
On Tuesday 08 March 2011 15:15:33 John Tapsell wrote: > So unless anyone can talk me out of it now, I am going to remove the > ability to monitor remote hosts entirely, and to use one of the many > excellent cross-platform debugged libraries that already exist to > gather system information. is

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Dawit A
On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: > On Wednesday 09 March 2011, Dawit Alemayehu wrote: >> proxiedBy always returns true since ftp.protocol no longer contains a >> "ProxiedBy=" entry. > > Yes it does, of course. But the point of the additional if() is to not go into > that code bl

Re: Future of KSysguard - removing remote monitoring

2011-03-09 Thread Aaron J. Seigo
On Wednesday, March 9, 2011, John Tapsell wrote: > Thanks for the feedback - this is why I put out such emails before I btw, in case it isn't abundantly clear: thanks for working on ksysguard, there are many of us out there who really appreciate your efforts :) -- Aaron J. Seigo humru othro a k

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread David Faure
On Wednesday 09 March 2011, Dawit Alemayehu wrote: > proxiedBy always returns true since ftp.protocol no longer contains a > "ProxiedBy=" entry. Yes it does, of course. But the point of the additional if() is to not go into that code block for other procotols, like HTTP, FISH, and so on. > Anyho

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Dawit Alemayehu
> On March 7, 2011, 6:26 p.m., David Faure wrote: > > kparts/browserrun.cpp, line 124 > > > > > > For speed reasons, we could do the proxy-determination (which is what > > slaveProtocol does) only for protocols (su

Re: Future of KSysguard - removing remote monitoring

2011-03-09 Thread John Tapsell
Thanks for the feedback - this is why I put out such emails before I make any changes. It's good to know that people actually use this app - sometimes it's hard to know if anyone actually uses it. I'll hold off on any rash changes for now. Thanks! John

Re: Future of KSysguard - removing remote monitoring

2011-03-09 Thread Andreas Hartmetz
On Wednesday 09 March 2011 15:00:27 Aaron J. Seigo wrote: > On Tuesday, March 8, 2011, John Tapsell wrote: > > So unless anyone can talk me out of it now, I am going to remove the > > > > ability to monitor remote hosts entirely > > imho: > > instead of eviscerating the application of the prim

Re: Future of KSysguard - removing remote monitoring

2011-03-09 Thread Aaron J. Seigo
On Tuesday, March 8, 2011, John Tapsell wrote: > So unless anyone can talk me out of it now, I am going to remove the > ability to monitor remote hosts entirely imho: instead of eviscerating the application of the primary feature that makes it useful to a significant group of users of that app

Re: Re: Future of KSysguard - removing remote monitoring

2011-03-09 Thread Harald Sitter
On Wed, Mar 9, 2011 at 12:55 AM, Alex Fiestas wrote: > Keep this feature as a plugin or something would be awesome, I've used this > feature in the past and it was very helpful. Yeah, surely not one the most important feature but *very* helpful if one stumbles upon a use case :D (actually I am