Re: Review Request: Fix KWidgetItemeDelegate to correctly update widget positions when a row gets removed

2011-01-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6401/#review9714 --- Sounds mostly good, I'm just wondering why you keep calling the up

Re: i18n infrastructure for Grantlee templates

2011-01-24 Thread Stephen Kelly
Albert Astals Cid wrote: > A Dilluns, 24 de gener de 2011, Stephen Kelly va escriure: >> Albert Astals Cid wrote: >> >> Is there something else that needs to be done? >> > >> > grep for EXTRACTQML and do the same ;-) >> >> How about this? > > Looks good. > > Albert Great. Committed and used n

Re: splitting up kdebase in git

2011-01-24 Thread Aaron J. Seigo
On Sunday, January 23, 2011, Allen Winter wrote: > On Tuesday 18 January 2011 6:15:04 pm Aaron J. Seigo wrote: > > On Tuesday, January 18, 2011, Allen Winter wrote: > > > On Tuesday 18 January 2011 4:34:21 pm Aaron J. Seigo wrote: > > > > hi all ... > > > > > > > > when looking at migrating kdebas

Re: i18n infrastructure for Grantlee templates

2011-01-24 Thread Albert Astals Cid
A Dilluns, 24 de gener de 2011, Stephen Kelly va escriure: > Albert Astals Cid wrote: > >> Is there something else that needs to be done? > > > > grep for EXTRACTQML and do the same ;-) > > How about this? Looks good. Albert

Re: i18n infrastructure for Grantlee templates

2011-01-24 Thread Stephen Kelly
Albert Astals Cid wrote: >> Is there something else that needs to be done? > > grep for EXTRACTQML and do the same ;-) > How about this? Index: update_translations === --- update_translations (revision 1216049) +++ update_translati

Re: i18n infrastructure for Grantlee templates

2011-01-24 Thread Albert Astals Cid
A Dilluns, 24 de gener de 2011, Stephen Kelly va escriure: > Albert Astals Cid wrote: > >> > * I'm not giving you EXTRACT_TEMPLATE_STRINGS, at most > >> > > >> > EXTRACT_GRANTLEE_TEMPLATE_STRINGS if you want ;-) > >> > >> That'll do :) > >> > >> >> Will that be a problem? Can I coordinate that

Re: i18n infrastructure for Grantlee templates

2011-01-24 Thread Stephen Kelly
Albert Astals Cid wrote: >> >> > * I'm not giving you EXTRACT_TEMPLATE_STRINGS, at most >> > >> > EXTRACT_GRANTLEE_TEMPLATE_STRINGS if you want ;-) >> >> That'll do :) >> >> >> Will that be a problem? Can I coordinate that with someone? >> > >> > With the KDE i18n coordinator (me) Ok, the sc

Re: Usefulness of Subject-header of git commit mails

2011-01-24 Thread Boudewijn Rempt
On Sunday 23 January 2011, Milian Wolff wrote: > Eike Hein, 23.01.2011: > > > @sysadmins: would it be possible to change the format for some repos or > > > is this not possible? I.e. leave the decision to the project > > > maintainers? > > > > Would you be OK with this hybrid format that we discus

Re: Usefulness of Subject-header of git commit mails

2011-01-24 Thread Boudewijn Rempt
On Sunday 23 January 2011, Milian Wolff wrote: > But probably my problem is that I only work on "semi-large" repositories like > KDevelop/KDevplatform/Kate. There I'm interested in *everything* that goes > on. > In Calligra you have only one big repo for all the apps, correct? Here I > indeed

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-24 Thread Chusslove Illich
> On Jan. 23, 2011, 4:56 p.m., Chusslove Illich wrote: > > /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/grantlee_strings_extractor.py, > > line 107 > > > > > > What is the difference between _() and i18n()? The ex

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-24 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6405/#review9702 --- - Chusslove On Jan. 23, 2011, 8:01 p.m., Stephen Kelly wrote: >

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-24 Thread Stephen Kelly
> On Jan. 23, 2011, 4:56 p.m., Chusslove Illich wrote: > > /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/grantlee_strings_extractor.py, > > line 107 > > > > > > What is the difference between _() and i18n()? The ex

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-24 Thread Chusslove Illich
> On Jan. 23, 2011, 4:56 p.m., Chusslove Illich wrote: > > /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/grantlee_strings_extractor.py, > > line 107 > > > > > > What is the difference between _() and i18n()? The ex