Re: The hidden problem with using QProcess/KProcess in kdelibs...

2011-01-23 Thread Thiago Macieira
On Sunday, 23 de January de 2011 23:20:37 Dawit A wrote: > Anyhow, after reading the response of one of the VLC developers in bug > report I listed in the original email, I am convinced that the reliance on > signals, which can so easily get cleared or worse blocked, in a library > class seems a re

Re: The hidden problem with using QProcess/KProcess in kdelibs...

2011-01-23 Thread Dawit A
On Sun, Jan 23, 2011 at 4:41 AM, Thiago Macieira wrote: > On Saturday, 22 de January de 2011 17:16:10 Dawit A wrote: > > The above snippet of code is something I clipped from > > > http://git.videolan.org/?p=vlc.git;a=blob;f=bin/vlc.c;h=70eeed0d2299e2f3cf0c > > 2f6819120f02d0703152;hb=HEAD > > >

[repo-management] hooks

2011-01-23 Thread Ben Cooksley
Git commit 56d644f3f56003986a86a9a17afcc4b3e008a913 by Ben Cooksley. Pushed by bcooksley into branch 'master'. Add message to email subject as requested. Common file path has been retained. CCMAIL: kde-core-devel@kde.org M +4-3hooks/hooklib.py http://commits.kde.org/repomgmt/56d644

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Tom Albers
- Oorspronkelijk bericht - > On 1/23/2011 9:30 PM, Milian Wolff wrote: > > What was broken? > > Nothing as far as Commitfilter is concerned. Commitfilter actually > acts on the X-Commit-Directories headers, not the mail subject. > This header was actually somewhat broken in the old mails,

Re: Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

2011-01-23 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6410/#review9697 --- Please add the @since tag for the right version (4.6 if you backpo

Re: Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

2011-01-23 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6410/#review9696 --- Ship it! Looks good to me, please commit. - Frederik On Jan. 2

Re: splitting up kdebase in git

2011-01-23 Thread Allen Winter
On Tuesday 18 January 2011 6:15:04 pm Aaron J. Seigo wrote: > On Tuesday, January 18, 2011, Allen Winter wrote: > > On Tuesday 18 January 2011 4:34:21 pm Aaron J. Seigo wrote: > > > hi all ... > > > > > > when looking at migrating kdebase to git (thanks to Ian Monroe for his > > > efforts there an

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Eike Hein
On 1/24/2011 12:03 AM, Allan Sandfeld Jensen wrote: Btw. This sounds like a really good format. Though I assume "commit subject" is still just the first line of the commit message, like it is commonly in git. When you have feature like that, the developers also needs to use that feature, so we ne

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Allan Sandfeld Jensen
On Sunday 23 January 2011, Eike Hein wrote: > > @sysadmins: would it be possible to change the format for some repos or > > is this not possible? I.e. leave the decision to the project > > maintainers? > > Would you be OK with this hybrid format that we discussed a few > days ago: > > [/*] : >

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Eike Hein
On 1/23/2011 11:32 PM, Milian Wolff wrote: I really hate that noone told me this before. I was not kidding when I said what you quoted above. Noone gave me *any* arguments in favor of the old format, except "it was like that in SVN times". Hence this whole thread (which, btw, I started since your

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Allan Sandfeld Jensen
On Sunday 23 January 2011, Milian Wolff wrote: > c) it's not possible to prioritize commit mails for reviewing. I get tons > every day and often only look at "urgent" mails, where urgent was so far > mostly related to committer + short commit msg. This worked really well, > now I have to look at al

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Eike Hein, 23.01.2011: > > @sysadmins: would it be possible to change the format for some repos or > > is this not possible? I.e. leave the decision to the project > > maintainers? > > Would you be OK with this hybrid format that we discussed a few > days ago: > > [/*] : > > * branch only shown

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Eike Hein, 23.01.2011: > On 1/23/2011 9:30 PM, Milian Wolff wrote: > > What was broken? > > Nothing as far as Commitfilter is concerned. Commitfilter actually > acts on the X-Commit-Directories headers, not the mail subject. > This header was actually somewhat broken in the old mails, it has > bee

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Eike Hein
@sysadmins: would it be possible to change the format for some repos or is this not possible? I.e. leave the decision to the project maintainers? Would you be OK with this hybrid format that we discussed a few days ago: [/*] : * branch only shown if != master. If we could agree on a hybrid

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Eike Hein
On 1/23/2011 9:30 PM, Milian Wolff wrote: What was broken? Nothing as far as Commitfilter is concerned. Commitfilter actually acts on the X-Commit-Directories headers, not the mail subject. This header was actually somewhat broken in the old mails, it has been fixed now as part of the hooks rew

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Boudewijn Rempt, 23.01.2011: > On Sunday 23 January 2011, Milian Wolff wrote: > > Hey all, > > > > I've brought this discussion to the sysadmins recently and they asked me > > to ask for feedback here. So there it goes: > > > > Recently, the format of the subject of git commit emails was adapted

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Boudewijn Rempt
On Sunday 23 January 2011, Milian Wolff wrote: > Hey all, > > I've brought this discussion to the sysadmins recently and they asked me to > ask for feedback here. So there it goes: > > Recently, the format of the subject of git commit emails was adapted to use > the old SVN format. This sucks i

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Ingo Klöcker
On Sunday 23 January 2011, Milian Wolff wrote: > Stephen Kelly, 23.01.2011: > > FWIW the problem I had with the old git format was that the subject > > was not long enough. I guess pretty=oneline only takes the first > > 72 chars or whatever of the first commit line, but in practice > > people don'

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Stephen Kelly, 23.01.2011: > Thomas Lübking wrote: > > Am Sun, 23 Jan 2011 20:43:42 +0100 > > > > schrieb Milian Wolff : > >> Recently, the format of the subject of git commit emails was adapted > >> to use the old SVN format. This sucks in my opinion and I want to > >> have it changed. > > > > T

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Ivan Čukić, 23.01.2011: > > Example: > > [KDevPlatform] fafd165: Don't completely ignore the retrieved top-context > > For me, this is more useful, so +1 > > Maybe adding a keyword 'commit' before the short hash like this > [KDevPlatform] Commit fafd165: Don't completely ignore the retrieved >

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Stephen Kelly
Thomas Lübking wrote: > Am Sun, 23 Jan 2011 20:43:42 +0100 > schrieb Milian Wolff : > >> Recently, the format of the subject of git commit emails was adapted >> to use the old SVN format. This sucks in my opinion and I want to >> have it changed. > > To me, this would be the driving question. >

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Thomas Lübking
Am Sun, 23 Jan 2011 20:43:42 +0100 schrieb Milian Wolff : > Recently, the format of the subject of git commit emails was adapted > to use the old SVN format. This sucks in my opinion and I want to > have it changed. To me, this would be the driving question. *Why* was it changed in the first plac

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-23 Thread Stephen Kelly
> On Jan. 23, 2011, 4:56 p.m., Chusslove Illich wrote: > > /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/grantlee_strings_extractor.py, > > line 358 > > > > > > Is it guaranteed that the order of messages in the ou

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-23 Thread Stephen Kelly
> On Jan. 23, 2011, 4:56 p.m., Chusslove Illich wrote: > > Thanks for the review! > On Jan. 23, 2011, 4:56 p.m., Chusslove Illich wrote: > > /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/grantlee_strings_extractor.py, > > line 107 > >

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-23 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6405/ --- (Updated Jan. 23, 2011, 8:01 p.m.) Review request for kdelibs, Pino Toscano

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Ivan Čukić
> Example: > [KDevPlatform] fafd165: Don't completely ignore the retrieved top-context For me, this is more useful, so +1 Maybe adding a keyword 'commit' before the short hash like this [KDevPlatform] Commit fafd165: Don't completely ignore the retrieved top-context -- Cheerio, Ivan -- Whil

Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Hey all, I've brought this discussion to the sysadmins recently and they asked me to ask for feedback here. So there it goes: Recently, the format of the subject of git commit emails was adapted to use the old SVN format. This sucks in my opinion and I want to have it changed. First lets expla

Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

2011-01-23 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6410/ --- Review request for kdelibs, Frederik Gladhorn and Jeremy Whiting. Summary --

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-23 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6405/#review9687 --- /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/grantlee_strings_

Re: Review Request: Add extraction scripts for translatable strings from Grantlee templates

2011-01-23 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6405/ --- (Updated Jan. 23, 2011, 1:24 p.m.) Review request for kdelibs, Pino Toscano

Re: The hidden problem with using QProcess/KProcess in kdelibs...

2011-01-23 Thread Thiago Macieira
On Saturday, 22 de January de 2011 17:16:10 Dawit A wrote: > The above snippet of code is something I clipped from > http://git.videolan.org/?p=vlc.git;a=blob;f=bin/vlc.c;h=70eeed0d2299e2f3cf0c > 2f6819120f02d0703152;hb=HEAD > > One cannot easily tell where QCoreApplication's ctor is getting > cal

Re: The hidden problem with using QProcess/KProcess in kdelibs...

2011-01-23 Thread Thiago Macieira
On Saturday, 22 de January de 2011 21:50:46 Michael Pyne wrote: > On Saturday, January 22, 2011 16:53:29 Thiago Macieira wrote: > > On Saturday, 22 de January de 2011 22:08:25 Christoph Bartoschek wrote: > > > Am Samstag 22 Januar 2011 schrieb Thiago Macieira: > > > > However, what I really want is